On Mon, 04 Nov 2013, Torrance, Douglas escribió: > > I'm not sure about whether this is a good idea. The default look is classic > > and > > I'd guess few people would ever want to change how wmaker looks like. > > For the classic look, a user just has to not touch the WMGLOBAL file. It's > still the default. > > As the writer of the patch, I'm certainly one of the people who would like to > change the look. :) The window manager itself is extremely customizable. I > think it would be nice if the corresponding widgets were as well. (It's > still nowhere near as powerful. There's no gradient or pixmap support, just > solid colors.) > > Doug
+1 for this patch. I think is good idea the people have the option to change things. I have a bug in the debian BTS about problems with colors, see [1]. If the user can change things, probably this wishlist bugs could be solved. Are only about 70 lines more only, moreover, the patches are clearer than the original code, for example: - tPtr->lightGray = WMCreateRGBColor(scr, 0xd9d9, 0xd9d9, 0xd9d9, False); - tPtr->tabColor = WMCreateRGBColor(scr, 0x8420, 0x8420, 0x8420, False); + tPtr->lightGray = scr->theme->unselectedTabHighlight; + tPtr->tabColor = scr->theme->unselectedTabBackground; Only one comment about them, probably the theme variable should be included in the global variable, not in scr. Thanks for your patches Doug! [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=21888 -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
