Before any comments, I totally agree that all the below suggestions should be incorporated after the interop, as it should be our key concern at this point.
Lawrence Mandel wrote: > Comments inline. > > Lawrence > > >> 1. Normally the HEAD of the build should be inside the trunk folder. But >> I saw the sources are inside a folder called "java". Was this >> intentional? Almost all the Apache projects follow the same structure of >> having the sources inside the trunk. > > The Java folder exists as 1) the Woden team was not familiar with SVN when > we started using it and 2) we tried to mirror what we saw in some other > projects > that had Java and C folders in CVS. I don't have a problem moving the work > to > the trunk folder for consistency. Any action plan for this? You want me to do this? > >> 2. I saw test resources like wsdl files, xml files were kept inside the >> test folder itself. Again from Apache WS project space, we have always >> have a separate folder called "test-resources" to hold all the test >> resources. Is there any reason behind putting the test sources within >> the test folder itself? Don't you its better to have only the test >> classes within the test folder and test resources inside the >> "test-resources"? > > I think this was a quick fix for trouble reading resources outside of the > test src tree. > We can revisit this. Shall we do it? > >> 3. I saw there were several zip files getting downloaded to get some >> dependency jars. Can we not download the whole zips and only download >> the dependent jars? All the dependent jars are available in maven repos. > > I set this up to download the whole zip so we would only use officially > released > versions of the projects and there would be no confusion over the level of > the > dependent project in use. Is the problem the bandwidth required to > download > the complete zip? Normally when almost all of the java projects releases a version, they update the maven repos as well. If you see the repos I have added they are from official releases. Can you please explain what u meant by "...there would be no confusion over the level of the dependent project in use.".Sorry, I can not understand how downloading just jars makes a confusion. Its just a metter of doing it simply and easily. Just my 2 cents. Chinthaka
signature.asc
Description: OpenPGP digital signature
