Eran,
I'm +1 to Lawrence's comments and suggestions.
I'm fine about changing source from /java folder to /trunk and moving test
files to a /test-resources folder and being able to use Maven or Ant to
build the project. My current focus is some fixes and function for the
Interop event, but I'm happy for you to contribute a Maven build process
that doesn't affect the Ant build. I have not yet tried Maven but would
like to, so this could be a useful learning opportunity for me.
thanks,
John Kaputin
Lawrence Mandel
<[EMAIL PROTECTED]
om> To
[email protected]
22/06/2006 15:39 cc
Subject
Please respond to Re: Woden Build System
[EMAIL PROTECTED]
he.org
Comments inline.
Lawrence
>1. Normally the HEAD of the build should be inside the trunk folder. But
>I saw the sources are inside a folder called "java". Was this
>intentional? Almost all the Apache projects follow the same structure of
>having the sources inside the trunk.
The Java folder exists as 1) the Woden team was not familiar with SVN when
we started using it and 2) we tried to mirror what we saw in some other
projects
that had Java and C folders in CVS. I don't have a problem moving the work
to
the trunk folder for consistency.
>2. I saw test resources like wsdl files, xml files were kept inside the
>test folder itself. Again from Apache WS project space, we have always
>have a separate folder called "test-resources" to hold all the test
>resources. Is there any reason behind putting the test sources within
>the test folder itself? Don't you its better to have only the test
>classes within the test folder and test resources inside the
>"test-resources"?
I think this was a quick fix for trouble reading resources outside of the
test src tree.
We can revisit this.
>3. I saw there were several zip files getting downloaded to get some
>dependency jars. Can we not download the whole zips and only download
>the dependent jars? All the dependent jars are available in maven repos.
I set this up to download the whole zip so we would only use officially
released
versions of the projects and there would be no confusion over the level of
the
dependent project in use. Is the problem the bandwidth required to download
the complete zip?
>Since I'm a maven fan, and since its better to have a maven build for
>Woden, I wrote the proper maven artifacts to use maven as the additional
>build system of Woden.
>
>You can run the goals in the existing ant build file as usual except you
> have to prefix your command with maven.
>
>For example, if u were running ant dist, then now you have to run maven
>run dist to run thru maven.
>
>I didn't remove the existing ability to use ant as the build system, but
> if one doesn't like to use ant (like me), he can use maven without a
>problem.
>
>I created a JIRA [1] attaching the patch.
Thanks. I'll second Arthur's comment that this should be investigated after
the interop event.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
