On 10/06/2015 16:10, Joe Taylor wrote: > Hi Bill, Hi Joe, > >> While testing this I also note that we don't have a setting to allow six >> digit grids to be sent. Should we be adding this to WSJT-X as well? > I noticed that, too. Yes, we should do this. OK, I will have a look at that. > > As for the way we wrap C routines, or otherwise make them callable from > Fortran: you've highlighted another way in which my quick-and-dirty > approach to writing code is arguably inelegant and less than desirable, > especially when many are participating. [It suited me just fine, when I > was doing things more or less alone. I knew what I was doing, and why. > And it was quick. :-) ] Fully understood. Quick and dirty is often best especially when prototyping new ideas.
The way I look at it is from a different angle: programming is about modelling and abstraction, header files/interfaces/classes/... are just a better way of documenting the models and abstraction in the code itself rather than having to recall what you meant later when something needs to change or has gone wrong. The bonus is that others can grasp the concepts faster too and if it is done correctly the maintenance is largely done within one module at a time. > > By all means, feel free to make the interfaces more elegant, when and if > that seems desirable. I have a few bits and pieces lying around awaiting more time to prepare and test but the issue with "modern" Fortran declarations is that they work so much better if modules are defined and that can be a bit disruptive and lead to regressions if it is not done carefully. An example being wqencode() calling nhash() and wsprd() calling nhash() also. The nhash() function clearly is shared by WSPR encoding and decoding but it is not generic. Underlying that is that either there should be a module for WSPR stuff i.e. encoding & decoding or there should be separate modules for encoding and decoding, possibly for more than one mode. The first question I would ask is "Is there more similarity between codecs for one specific mode than there is between encoding and decoding in general?". > > -- Joe 73 Bill G4WJS. ------------------------------------------------------------------------------ _______________________________________________ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel
