Re: [Xbmc-addons] [Git Pull] xbmc-dailyshow plugin submission

[Fritzl Inc.]

Hello Martijn,

thank you very much for the review and the valid points you have raised.
We'll get on this and send a new pull request.


Regards,

Fritzl Inc.
 

Gesendet: Freitag, 22. November 2013 um 13:00 Uhr
Von: "Martijn Kaijser" <mart...@xbmc.org>
An: "Fritzl Inc." <fritzl-...@gmx.de>
Cc: "xbmc-addons@lists.sourceforge.net" <xbmc-addons@lists.sourceforge.net>
Betreff: Re: [Xbmc-addons] [Git Pull] xbmc-dailyshow plugin submission

- Please follow e-mail format as defined here:
http://wiki.xbmc.org/index.php?title=Official_add-on_repository#How_to_submit_your_add-on_and_subsequent_updates
 

- python version should be 2.1.0

- please remove the beautifulsoup in your addon and used the one from repo
http://mirrors.xbmc.org/addons/frodo/script.module.beautifulsoup/
or
http://mirrors.xbmc.org/addons/frodo/script.module.beautifulsoup4/

and import this in your addon.xml

- you can also use http://mirrors.xbmc.org/addons/frodo/script.module.simplejson/  or use JSON directly from python itself.
http://forum.xbmc.org/showthread.php?tid=173887

- make sure all visible strings in the addon are translatable
http://wiki.xbmc.org/index.php?title=Add-on_development#.2Fresources.2Flanguage.2F
 

that were some remarks so far

 

 

regards,
Martijn Kaijser
Team XBMC

 

On Fri, Nov 22, 2013 at 11:54 AM, Fritzl Inc. <fritzl-...@gmx.de> wrote:

Hello,

 

we have created a new XBMC plugin for The Daily Show. This was based on previous work that never made it into the repository, but has been updated and cleaned a lot.

We are committed to further development, extension and maintenance, but first we would like your feedback on the plugin and the steps necessary to merge it into the Frodo (and Gotham, untested by us still) repoositories.

 

We are publishing our work at, and asking you to pill from:

http://repo.or.cz/w/xbmc-dailyshow.git

 

Regards,

Fritzl Inc.

------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing
conversations that shape the rapidly evolving mobile landscape. Sign up now.
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
 

------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons