1. The git url you should give for the pull request is http://repo.or.cz/r/xbmc-dailyshow.git (the one you gave is to view in a browser but can't be cloned). 2. For consistency with all addons, could you please rename LICENSE to LICENSE.txt 3. You need a language tag in your addon.xml. See http://wiki.xbmc.org/index.php?title=Addon.xml#Required_information 4. You use the MIT license, so that's what you should put in the license tag in your addon.xml
On Thu, Nov 28, 2013 at 2:23 PM, Fritzl Inc. <fritzl-...@gmx.de> wrote: > *addon - plugin.video.the.daily.show > *version - 1.0.3 > *url - http://repo.or.cz/w/xbmc-dailyshow.git > *revision - 898eadb > *branch - master > *xbmc version - frodo > > Please ignore the 1.0.2 release. This release additionally fixes an > incorrect statement in the README and removed the no-longer-used demjson.py > Sorry for any inconvenience, > > Fritzl, Inc. > Gesendet: Donnerstag, 28. November 2013 um 12:42 Uhr > Von: "Fritzl Inc." <fritzl-...@gmx.de> > An: "Martijn Kaijser" <mart...@xbmc.org> > Cc: "xbmc-addons@lists.sourceforge.net" <xbmc-addons@lists.sourceforge.net> > Betreff: [Xbmc-addons] [Git Pull] xbmc-dailyshow plugin submission > *addon - plugin.video.the.daily.show > *version - 1.0.2 > *url - http://repo.or.cz/w/xbmc-dailyshow.git > *revision - cd3cda4 > *branch - master > *xbmc version - frodo > > Thanks again for the earlier feedback. These additional problems should be > fixed. Please let me know if you notice any other issues. > Regards, > Fritzl Inc. > Gesendet: Mittwoch, 27. November 2013 um 09:28 Uhr > Von: "Martijn Kaijser" <mart...@xbmc.org> > An: "Fritzl Inc." <fritzl-...@gmx.de> > Cc: "xbmc-addons@lists.sourceforge.net" <xbmc-addons@lists.sourceforge.net> > Betreff: Re: [Git Pull] xbmc-dailyshow plugin submission > still see the beautifullsoup.py file there. you depend on a module so the > .py is obsolete. > please also add the <source> tag in you addon.xml pointing to your git. > icon.png should be 256x256 > also adjust the license.txt as it mentions the beautifullsoup file which has > it's own license shipped in the module > > think that should be it if no one else find something :) > > regards, > Martijn Kaijser > Team XBMC > > On Tue, Nov 26, 2013 at 10:44 PM, Fritzl Inc. <fritzl-...@gmx.de> wrote: >> >> *addon - plugin.video.the.daily.show >> *version - 1.0.1 >> *url - http://repo.or.cz/w/xbmc-dailyshow.git >> *revision - 43a2d62 >> *branch - master >> *xbmc version - frodo >> Thanks for the earlier feedback. These problems should be fixed. Please >> let me know if you notice any other issues. >> >> Regards, >> Fritzl Inc. >> >> Gesendet: Freitag, 22. November 2013 um 13:00 Uhr >> Von: "Martijn Kaijser" <mart...@xbmc.org> >> An: "Fritzl Inc." <fritzl-...@gmx.de> >> Cc: "xbmc-addons@lists.sourceforge.net" >> <xbmc-addons@lists.sourceforge.net> >> Betreff: Re: [Xbmc-addons] [Git Pull] xbmc-dailyshow plugin submission >> - Please follow e-mail format as defined here: >> >> http://wiki.xbmc.org/index.php?title=Official_add-on_repository#How_to_submit_your_add-on_and_subsequent_updates >> >> - python version should be 2.1.0 >> - please remove the beautifulsoup in your addon and used the one from repo >> http://mirrors.xbmc.org/addons/frodo/script.module.beautifulsoup/ >> or >> http://mirrors.xbmc.org/addons/frodo/script.module.beautifulsoup4/ >> and import this in your addon.xml >> - you can also use >> http://mirrors.xbmc.org/addons/frodo/script.module.simplejson/ or use JSON >> directly from python itself. >> http://forum.xbmc.org/showthread.php?tid=173887 >> - make sure all visible strings in the addon are translatable >> >> http://wiki.xbmc.org/index.php?title=Add-on_development#.2Fresources.2Flanguage.2F >> >> that were some remarks so far >> >> >> >> regards, >> Martijn Kaijser >> Team XBMC >> >> On Fri, Nov 22, 2013 at 11:54 AM, Fritzl Inc. <fritzl-...@gmx.de> wrote: >>> >>> Hello, >>> >>> we have created a new XBMC plugin for The Daily Show. This was based on >>> previous work that never made it into the repository, but has been updated >>> and cleaned a lot. >>> We are committed to further development, extension and maintenance, but >>> first we would like your feedback on the plugin and the steps necessary to >>> merge it into the Frodo (and Gotham, untested by us still) repoositories. >>> >>> We are publishing our work at, and asking you to pill from: >>> http://repo.or.cz/w/xbmc-dailyshow.git >>> >>> Regards, >>> Fritzl Inc. >>> >>> >>> ------------------------------------------------------------------------------ >>> Shape the Mobile Experience: Free Subscription >>> Software experts and developers: Be at the forefront of tech innovation. >>> Intel(R) Software Adrenaline delivers strategic insight and game-changing >>> conversations that shape the rapidly evolving mobile landscape. Sign up >>> now. >>> >>> http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> Xbmc-addons mailing list >>> Xbmc-addons@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >>> >> >> ________________________________ >> Diese E-Mail wurde aus dem Sicherheitsverbund E-Mail made in Germany >> versendet: http://www.gmx.net/e-mail-made-in-germany > > ________________________________ > Diese E-Mail wurde aus dem Sicherheitsverbund E-Mail made in Germany > versendet: http://www.gmx.net/e-mail-made-in-germany > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics > Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk_______________________________________________ > Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/xbmc-addons > ________________________________ > Diese E-Mail wurde aus dem Sicherheitsverbund E-Mail made in Germany > versendet: http://www.gmx.net/e-mail-made-in-germany > > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics > Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk > _______________________________________________ > Xbmc-addons mailing list > Xbmc-addons@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/xbmc-addons > ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk _______________________________________________ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
