[ https://issues.apache.org/jira/browse/YARN-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950274#comment-15950274 ]
Haibo Chen commented on YARN-6202: ---------------------------------- Reading comments above Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY, it seems like DISPATCHER_EXIT_ON_ERROR_KEY is deliberately set to false by default (see comment at https://issues.apache.org/jira/browse/MAPREDUCE-3634?focusedCommentId=13195964&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13195964). bq. YARN related configure item should be in class YarnConfiguration This property is not a user-facing property, only frameworks and tests use it, I think. so whether it should go into YarnConfiguration is debatable. > Configuration item Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY is disregarded > ------------------------------------------------------------------------- > > Key: YARN-6202 > URL: https://issues.apache.org/jira/browse/YARN-6202 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager, resourcemanager > Affects Versions: 2.9.0, 3.0.0-alpha2 > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: YARN-6202.001.patch, YARN-6202.002.patch > > > Dispatcher.DISPATCHER_EXIT_ON_ERROR_KEY (yarn.dispatcher.exit-on-error) > always be true no matter what value in configuration files. This misleads > users. Two solutions: > # Remove the configuration item and provide a method to allow > {{exitOnDispatchException}}/{{shouldExitOnError}} to be false to enable > related unit tests. There is no need for false value in a real daemon since > daemons should crash if its dispatcher quit. > # Make it default true instead of false, so that we don't need to hard code > it to be true in RM and NM, it is still configurable, and also provide method > to enable related unit tests. > Other than that, the code around it needs to refactor. {{public static > final}} for a variable of interface isn't necessary, and YARN related > configure item should be in class YarnConfiguration. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org