[ 
https://issues.apache.org/jira/browse/YARN-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300419#comment-16300419
 ] 

Sunil G commented on YARN-7612:
-------------------------------

Thanks [~asuresh] and [~kkaranasos] for working on this.

Some comments in general:

# I think *enablePlacementConstraints* could be application specific as well. I 
think if we can get YARN-7666 in, we could use that envs to specify whether an 
app needed to enable such constraints (more clearly to disable if needed).
# PlacementConstraintsManager interface could have some more javadoc to 
indicate more details about apis
# When will PlacementConstraintsManager be cleared OR contents deleted when 
apps are completed?
# NodeCandidateSelector is added in this patch. How different it is with 
existing *CandidateNodeSet* impls. We are adding a MultiNodeSelector in 
YARN-7494. and same could be used for all such complex node select strategies. 
Could we make use of same.?
# BatchedRequests is grouping a bunch of requests. Whats the criteria to 
include requests to a batch? Are expecting more policies in this? such as 
affinity etc. Because I can see we have different tag based view also in each 
batches. So whats the relation of these tags across batches?
# RM_PLACEMENT_RETRY_ATTEMPTS is at YARN level. Will it be more or less an 
applications choice?

I am still going through this code and may share some more comments if I have. 
Once again thanks for this great effort.

> Add Placement Processor Framework
> ---------------------------------
>
>                 Key: YARN-7612
>                 URL: https://issues.apache.org/jira/browse/YARN-7612
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-7612-YARN-6592.001.patch, 
> YARN-7612-YARN-6592.002.patch, YARN-7612-YARN-6592.003.patch, 
> YARN-7612-YARN-6592.004.patch, YARN-7612-YARN-6592.005.patch, 
> YARN-7612-YARN-6592.006.patch, YARN-7612-YARN-6592.007.patch, 
> YARN-7612-YARN-6592.008.patch, YARN-7612-v2.wip.patch, YARN-7612.wip.patch
>
>
> This introduces a Placement Processor and a Planning algorithm framework to 
> handle placement constraints and scheduling requests from an app and places 
> them on nodes.
> The actual planning algorithm(s) will be handled in a YARN-7613.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to