[ https://issues.apache.org/jira/browse/YARN-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301638#comment-16301638 ]
Sunil G commented on YARN-7612: ------------------------------- Thanks [~asuresh] bq.But Currently, and to keep things less complicated, I just assumed the app can control this with the presence or absence of the PlacementConstraint mappings in the register call. I had one smaller concern here. I think its better to handle a duplicate check provided {{yarn.resourcemanager.application-master-service.processors}} could be also configured with new {{PlacementProcessor}} # So all rejectedRequests are going in one batch. This seems fine. But in case where we have too many failures on placement, do you see a corner case where number of requests in batch is bigger. # In PlacementProcessor, schedulePlacedRequests is invoked after *reDispatchRetryableRequests*. So * requestsToRetry* will be mostly cleaned up, correct?. In that case, does addToRetryList need to handle it again? # in below code SamplePlacementAlgorithm#place, does it create bit of confusion as we take from head always. {code} 93 String targetTag = 94 targetConstraint.getTargetExpressions().iterator().next() 95 .getTargetValues().iterator().next(); {code} Also in same method, there are some toDO comments on exception handling? Is to be handled in this patch itself or later? # > Add Placement Processor Framework > --------------------------------- > > Key: YARN-7612 > URL: https://issues.apache.org/jira/browse/YARN-7612 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Arun Suresh > Assignee: Arun Suresh > Attachments: YARN-7612-YARN-6592.001.patch, > YARN-7612-YARN-6592.002.patch, YARN-7612-YARN-6592.003.patch, > YARN-7612-YARN-6592.004.patch, YARN-7612-YARN-6592.005.patch, > YARN-7612-YARN-6592.006.patch, YARN-7612-YARN-6592.007.patch, > YARN-7612-YARN-6592.008.patch, YARN-7612-YARN-6592.009.patch, > YARN-7612-YARN-6592.010.patch, YARN-7612-v2.wip.patch, YARN-7612.wip.patch > > > This introduces a Placement Processor and a Planning algorithm framework to > handle placement constraints and scheduling requests from an app and places > them on nodes. > The actual planning algorithm(s) will be handled in a YARN-7613. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org