[
https://issues.apache.org/jira/browse/YARN-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327451#comment-16327451
]
Sunil G commented on YARN-6599:
-------------------------------
Thanks [~leftnoteasy]. Few comments.
# {{public static final String APP_ID_TAG_PREFIX = "yarn_app_id/";}} Could
this be categorized under {{yarn_application_label}} as sub category. I think
if all app related could be under same tag, its better.
# {{CapacitySchedulerConfiguration.SCHEDULING_REQUEST_ALLOWED}} I think this
flag is not needed. Could we simply check whether *schedulingRequests* is
present along with *resourceRequests* and handle error scenarios. Any advantage
of having this flag other than validation?
# scope of anti-affinity is only to intra-app when PlacementConstraints is
Node. *intra-app* is a bit confusing term to me. For eg, we are at high level
now doing an anti-affinity for app1's region server not run with app1's
hmaster. Does this mean that app2's hmaster can run with app1's region server.
cud u pls help to clarify this.
# Levels of iterations to check whether a constraint is valid or not is a bit
sequential. So could we have a state level verfication whether an incoming
request with a constraint is valid or not. What i meant is tat, we can move
these validations to a separate class so that its very much easy to define
error states etc.
> Support rich placement constraints in scheduler
> -----------------------------------------------
>
> Key: YARN-6599
> URL: https://issues.apache.org/jira/browse/YARN-6599
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Priority: Major
> Attachments: YARN-6599-YARN-6592.003.patch,
> YARN-6599-YARN-6592.004.patch, YARN-6599-YARN-6592.005.patch,
> YARN-6599-YARN-6592.006.patch, YARN-6599-YARN-6592.007.patch,
> YARN-6599-YARN-6592.008.patch, YARN-6599-YARN-6592.009.patch,
> YARN-6599-YARN-6592.010.patch, YARN-6599-YARN-6592.wip.002.patch,
> YARN-6599.poc.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
