[ https://issues.apache.org/jira/browse/YARN-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327670#comment-16327670 ]
Wangda Tan commented on YARN-6599: ---------------------------------- Thanks comments from [~sunilg] / [~asuresh], For comments from [~sunilg] , # Removed all APP_ID_TAG_PREFIX, it should be replaced by allocationTagIntraApp already. # The reason is we want to make sure: a. Since this is a new code, we will not accept SchedulingRequest as it may cause damages to RM. b. PlacementProcessor is doing the same thing with a different approach, user needs to enable one of them to work. # Currently, intra-app anti-affinity is not mutual, which means if SchedulRequest_A (with allocation tag x) want to anti-affinity to allocation tags=y, the other SchedulingRequest_B (with allocation tag y) need explicitly specify anti-affinity to allocation tag=x. # Since this involves PlacementProcessor, let's move the change to a different Jira. For comments from [~asuresh] , As we discussed offline, we will add SchedulingRequest as part of the PlacementConstraintUtil method and both of processor/scheduler implementation will use the same logic. The logic looks like: {code:java} PlacementConstraint pc = schedulingRequest.getPlacementConstraint(); If (pc == null) { pc = PlacementConstraintMgr.getPlacementConstraint(schedulingRequest.getAllocationTags()); } // Do placement constraint match ...{code} Let's move it to a separate Jira. Attached ver.11 patch with changes mentioned. > Support rich placement constraints in scheduler > ----------------------------------------------- > > Key: YARN-6599 > URL: https://issues.apache.org/jira/browse/YARN-6599 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Wangda Tan > Assignee: Wangda Tan > Priority: Major > Attachments: YARN-6599-YARN-6592.003.patch, > YARN-6599-YARN-6592.004.patch, YARN-6599-YARN-6592.005.patch, > YARN-6599-YARN-6592.006.patch, YARN-6599-YARN-6592.007.patch, > YARN-6599-YARN-6592.008.patch, YARN-6599-YARN-6592.009.patch, > YARN-6599-YARN-6592.010.patch, YARN-6599-YARN-6592.011.patch, > YARN-6599-YARN-6592.wip.002.patch, YARN-6599.poc.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org