[ https://issues.apache.org/jira/browse/YARN-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327517#comment-16327517 ]
Arun Suresh commented on YARN-6599: ----------------------------------- Thanks for the update [~leftnoteasy] I just have couple of minor comments: As we discussed offline, to maintain consistency with the processor approach, atleast at an API level, can we do the following: Currently, the processor expects all placement constraints for the app to sent in the register call. Any placement constraint specified in the SchedulingRequest should be an override of the constraints specified in the mapping provided in the registerAM call. The mapping that is sent in the register call is of the form {{Map<Set<String>, PlaccementConstrint>}}, where the key is a set of allocation tags. Then in the specific schedulingRequest, we refer to the PlacementConstraint using the allocation tags (The PlacementConstraintsManager holds the mapping). This means you need to set the allocation tags in the scheduling request. If the SchedulingRequest contains a PlacementRequest, then it will first replace the mapping in the PlacementConstraintsManager and then apply the constraints to the SchedulingRequest. Am +1 after that > Support rich placement constraints in scheduler > ----------------------------------------------- > > Key: YARN-6599 > URL: https://issues.apache.org/jira/browse/YARN-6599 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Wangda Tan > Assignee: Wangda Tan > Priority: Major > Attachments: YARN-6599-YARN-6592.003.patch, > YARN-6599-YARN-6592.004.patch, YARN-6599-YARN-6592.005.patch, > YARN-6599-YARN-6592.006.patch, YARN-6599-YARN-6592.007.patch, > YARN-6599-YARN-6592.008.patch, YARN-6599-YARN-6592.009.patch, > YARN-6599-YARN-6592.010.patch, YARN-6599-YARN-6592.wip.002.patch, > YARN-6599.poc.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org