[
https://issues.apache.org/jira/browse/YARN-6672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524371#comment-16524371
]
Haibo Chen commented on YARN-6672:
----------------------------------
Thanks for the review, [~elgoiri]! I updated the patch to address your comments.
{quote} * Use logger style in ContainerScheduler#228.{quote}
I am doing 'LOG.error( "Unknown event type on Preempt containers: {}",
event.getType())' now, let me know if that's not what you meant by logger style.
{quote}For the unit tests in TestContainerSchedulerWithOverAllocation, I would
try to do the new unit tests with and without the feature enabled. This would
require some refactor.
{quote}
I made minimal refactoring to keep the patch small and added new unit tests in
TestContainerSchedulerQueuing, where the unit tests without the feature are
located.
> Add NM preemption of opportunistic containers when utilization goes high
> ------------------------------------------------------------------------
>
> Key: YARN-6672
> URL: https://issues.apache.org/jira/browse/YARN-6672
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.0.0-alpha3
> Reporter: Haibo Chen
> Assignee: Haibo Chen
> Priority: Major
> Attachments: YARN-6672-YARN-1011.00.patch,
> YARN-6672-YARN-1011.01.patch, YARN-6672-YARN-1011.02.patch,
> YARN-6672-YARN-1011.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
