[
https://issues.apache.org/jira/browse/YARN-6672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527882#comment-16527882
]
Haibo Chen commented on YARN-6672:
----------------------------------
Thanks [~elgoiri] for the follow-up review!
{quote} * Not sure DrainableContainerManager is the best name as it also checks
utilization.{quote}
Indeed. I renamed it to ContainerManagerForTest, which is very generic, for the
lack of a descriptive name that I can think of. Any suggestion is appreciated.
{quote} * We seem to set the memory utilization to 2048 when we only have 512
in some cases.{quote}
Can you point out in which unit tests you see this? I seem to miss this while
trying to find in the node.
I added more comments in TestSnapshotBasedOverAllocationPreemptionPolicy to
explain where some of the numbers come from.
For the numbers in the other unit tests, I try to explain the numbers in
multiple locations, that is, multiple comments throughout a unit test. The key
thing to note is that it is the containers' aggregate resource requests, their
execution type, the node utilization, the over-allocation threshold and the
preemption threshold that all together sets up the specific test cases.
I have limited the comments to the new unit tests added in the patch. Once we
finalize the comments, I can create another Jira to address the other existing
unit tests.
> Add NM preemption of opportunistic containers when utilization goes high
> ------------------------------------------------------------------------
>
> Key: YARN-6672
> URL: https://issues.apache.org/jira/browse/YARN-6672
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.0.0-alpha3
> Reporter: Haibo Chen
> Assignee: Haibo Chen
> Priority: Major
> Attachments: YARN-6672-YARN-1011.00.patch,
> YARN-6672-YARN-1011.01.patch, YARN-6672-YARN-1011.02.patch,
> YARN-6672-YARN-1011.03.patch, YARN-6672-YARN-1011.04.patch,
> YARN-6672-YARN-1011.05.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
