[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529118#comment-16529118
]
Naganarasimha G R commented on YARN-7863:
-----------------------------------------
[~sunilg],
Few queries before going into the detail ...
1. who is doing the validation of the resource request?
2. If there are any open resource request for specified attribute, do we allow
removing of that attribute from Attribute Manager ?
3. Confused little with the logic (may be earlier code to yours), i was always
of the opinion that the partition is the first to be compared and then with tag
or attribute here it seems to first check for the allocation tag and then for
partition and then attribute. should it not be like under a given parition
check any nodes having allocation tags and/or attributes satisfying the user's
request?
Some comments :
1. PlacementConstraintsUtil, ln no 145-156 : Scheduler node needs to be having
map of NodeAttributeKey -> NodeAttribute value to make it O(1), as well this
will more useful when we go other types and operator based comparison happens.
Or to consider for current scenario atleast it would be better to override
NodeAttribute's equals method.
> Modify placement constraints to support node attributes
> -------------------------------------------------------
>
> Key: YARN-7863
> URL: https://issues.apache.org/jira/browse/YARN-7863
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil Govindan
> Assignee: Sunil Govindan
> Priority: Major
> Attachments: YARN-7863.v0.patch
>
>
> This Jira will track to *Modify existing placement constraints to support
> node attributes.*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
