[ https://issues.apache.org/jira/browse/YARN-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678324#comment-16678324 ]
Weiwei Yang commented on YARN-8984: ----------------------------------- Thanks for the updates [~fly_in_gis], it almost seems good to me. One thought if we remove that null check {code} List<SchedulingRequest> schedReqs = outstandingSchedRequests.get(container.getAllocationTags()); {code} now this seems to be possible to throw NPE, when container.getAllocationTags() is null. > AMRMClient#OutstandingSchedRequests leaks when AllocationTags is null or empty > ------------------------------------------------------------------------------ > > Key: YARN-8984 > URL: https://issues.apache.org/jira/browse/YARN-8984 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Yang Wang > Assignee: Yang Wang > Priority: Critical > Attachments: YARN-8984-001.patch, YARN-8984-002.patch, > YARN-8984-003.patch > > > In AMRMClient, outstandingSchedRequests should be removed or decreased when > container allocated. However, it could not work when allocation tag is null > or empty. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org