[
https://issues.apache.org/jira/browse/YARN-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678649#comment-16678649
]
Konstantinos Karanasos commented on YARN-8984:
----------------------------------------------
If I remember correctly, the Scheduling Requests are used only in case we have
placement constraints (at least this was the initial design, not sure if things
have changed recently).
Given that, at successful container allocation, the Container Request of
unconstrained requests will be properly removed through a different code-path.
That said, if we want to start using Scheduling Request objects even without
constraints (I don't see a reason why do this urgently, but we can do it in the
long run), then I think we should fix the code. As [~cheersyang] said, I don't
think the current fix will work, since the {{schedReqs}} will be null when
there are no tags, and the map of {{outstandingSchedRequests}} has the
allocation tags as key.
Adding [~asuresh] (Arun, I think you worked on that code last, so let me know
if I am missing something) and [~leftnoteasy].
> AMRMClient#OutstandingSchedRequests leaks when AllocationTags is null or empty
> ------------------------------------------------------------------------------
>
> Key: YARN-8984
> URL: https://issues.apache.org/jira/browse/YARN-8984
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Yang Wang
> Assignee: Yang Wang
> Priority: Critical
> Attachments: YARN-8984-001.patch, YARN-8984-002.patch,
> YARN-8984-003.patch
>
>
> In AMRMClient, outstandingSchedRequests should be removed or decreased when
> container allocated. However, it could not work when allocation tag is null
> or empty.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
