[
https://issues.apache.org/jira/browse/YARN-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681055#comment-16681055
]
Weiwei Yang commented on YARN-8984:
-----------------------------------
Hi [~fly_in_gis]
Thanks for the updates. Looks like we agreed on using an empty set as a key for
scheduling requests on following conditions:
* Not set any tags
* Set a empty set, e.g ImmutableSet.of(), new HashSet<>()
* Set null
Can we create a test case to verify all upon cases will group requests and map
them to one key? I think it should be as empty set should have same hash code.
We could just test #addSchedulingRequests and #getOutstandingSchedRequests, no
need to submit & allocate for these requests.
And could u fix the checkstyle issues as well, some lines exceed 80 chars.
Thanks
> AMRMClient#OutstandingSchedRequests leaks when AllocationTags is null or empty
> ------------------------------------------------------------------------------
>
> Key: YARN-8984
> URL: https://issues.apache.org/jira/browse/YARN-8984
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Yang Wang
> Assignee: Yang Wang
> Priority: Critical
> Attachments: YARN-8984-001.patch, YARN-8984-002.patch,
> YARN-8984-003.patch, YARN-8984-004.patch
>
>
> In AMRMClient, outstandingSchedRequests should be removed or decreased when
> container allocated. However, it could not work when allocation tag is null
> or empty.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
