On Tue, 2011-05-03 at 11:27 -0400, Raman Gupta wrote:

> However, for config_noreplace in my opinion we want:
> 
>       diff pkg_file local_file
> 
> so that the file /etc/foo.conf is *still* on the right. In this case,
> it is the meaning of "new" where there is perhaps some confusion --
> the way I am interpreting "new" is that the file on the right is the
> "new" file *from this point forward*

 I don't think that's a useful meaning, but maybe I'm seeing it too much
from a programmer POV. But say you have:

  pkgA-1 foo.conf:

"""
# This is my config file.
# Change the name, if you want
name = blah
"""

  pkgA-2 foo.conf:

"""
# This is my config file.
# Change the name, if you want
name = blah
# Change otherthing, to snafu or null
otherthing = snafu
"""

...now say we install pkgA-1, and then alter it to "name = myname" then
do an upgrade. What do we want to see in both cases? I'm pretty sure we
_want_ to see:

 # This is my config file.
 # Change the name, if you want
 name = myname
+# Change otherthing, to snafu or null
+otherthing = snafu

...but we can't, easily, so we have a choice between:

 # This is my config file.
 # Change the name, if you want
-name = myname
+name = blah
+# Change otherthing, to snafu or null
+otherthing = snafu

..and:

 # This is my config file.
 # Change the name, if you want
-name = blah
+name = myname
-# Change otherthing, to snafu or null
-otherthing = snafu

...and I'd argue that the first is much closer to "ideal".
 I think it's also likely to be more intuitive for the sysadmin if the
"local file" is always in the same place.

 Any other opinions?

_______________________________________________
Yum-devel mailing list
[email protected]
http://lists.baseurl.org/mailman/listinfo/yum-devel

Reply via email to