On 05/03/2011 01:30 PM, Raman Gupta wrote:
> On 05/03/2011 01:13 PM, Ville Skyttä wrote:
>> On 05/03/2011 06:48 PM, James Antill wrote:
>>
>>> ...and I'd argue that the first is much closer to "ideal".
>>>  I think it's also likely to be more intuitive for the sysadmin if the
>>> "local file" is always in the same place.
>>>
>>>  Any other opinions?
>>
>> Agreed with James.
> 
> One thing to add to my previous email is I'm wondering why you care
> about local_file? local_file changes anyway depending on whether it is
> config_replace or config_noreplace.
> 
> What should be consistent for the sysadmin is the location of
> "final_file", which is local_file in the case of config_noreplace and
> "pkg_file" in the case of config_replace. This is the one file that is
> always applicable -- the final location into which all changes have to
> be merged.

Any further thoughts on this? I still think my approach is the right
one for sysadmins, but if the only thing preventing merging of this
patch is this issue, I can change the patch. After all, admins can
always reverse the diff using meld or vimdiff.

Cheers,
Raman
_______________________________________________
Yum-devel mailing list
[email protected]
http://lists.baseurl.org/mailman/listinfo/yum-devel

Reply via email to