[kudu-CR] Add basic support for UNIX domain sockets

2020-04-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: Add basic support for UNIX domain sockets .. Patch Set 7: (10 comments) http://gerrit.cloudera.org:8080/#/c/15691/7

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-14 Thread Todd Lipcon (Code Review)
visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I40ce3e4e1b98f806f0c29d2fbd88789657218c4b Gerrit-Change-Number: 15691 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Review

[kudu-CR] rpc: add support for passing an open file descriptor across a unix socket

2020-04-14 Thread Todd Lipcon (Code Review)
: newpatchset Gerrit-Change-Id: I89baff83fa85f9109429fdc29d6eefc9f0f8b4a2 Gerrit-Change-Number: 15706 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. net: make Sockaddr more generic for other address

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-14 Thread Todd Lipcon (Code Review)
visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I40ce3e4e1b98f806f0c29d2fbd88789657218c4b Gerrit-Change-Number: 15691 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wo

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15691 ) Change subject: Add basic support for UNIX domain sockets .. Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/15691/4

[kudu-CR] Add basic support for UNIX domain sockets

2020-04-14 Thread Todd Lipcon (Code Review)
8080/15691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I40ce3e4e1b98f806f0c29d2fbd88789657218c4b Gerrit-Change-Number: 15691 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wo

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-14 Thread Todd Lipcon (Code Review)
ubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifff57e13a0e9b86b191d776ead67371b1e2ed4e3 Gerrit-Change-Number: 15690 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-R

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 3: (2 comments) http://gerrit.cloudera.org

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15716 ) Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately .. rpc: avoid an extra epoll cycle when data

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15716 ) Change subject: rpc: avoid an extra epoll cycle when data can be sent immediately .. Patch Set 3: Verified+1 Test failures look

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-13 Thread Todd Lipcon (Code Review)
r: 15716 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)

Re: Proposal for supported OS version changes

2020-04-13 Thread Todd Lipcon
entOS 7 (with devtoolset gcc) > >- CentOS 8 > >- RHEL 6 (deprecated) > > - RHEL 7 (with devtoolset gcc) > >- RHEL 8 > >- Ubuntu 14.04 (deprecated) > >- Ubuntu 16.04 > >- Ubuntu 18.04 > >- Debian 8 (deprecated) > >- Debian 9 > >- SLES 12 (with toolchain gcc) > > > > Please provide your feedback, suggestions, or agreement on this proposal. > > > > Thank you, > > Grant > > > -- Todd Lipcon Software Engineer, Cloudera

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-13 Thread Todd Lipcon (Code Review)
it-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] rpc: avoid an extra epoll cycle when data can be sent immediately

2020-04-11 Thread Todd Lipcon (Code Review)
rit.cloudera.org:8080/15716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I30af102224d5db2cb526b4c2ae981d6e9defd82a Gerrit-Change-Number: 15716 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] WIP: rpc: add support for passing an open file descriptor across a unix socket

2020-04-10 Thread Todd Lipcon (Code Review)
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I89baff83fa85f9109429fdc29d6eefc9f0f8b4a2 Gerrit-Change-Number: 15706 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit

[kudu-CR] WIP: rpc: add support for passing an open file descriptor across a unix socket

2020-04-10 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I89baff83fa85f9109429fdc29d6eefc9f0f8b4a2 Gerrit-Change-Number: 15706 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy

[kudu-CR] Add basic support for unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
a.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I40ce3e4e1b98f806f0c29d2fbd88789657218c4b Gerrit-Change-Number: 15691 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerri

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 3: Sorry for repeated comments, but one more

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] Use unix domain socket for local client/server communication

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/957 ) Change subject: Use unix domain socket for local client/server communication .. Abandoned took a new approach of this here: https

[kudu-CR] Add basic support for unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
ject: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I40ce3e4e1b98f806f0c29d2fbd88789657218c4b Gerrit-Change-Number: 15691 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Revi

[kudu-CR] client/tserver: add support for connecting over unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Mike Percy

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-09 Thread Todd Lipcon (Code Review)
ubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifff57e13a0e9b86b191d776ead67371b1e2ed4e3 Gerrit-Change-Number: 15690 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Ba

[kudu-CR] Add basic support for unix domain sockets

2020-04-09 Thread Todd Lipcon (Code Review)
rit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I40ce3e4e1b98f806f0c29d2fbd88789657218c4b Gerrit-Change-Number: 15691 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer:

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 ) Change subject: net: make Sockaddr more generic for other address families .. Patch Set 2: (12 comments) http://gerrit.cloudera.org

[kudu-CR] WIP: Remove limit on number of sidecar slices

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/5895 ) Change subject: WIP: Remove limit on number of sidecar slices .. Abandoned I ended up implementing

[kudu-CR] WIP: Add basic support for unix sockets

2020-04-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15691 Change subject: WIP: Add basic support for unix sockets .. WIP: Add basic support for unix sockets so far can't seem to reproduce any

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Todd Lipcon (Code Review)
Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifff57e13a0e9b86b191d776ead67371b1e2ed4e3 Gerrit-Change-Number: 15690 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy

[kudu-CR] net: make Sockaddr more generic for other address families

2020-04-08 Thread Todd Lipcon (Code Review)
errit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifff57e13a0e9b86b191d776ead67371b1e2ed4e3 Gerrit-Change-Number: 15690 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Mike Percy

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-08 Thread Todd Lipcon (Code Review)
-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3591e85a07aefadaf7fb05768109c8a261a8828e Gerrit-Change-Number: 15677 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-07 Thread Todd Lipcon (Code Review)
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9b7ff78547792acbd975a606a02ec388dba3a8e8 Gerrit-Change-Number: 15679 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] columnar serialization: fix optimized GCC build

2020-04-07 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/15680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7 Gerrit-Change-Number: 15680 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon

[kudu-CR] columnar serialization: fix build on older gccs

2020-04-07 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7 Gerrit-Change-Number: 15680 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant

[kudu-CR] columnar serialization: avoid preallocating 8MB per column

2020-04-07 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9b7ff78547792acbd975a606a02ec388dba3a8e8 Gerrit-Change-Number: 15679 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer

[kudu-CR] Avoid calling Schema::find column() once per RowBlock in columnar serialization

2020-04-07 Thread Todd Lipcon (Code Review)
ch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1b683c7d6d6fe1026ee06c8b5ebfe2a5f1ee6cb1 Gerrit-Change-Number: 15678 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15044 ) Change subject: cfile: clean up encoding-test to use fewer templates .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] tserver: add locking around an RPC's usage of a Scanner

2020-04-07 Thread Todd Lipcon (Code Review)
-MessageType: newchange Gerrit-Change-Id: I3591e85a07aefadaf7fb05768109c8a261a8828e Gerrit-Change-Number: 15677 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. wire_protocol: change columnar

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-07 Thread Todd Lipcon (Code Review)
: Iadf728744feb83f5980e62bea4fd7634a1a52467 Gerrit-Change-Number: 15660 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. Patch Set 3: (4 comments) http

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. Patch Set 3: (1 comment) http

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. Patch Set 3: (7 comments) http

[kudu-CR] util: remove duplicate results from DNS resolution

2020-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15665 ) Change subject: util: remove duplicate results from DNS resolution .. util: remove duplicate results from DNS resolution

Re: C interface clarifications

2020-04-07 Thread Todd Lipcon
On Tue, Apr 7, 2020 at 2:40 AM Antoine Pitrou wrote: > > Le 06/04/2020 à 19:22, Todd Lipcon a écrit : > > > > The spec should also probably cover thread-safety: if the consumer gets > an > > ArrowArray, is it safe to pass off the children to multiple threads and

[kudu-CR] util: remove duplicate results from DNS resolution

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15665 ) Change subject: util: remove duplicate results from DNS resolution .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] util: remove duplicate results from DNS resolution

2020-04-06 Thread Todd Lipcon (Code Review)
: I7d9b9f9839a899d8022f5ac6496555ff84583192 Gerrit-Change-Number: 15665 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin

[kudu-CR] WIP: support for passing arrow data to python

2020-04-06 Thread Todd Lipcon (Code Review)
ject: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5df4714bf5ac339d675f2a9169f8aeff06d30eed Gerrit-Change-Number: 15661 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] WIP: support for passing arrow data to python

2020-04-06 Thread Todd Lipcon (Code Review)
-Change-Id: I5df4714bf5ac339d675f2a9169f8aeff06d30eed Gerrit-Change-Number: 15661 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. Patch Set 2: (2 comments) http

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-06 Thread Todd Lipcon (Code Review)
-Number: 15660 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15660 ) Change subject: wire_protocol: change columnar serialization of varlen data to match Arrow .. Patch Set 2: (6 comments) http

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-06 Thread Todd Lipcon (Code Review)
-Number: 15660 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] wire protocol: change columnar serialization of varlen data to match Arrow

2020-04-06 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/15660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iadf728744feb83f5980e62bea4fd7634a1a52467 Gerrit-Change-Number: 15660 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15634 ) Change subject: columnar_serialization: use AVX2 for int32 and int64 copying .. columnar_serialization: use AVX2 for int32

Re: C interface clarifications

2020-04-06 Thread Todd Lipcon
On Mon, Apr 6, 2020 at 9:57 AM Antoine Pitrou wrote: > > Hello Todd, > > Le 06/04/2020 à 18:18, Todd Lipcon a écrit : > > > > I had a couple questions / items that should be clarified in the spec. > Wes > > suggested I raise them here on dev@: > > > >

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15634 ) Change subject: columnar_serialization: use AVX2 for int32 and int64 copying .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] rowblock: use BMI instruction set when available for GetSelectedRows

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15635 ) Change subject: rowblock: use BMI instruction set when available for GetSelectedRows .. rowblock: use BMI instruction set when

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15634 ) Change subject: columnar_serialization: use AVX2 for int32 and int64 copying .. Patch Set 3: Verified+1 the release build failed

C interface clarifications

2020-04-06 Thread Todd Lipcon
hould "stand alone" and be individually releasable (and thus moveable) (b) a produced struct must have the same lifetime as all children. Consumers should not release children, and if they release the original base, all children are invalidated regardless of whether they have been moved

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-04 Thread Todd Lipcon (Code Review)
ubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6c9a536b78a524e8178f5d4a0d2dea04deedbd78 Gerrit-Change-Number: 15634 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[jira] [Commented] (KUDU-3105) kudu_client based application reports 'Locking callback not initialized' error

2020-04-03 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074719#comment-17074719 ] Todd Lipcon commented on KUDU-3105: --- I ran into this last night while using conda on el7 to get a rather

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-02 Thread Todd Lipcon (Code Review)
ubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6c9a536b78a524e8178f5d4a0d2dea04deedbd78 Gerrit-Change-Number: 15634 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] rowblock: use BMI instruction set when available for GetSelectedRows

2020-04-02 Thread Todd Lipcon (Code Review)
Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8ec74bc5db07c18d0e36de14a2343f49fc5c2859 Gerrit-Change-Number: 15635 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim

[kudu-CR] rowblock: use BMI instruction set when available for GetSelectedRows

2020-04-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15635 ) Change subject: rowblock: use BMI instruction set when available for GetSelectedRows .. Patch Set 1: (4 comments) http

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15634 ) Change subject: columnar_serialization: use AVX2 for int32 and int64 copying .. Patch Set 1: (13 comments) http://gerrit.cloudera.org

[kudu-CR] rowblock: use BMI instruction set when available for GetSelectedRows

2020-04-01 Thread Todd Lipcon (Code Review)
-Id: I8ec74bc5db07c18d0e36de14a2343f49fc5c2859 Gerrit-Change-Number: 15635 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke

[kudu-CR] columnar serialization: use AVX2 for int32 and int64 copying

2020-04-01 Thread Todd Lipcon (Code Review)
s Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6c9a536b78a524e8178f5d4a0d2dea04deedbd78 Gerrit-Change-Number: 15634 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke

[kudu-CR] client: add support for columnar format scan

2020-04-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. client: add support for columnar format scan Change-Id

[jira] [Commented] (KUDU-3102) tabletserver coredump in jsonwriter

2020-04-01 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073133#comment-17073133 ] Todd Lipcon commented on KUDU-3102: --- Or likely that an earlier bit of code had an out of bounds write

[kudu-CR] client: add support for columnar format scan

2020-04-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15622/2

[kudu-CR] client: add support for columnar format scan

2020-04-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/15622/1

[kudu-CR] client: add support for columnar format scan

2020-04-01 Thread Todd Lipcon (Code Review)
Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Todd Lipcon (Code Review)
Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. tserver: add support for returning scan

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15622 ) Change subject: client: add support for columnar format scan .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15622/1

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. Patch Set 4: Verified+1 Test failure

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: tserver: add support for returning scan result in columnar layout .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] client: add support for columnar format scan

2020-03-31 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I69ec4487c78b872e7b9eba5facdd44cfd6b8f4fa Gerrit-Change-Number: 15622 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
: Ib99faa27554ec228492f096bb8760c883e44660d Gerrit-Change-Number: 15602 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
-Change-Number: 15602 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 ) Change subject: tserver: add support for returning scan result in columnar layout .. Patch Set 3: (11 comments) http

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Add functionality to serialize a RowBlock

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-30 Thread Todd Lipcon (Code Review)
Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] tserver: add support for returning scan result in columnar layout

2020-03-30 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/15602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib99faa27554ec228492f096bb8760c883e44660d Gerrit-Change-Number: 15602 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
: I287a8aa6736f19816b0edbe16409c01f35c0319e Gerrit-Change-Number: 15560 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
: I287a8aa6736f19816b0edbe16409c01f35c0319e Gerrit-Change-Number: 15560 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 5: (10 comments) http

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 5: (7 comments) http://gerrit.cloudera.org

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
: I287a8aa6736f19816b0edbe16409c01f35c0319e Gerrit-Change-Number: 15560 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. rowblock: improve GetSelectedRows API The earlier commit used

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15559 ) Change subject: rowblock: improve GetSelectedRows API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15559/3/src/kudu

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Add core algorithms for columnar serialization This adds

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
: I287a8aa6736f19816b0edbe16409c01f35c0319e Gerrit-Change-Number: 15560 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
8c2 Gerrit-Change-Number: 15556 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerri

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
: 15560 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 2: (3 comments) http://gerrit.cloudera.org

<    1   2   3   4   5   6   7   8   9   10   >