On Tue, 7 May 2024 19:46:18 GMT, Pavel Rappo wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git
On Wed, 8 May 2024 05:45:55 GMT, Jaikiran Pai wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Strengthen tests after 8330998
>>
>> https://github.com/openjdk/jdk/pull/18996 now allows us to test
>> Console
On Tue, 7 May 2024 19:46:18 GMT, Pavel Rappo wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git
On Tue, 7 May 2024 19:46:18 GMT, Pavel Rappo wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git
> Can I please get a review for this patch which proposes to implement the
> enhancement request noted in https://bugs.openjdk.java.net/browse/JDK-8173970?
>
> The commit in this PR introduces the `-o` and `--output-dir` option to the
> `jar` command. The option takes a path to a destination
On Sat, 4 May 2024 18:29:25 GMT, Raffaello Giulietti
wrote:
>> Move all random generators mandated in package `java.util.random` and
>> currently implemented in module `jdk.random` to module `java.base`, and
>> remove module `jdk.random`.
>
> Raffaello Giulietti has updated the pull request
On Wed, 8 May 2024 02:56:10 GMT, Jan Kratochvil wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now
> The testcase requires root permissions.
>
> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
Jan Kratochvil has updated the pull request incrementally with one additional
commit since the last revision:
whitespace fix
-
Changes:
- all:
> The testcase requires root permissions.
>
> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 49 commits:
- centos7 compat
- 64a5feb6:
- fixes
-
On Tue, 7 May 2024 22:12:55 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/io/IO.java line 37:
>>
>>> 35: * is {@code null}; otherwise, the effect is as if a similarly-named
>>> method
>>> 36: * had been called on that console.
>>> 37: *
>>
>> Add a note here on encoding
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
This set of changes address causes of poor utilization with small numbers of
cores due to overly aggressive contention avoidance. A number of further
adjustments were needed to still avoid most contention effects in deployments
with large numbers of cores
-
Commit messages:
-
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
Marked as reviewed by jjg (Reviewer).
-
PR Review:
On Tue, 7 May 2024 21:19:59 GMT, Stuart Marks wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Strengthen tests after 8330998
>>
>> https://github.com/openjdk/jdk/pull/18996 now allows us to test
>> Console
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
Thanks for reviewing it Joe, I'm now delegating integration of this PR to
@JesperIRL, you, or anyone who
I have created some drafts of the EnumeratedStream API. But firstly, I have
noticed that we have not formalized problems we are solving with them.
Moreover, during the implementation process, I have discovered that there
are possibly a much wider range of applications for those streams. Instead
of
On Tue, 7 May 2024 19:46:18 GMT, Pavel Rappo wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git
Hi,
Could I have a review of a change that moves the jdk.FileRead and jdk.FileWrite
events to java.base to remove the use of the ASM instrumentation.
Testing: jdk/jdk/jfr
Thanks
Erik
-
Commit messages:
- Update comment
- Initial
Changes:
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Tue, 7 May 2024 02:54:39 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/io/IO.java line 41:
>>
>>> 39: */
>>> 40: @PreviewFeature(feature = PreviewFeature.Feature.IMPLICIT_CLASSES)
>>> 41: public class IO {
>>
>> Should this be final?
>
>> Should this be final?
>
> With only
On Tue, 7 May 2024 16:09:08 GMT, Pavel Rappo wrote:
>> I do not think the step to "standardise" a preview feature exists ? When a
>> preview feature becomes a released feature, the code is very lightly edited,
>> at least it this is my experience.
>>
>> You can change both readln and
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
Marked as reviewed by darcy (Reviewer).
> This PR is standalone as opposed to dependent because the #18787
On Tue, 7 May 2024 17:37:57 GMT, Pavel Rappo wrote:
> Yes, we do. There's a common misconception that `{@inheritDoc}` inherits the
> complete doc comment. In reality, `{@inheritDoc}` inherits only the main
> description, which does not include any `@throws` tags.
>
> A `@throws` tag is either
> Please review this PR which introduces the `java.io.IO` top-level class and
> three methods to `java.io.Console` for [Implicitly Declared Classes and
> Instance Main Methods (Third Preview)].
>
> This PR has been obtained as `git merge --squash` of a now obsolete [draft
> PR].
>
>
On Mon, 6 May 2024 19:06:10 GMT, Sonia Zaldana Calles
wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the
On Tue, 7 May 2024 14:58:00 GMT, Viktor Klang wrote:
> Removes SORTED if not also ORDERED for escape-hatch `Stream::spliterator()`
This pull request has now been integrated.
Changeset: f12ed061
Author:Viktor Klang
URL:
On Thu, 2 May 2024 10:30:06 GMT, Adam Sotona wrote:
>> ClassFile API `jdk.internal.classfile.verifier.VerifierImpl` performed only
>> bytecode-level class verification.
>> This patch adds `jdk.internal.classfile.verifier.ParserVerifier` with
>> additional class checks inspired by
>>
On Tue, 7 May 2024 14:58:00 GMT, Viktor Klang wrote:
> Removes SORTED if not also ORDERED for escape-hatch `Stream::spliterator()`
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19123#pullrequestreview-2043916265
On Tue, 7 May 2024 15:42:23 GMT, Maurizio Cimadamore
wrote:
> This PR fixes an issue that has crept into the FFM API implementation.
>
> From very early stages, the FFM API used to disable the alignment check on
> nested layout elements, in favor of an alignment check against the memory
>
On Tue, 7 May 2024 14:58:00 GMT, Viktor Klang wrote:
> Removes SORTED if not also ORDERED for escape-hatch `Stream::spliterator()`
Marked as reviewed by psandoz (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19123#pullrequestreview-2043897612
On Tue, 7 May 2024 14:58:00 GMT, Viktor Klang wrote:
> Removes SORTED if not also ORDERED for escape-hatch `Stream::spliterator()`
Tagging @PaulSandoz for review :)
-
PR Comment: https://git.openjdk.org/jdk/pull/19123#issuecomment-2099048586
On Tue, 7 May 2024 07:46:22 GMT, Justin Lu wrote:
>> Please review this PR which corrects an edge case bug for
>> java.text.DecimalFormat that causes incorrect parsing results for strings
>> with very large exponent values.
>>
>> When parsing values with large exponents, if the value of the
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Tue, 7 May 2024 05:41:27 GMT, Adam Sotona wrote:
>> As discussed on the mailing list
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html,
>> BufWriter::asByteBuffer has a behavior not suitable for API and is only used
>> by internal StackMapGenerator/StackCounter,
> Please review this PR which introduces the `java.io.IO` top-level class and
> three methods to `java.io.Console` for [Implicitly Declared Classes and
> Instance Main Methods (Third Preview)].
>
> This PR has been obtained as `git merge --squash` of a now obsolete [draft
> PR].
>
>
On Tue, 7 May 2024 17:30:46 GMT, Naoto Sato wrote:
> Sorry, I read it wrong. Your comment is clear so no need for rewording
Still, I think that your misreading is a symptom of a problem with my wording.
Let me try to rephrase it; let's see if you like it more.
-
PR Review
On Tue, 7 May 2024 16:24:52 GMT, Naoto Sato wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merge
On Tue, 7 May 2024 13:44:06 GMT, Emanuel Peter wrote:
> Thanks for the extra tests!
>
Thanks for reviewing.
> Can you measure how much time each test now takes on your machine?
>
Only TestRoundVectorFloatAll.java took longer, but still in one minute, others
run rather quicker than it.
> I
On Tue, 7 May 2024 17:15:43 GMT, Pavel Rappo wrote:
>> test/jdk/java/io/IO/IO.java line 99:
>>
>>> 97: System.getProperty("test.jdk") + "/bin/java",
>>> 98: "--enable-preview",
>>> 99: "-Djdk.console=gibberish",
>>
>> The test comment suggests
On Tue, 7 May 2024 13:30:12 GMT, Emanuel Peter wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix issues; modify vm options to make sure test the expected behaviors.
>
>
> HI,
> Can you have a look at this patch adding some tests for Math.round
> instrinsics?
> Thanks!
>
> ### FYI:
> During the development of RoundVF/RoundF, we faced the issues which were only
> spotted by running test exhaustively against 32/64 bits range of int/long.
> It's helpful to add
On Tue, 7 May 2024 13:36:55 GMT, Emanuel Peter wrote:
>> test/hotspot/jtreg/compiler/floatingpoint/TestRoundFloatAll.java line 31:
>>
>>> 29: * @library /test/lib /
>>> 30: * @modules java.base/jdk.internal.math
>>> 31: * @run main/othervm -XX:-TieredCompilation
>>>
On Tue, 7 May 2024 16:32:46 GMT, Naoto Sato wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merge
Update PSL to the latest upstream version.
-
Commit messages:
- the change
Changes: https://git.openjdk.org/jdk/pull/19127/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19127=00
Issue: https://bugs.openjdk.org/browse/JDK-8331864
Stats: 568 lines in 5 files changed: 408
On Tue, 7 May 2024 16:40:08 GMT, ExE Boss wrote:
>> `currentDepth` must be 0 in this case, so `rank` or `netRank` doesn't
>> matter. Overriding in `PrimitiveClassDescImpl` sounds reasonable, but then
>> perhaps default method should be removed, too, since it would look strange
>> to have the
On Tue, 7 May 2024 01:20:39 GMT, Naoto Sato wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merge
On Tue, 16 Apr 2024 13:54:53 GMT, Alan Bateman wrote:
>>> > @mlchung @AlanBateman Any thoughts on this latest version? Is this going
>>> > into the direction you had envisioned? Any more blockers? The CSR should
>>> > be up-to-date and is open for review as well. If no more blockers I'll go
On Mon, 6 May 2024 15:18:17 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 222:
>>
>>> 220: }
>>> 221: if (desc.length() == 1 && desc.charAt(0) == 'V') {
>>> 222: throw new IllegalArgumentException(String.format("not
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory
On Tue, 7 May 2024 09:44:09 GMT, serhiysachkov wrote:
>> Calendar.add() tests that describe its behavior.
>
> serhiysachkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8331646 updating to ParameterizedTests according to review
On Mon, 6 May 2024 21:45:12 GMT, Pavel Rappo wrote:
> Please review this PR which introduces the `java.io.IO` top-level class and
> three methods to `java.io.Console` for [Implicitly Declared Classes and
> Instance Main Methods (Third Preview)].
>
> This PR has been obtained as `git merge
On Tue, 7 May 2024 15:42:23 GMT, Maurizio Cimadamore
wrote:
> This PR fixes an issue that has crept into the FFM API implementation.
>
> From very early stages, the FFM API used to disable the alignment check on
> nested layout elements, in favor of an alignment check against the memory
>
On Tue, 7 May 2024 12:17:36 GMT, Rémi Forax wrote:
> I do not think the step to "standardise" a preview feature exists ? When a
> preview feature becomes a released feature, the code is very lightly edited,
> at least it this is my experience.
We may call it differently, but I think both you
This PR fixes an issue that has crept into the FFM API implementation.
>From very early stages, the FFM API used to disable the alignment check on
>nested layout elements, in favor of an alignment check against the memory
>segment base address. The rationale was that the JIT had issue with
On Tue, 7 May 2024 14:59:21 GMT, Claes Redestad wrote:
>> This PR suggests refactoring the implementation classes of
>> java.lang.constant into a new package jdk.internal.constant to enable
>> sharing some trusted static factory methods with users elsewhere in
>> java.base, such as
> As discussed on the mailing list
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html,
> BufWriter::asByteBuffer has a behavior not suitable for API and is only used
> by internal StackMapGenerator/StackCounter, so it will be converted to an
> internal API.
>
>
On Tue, 7 May 2024 10:46:41 GMT, Claes Redestad wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add a mixed scenario
>
> Nice improvement to the micro. It might be preferable to use random
> generation with a
> A peek into TypeKind during the research for #19105 reveals that TypeKind has
> a few issues:
> 1. Name mismatch for `newarraycode` and `fromNewArrayCode`: Renamed both to
> use "newarray code"
> 2. `fromDescriptor` can throw IOOBE if the input string is empty: changed to
> throw IAE and
Removes SORTED if not also ORDERED for escape-hatch `Stream::spliterator()`
-
Commit messages:
- Make sure that escape-hatch spliterator()s don't report SORTED if they
aren't also ORDERED
Changes: https://git.openjdk.org/jdk/pull/19123/files
Webrev:
> This PR suggests refactoring the implementation classes of java.lang.constant
> into a new package jdk.internal.constant to enable sharing some trusted
> static factory methods with users elsewhere in java.base, such as
> java.lang.invoke and java.lang.classfile. The refactoring also adds
On Tue, 7 May 2024 13:23:48 GMT, Emanuel Peter wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix issues; modify vm options to make sure test the expected behaviors.
>
>
On Mon, 29 Apr 2024 11:38:27 GMT, Hamlin Li wrote:
>> HI,
>> Can you have a look at this patch adding some tests for Math.round
>> instrinsics?
>> Thanks!
>>
>> ### FYI:
>> During the development of RoundVF/RoundF, we faced the issues which were
>> only spotted by running test exhaustively
On Tue, 7 May 2024 12:18:52 GMT, Rémi Forax wrote:
>> I assume it's about performance. If so, I would defer any
>> performance-related tweaks until they are necessary. Interactive reading
>> from console does not sound like something requiring that level of
>> performance tweaking.
>
> yes,
On Fri, 30 Jun 2023 14:43:36 GMT, Chen Liang wrote:
> As discussed on the mailing list
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html,
> BufWriter::asByteBuffer has a behavior not suitable for API and is only used
> by internal StackMapGenerator/StackCounter, so
On Tue, 7 May 2024 11:00:52 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 74:
>>
>>> 72:
>>> 73: @Override
>>> 74: public String readln(String prompt) {
>>
>> this code can be simplified using an early return (and the body of the
>>
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
This PR is standalone as opposed to dependent because the
https://github.com/openjdk/jdk/pull/18787
Please review this mechanical change to man pages. This PR should be integrated
after https://github.com/openjdk/jdk/pull/18787.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/19119/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19119=00
On Tue, 7 May 2024 05:52:12 GMT, Rémi Forax wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merge
On Tue, 7 May 2024 05:49:58 GMT, Rémi Forax wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merge
On Tue, 7 May 2024 01:49:27 GMT, Chen Liang wrote:
>> A peek into TypeKind during the research for #19105 reveals that TypeKind
>> has a few issues:
>> 1. Name mismatch for `newarraycode` and `fromNewArrayCode`: Renamed both to
>> use "newarray code"
>> 2. `fromDescriptor` can throw IOOBE if
On Tue, 7 May 2024 09:36:10 GMT, Jan Kratochvil wrote:
> Should JDK still support `memory.use_hierarchy == 0`?
IMO, no. Just get rid of it and assume hierarchical everywhere. We'd be walking
the hierarchy for other (lower limits), which should cover this case on those
legacy systems.
> Calendar.add() tests that describe its behavior.
serhiysachkov has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8331646 updating to ParameterizedTests according to review request
-
Changes:
- all:
On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now
On Fri, 3 May 2024 10:31:14 GMT, serhiysachkov wrote:
> Calendar.add() tests that describe its behavior.
This PR provides additional tests that clarify behavior of Calendar.add()
method for leap year, specifically behavior that led to this ticket
https://bugs.openjdk.org/browse/JDK-8327088.
> Since ~ end of March, after
> [JDK-8329131](https://bugs.openjdk.org/browse/JDK-8329131),
> tools/launcher/JliLaunchTest.java fails on AIX. Failure is :
>
> stdout: [];
> stderr: [Error: could not find libjava.so
> Error: Could not find Java SE Runtime Environment.
> ]
> exitValue = 2
>
>
On Mon, 6 May 2024 19:47:48 GMT, Axel Hauschulte wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check both parse methods
>
> test/jdk/java/text/Format/DecimalFormat/LargeExponentsTest.java line 150:
>
>> 148:
> Please review this PR which corrects an edge case bug for
> java.text.DecimalFormat that causes incorrect parsing results for strings
> with very large exponent values.
>
> When parsing values with large exponents, if the value of the exponent
> exceeds `Integer.MAX_VALUE`, the parsed value
> When JLine reads a line, there may be a prompt provided. However, JLine will
> not interpret the prompt literally, it will handle `%` specially. As a
> consequence, doing:
>
> System.console().readLine("%%s");
>
>
> will not print `%s`, as first `String.format` is used, which will convert
On Fri, 3 May 2024 15:25:05 GMT, Joachim Kern wrote:
>> Since ~ end of March, after
>> [JDK-8329131](https://bugs.openjdk.org/browse/JDK-8329131),
>> tools/launcher/JliLaunchTest.java fails on AIX. Failure is :
>>
>> stdout: [];
>> stderr: [Error: could not find libjava.so
>> Error: Could
On Mon, 6 May 2024 17:53:56 GMT, Naoto Sato wrote:
> This PR is to implement the `nonlikelyScript` feature that went into CLDR
> version 45 for migration purposes. In its release note, it states
> (https://cldr.unicode.org/index/downloads/cldr-45):
>
> Migration
> Changes to parentLocales
80 matches
Mail list logo
