Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3070#discussion_r247292846
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/iterator/AbstractDetailQueryResultIterator.java
---
@@ -94,6 +94,9
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3068
@ravipesala I remember if the local dictionary value count reach threshold,
it will go back to original valueï¼ rightï¼
Does some nodes's local dictionary reach the threshold, bug
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3068
why does one segment have some blocklet encoded with local dictionary and
some without local dictionary ?
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3065#discussion_r246997808
--- Diff: docs/presto-guide.md ---
@@ -220,7 +220,8 @@ Now you can use the Presto CLI on the coordinator to
query data sources in the c
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3066#discussion_r246995496
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/CDCBenchmark.scala
---
@@ -0,0 +1,256 @@
+/*
+ * Licensed
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3066
i think the query performance of carbon_solution is lower than
hive_solution's, because carbon_solution has more segment (insert generates a
segment and update generates more segment
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3066#discussion_r246977629
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/benchmark/CDCBenchmark.scala
---
@@ -0,0 +1,256 @@
+/*
+ * Licensed
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3064#discussion_r246975368
--- Diff: docs/dml-of-carbondata.md ---
@@ -106,6 +107,13 @@ CarbonData DML statements are documented here,which
includes:
OPTIONS
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3064#discussion_r246975324
--- Diff: docs/dml-of-carbondata.md ---
@@ -49,6 +49,7 @@ CarbonData DML statements are documented here,which
includes:
| [COMMENTCHAR
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3064#discussion_r246975024
--- Diff: docs/configuration-parameters.md ---
@@ -208,6 +208,7 @@ RESET
| carbon.options.date.format | Specifies the data
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3063#discussion_r246973842
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -1364,6 +1365,29 @@ public int
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3063#discussion_r246973727
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -1364,6 +1365,29 @@ public int
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3063#discussion_r246973311
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -947,6 +947,16 @@ public int
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3065#discussion_r246972785
--- Diff: docs/presto-guide.md ---
@@ -220,7 +220,8 @@ Now you can use the Presto CLI on the coordinator to
query data sources in the c
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3062#discussion_r246715623
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -449,9 +455,10
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3060
Is there test case to test this scene (use 'exclude filter' in presto
carbon )ï¼ if notï¼ better to add test case, so that other's changes will not
affect this feature.
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3059#discussion_r246352937
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -609,6 +609,14 @@ public static Dictionary
GitHub user qiuchenjian opened a pull request:
https://github.com/apache/carbondata/pull/3058
[CARBONDATA-3238] Solve StackOverflowError using MV datamap
ãProblemã An exception or error caused a run to abort. ï¼Using MVï¼
java.lang.StackOverflowError
Github user qiuchenjian closed the pull request at:
https://github.com/apache/carbondata/pull/3057
---
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3057
retest please
---
GitHub user qiuchenjian reopened a pull request:
https://github.com/apache/carbondata/pull/3057
[Test][CARBONDATA-3238] Solve StackOverflowError using MV datamap
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user qiuchenjian closed the pull request at:
https://github.com/apache/carbondata/pull/3057
---
GitHub user qiuchenjian opened a pull request:
https://github.com/apache/carbondata/pull/3057
[CARBONDATA-3238] Solve StackOverflowError using MV datamap
ãProblemã An exception or error caused a run to abort. ï¼Using MVï¼
java.lang.StackOverflowError
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3053#discussion_r245982727
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java
---
@@ -369,7 +367,7 @@ public BigDecimal
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3053
i think the performance of rawCompress is better than
compressLong,compressInt, can we find the root cause of JVM crashï¼
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3053#discussion_r245848950
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java
---
@@ -369,7 +367,7 @@ public BigDecimal
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3054#discussion_r245661158
--- Diff: docs/Integration/alluxio-guide.md ---
@@ -0,0 +1,44 @@
+
+
+
+# Presto guide
+This tutorial provides a quick
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245505788
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -837,9 +837,9 @@ abstract class
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245505775
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -821,10 +821,10 @@ abstract class
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245505760
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -796,10 +796,10 @@ abstract class
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245505699
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -697,9 +697,9 @@ abstract class
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245505691
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -668,9 +668,9 @@ abstract class
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3052
add to whitelist
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3050#discussion_r245244853
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapFactory.java
---
@@ -57,7 +57,7 @@ public
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3047#discussion_r244895354
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
---
@@ -101,14 +102,21 @@ object CarbonStore
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3046#discussion_r244708339
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
@@ -205,8 +205,10 @@ public
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r244706639
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3044#discussion_r244677596
--- Diff: docs/ddl-of-carbondata.md ---
@@ -681,24 +682,28 @@ Users can specify which columns to include and
exclude for local dictionary gene
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3044#discussion_r244676690
--- Diff: docs/ddl-of-carbondata.md ---
@@ -681,24 +682,28 @@ Users can specify which columns to include and
exclude for local dictionary gene
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3041#discussion_r244655257
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java
---
@@ -234,30 +219,26 @@ public TBase create
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3039#discussion_r244654748
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/expression/conditional/ImplicitExpression.java
---
@@ -0,0 +1,109
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3039#discussion_r244654723
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/expression/conditional/ImplicitExpression.java
---
@@ -0,0 +1,109
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3036
@xubo245 OK, i'll try
---
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3036
@xuchuanyin @xubo245 @QiangCai @jackylk Can we enable checkstyle rule
of avoiding unused importsï¼i think it's necessary to keep good code style and
reduce the dependency of a class
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3033#discussion_r21456
--- Diff: docs/datamap-developer-guide.md ---
@@ -3,15 +3,15 @@
### Introduction
DataMap is a data structure that can be used
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244295612
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -117,4 +116,18 @@ object CarbonSparkUtil
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244291200
--- Diff: README.md ---
@@ -84,3 +85,6 @@ To get involved in CarbonData:
## About
Apache CarbonData is an open source project
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3032
Please describe the change of this PR
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3031#discussion_r244269580
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
---
@@ -140,6 +140,7 @@ public boolean
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3029
Need it add a param to control whether to sort when no_sort?
Maybe user only want to merge small segments to a big segment, slow data
merging may be unaccepted
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244252283
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java
---
@@ -105,10 +107,10 @@ public
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3028#discussion_r244142318
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java
---
@@ -197,6 +197,10 @@ public static
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3026#discussion_r244137998
--- Diff:
integration/spark-datasource/src/main/spark2.1andspark2.2/org/apache/spark/sql/CarbonDictionaryReflectionUtil.java
---
@@ -0,0 +1,118
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3026
@ravipesala sorry,i didn't notice it, now i know the purpose
---
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3025
> @qiuchenjian currently pre-aggregate datamap is not following the datamap
interfaces as it was implemented before datamap framework. That is why not all
datamap DDL works with
Github user qiuchenjian closed the pull request at:
https://github.com/apache/carbondata/pull/3025
---
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3026
Does carbon not support Cdh using -Pspark-2.2 ?
Does CDH change the spark interface ,so that carbon can't run succesfully ?
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2970#discussion_r244065663
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonThreadFactory.java ---
@@ -34,14 +34,26 @@
*/
private String name
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2970#discussion_r244013967
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
---
@@ -144,14 +144,14 @@ private
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2970#discussion_r244013978
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
---
@@ -144,14 +144,14 @@ private
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2970#discussion_r244013962
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonThreadFactory.java ---
@@ -34,14 +34,26 @@
*/
private String name
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3025
retest this please
---
GitHub user qiuchenjian opened a pull request:
https://github.com/apache/carbondata/pull/3025
[CARBONDATA-3199]"show datamap" represents preaggregate datamap
[Problem] "show datamap" command doesn't represents preaggregate datamap,
it only represents
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r243927801
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala
---
@@ -24,59 +24,88 @@ import
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r243904016
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala
---
@@ -24,59 +24,88 @@ import
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r243901940
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala
---
@@ -24,59 +24,88 @@ import
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r243902213
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala
---
@@ -24,59 +24,88 @@ import
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3019#discussion_r243822523
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
---
@@ -113,7 +132,7 @@ private
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3019#discussion_r243821704
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
---
@@ -43,63 +44,81
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3021
Does carbon not support Cdh5.14.2 spark2.2.0 using -Pspark-2.2 ?
Did CDH change the spark interface ,so that carbon can't run succesfully ?
---
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3020
I think you need describe this validation in the ddl-of-carbondata.md of
Inverted Index Configuration part
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3017#discussion_r243780410
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
@@ -112,7 +112,7 @@ public LocalFileLock(String
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3010
Can you show up the error message when load and query failing
---
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3008
i think your branch of carbonfile is confused
---
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3007
Please add describe to the title like other PRS
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3006#discussion_r243177823
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
---
@@ -182,7 +182,7 @@ object
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3000#discussion_r243132507
--- Diff:
datamap/bloom/src/main/java/org/apache/hadoop/util/bloom/CarbonBloomFilter.java
---
@@ -49,27 +49,23 @@ public CarbonBloomFilter(int
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3000#discussion_r242851840
--- Diff:
datamap/bloom/src/main/java/org/apache/hadoop/util/bloom/CarbonBloomFilter.java
---
@@ -49,27 +49,23 @@ public CarbonBloomFilter(int
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2996#discussion_r242847958
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala
---
@@ -165,15
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2993#discussion_r242436603
--- Diff:
streaming/src/main/scala/org/apache/carbondata/streaming/parser/FieldConverter.scala
---
@@ -66,30 +65,57 @@ object FieldConverter
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2993#discussion_r242435030
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateDDLForComplexMapType.scala
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2713#discussion_r242430992
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -218,56 +218,46 @@ public
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2713#discussion_r242393730
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
---
@@ -178,15 +178,9 @@ private String
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2713#discussion_r242387613
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -218,56 +218,46 @@ public
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2990#discussion_r242010744
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2990#discussion_r242010398
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2990#discussion_r242007987
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2984#discussion_r241950006
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
---
@@ -227,6 +231,12 @@ private String
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2990#discussion_r241935317
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -286,12 +286,16 @@ class
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2990#discussion_r241935024
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -1464,31 +1464,46 @@ abstract
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2988#discussion_r241934868
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2987#discussion_r241619136
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/DataFrameSDKS3Example.scala
---
@@ -0,0 +1,184 @@
+/*
+ * Licensed
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2987#discussion_r241619313
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/DataFrameSDKS3Example.scala
---
@@ -0,0 +1,184 @@
+/*
+ * Licensed
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2984#discussion_r241617708
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
---
@@ -227,6 +231,12 @@ private String
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2984#discussion_r241298414
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
---
@@ -227,6 +231,12 @@ private String
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2985#discussion_r241285610
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/BlockletScannedResult.java
---
@@ -663,6 +663,12 @@ public boolean hasNext
GitHub user qiuchenjian opened a pull request:
https://github.com/apache/carbondata/pull/2984
[CARBONDATA-3165]Protection of Bloom Null Exception
Problemï¼
24274.0 (TID 664711) |
org.apache.spark.internal.Logging$class.logError(Logging.scala:91
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2963#discussion_r240581131
--- Diff:
datamap/example/src/main/java/org/apache/carbondata/datamap/minmax/AbstractMinMaxDataMapWriter.java
---
@@ -0,0 +1,248
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2970#discussion_r240447425
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonThreadFactory.java ---
@@ -34,14 +34,26 @@
*/
private String name
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/2970
> @qiuchenjian the checklist should be select correctly, you can refer
#2981 or other PR
done
---
1 - 100 of 143 matches
Mail list logo
