[jira] [Commented] (FLINK-6505) Proactively cleanup local FS for RocksDBKeyedStateBackend on startup

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247141#comment-16247141 ] ASF GitHub Bot commented on FLINK-6505: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-11-09 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4798 Hi @StefanRRichter , do you have more feedbacks? ---

[jira] [Commented] (FLINK-7928) Extend the filed in ResourceProfile for precisely calculating the resource of a task manager

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247047#comment-16247047 ] ASF GitHub Bot commented on FLINK-7928: --- GitHub user shuai-xu opened a pull request:

[GitHub] flink pull request #4991: [FLINK-7928] [runtime] extend the resources in Res...

2017-11-09 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/4991 [FLINK-7928] [runtime] extend the resources in ResourceProfile for precisely calculating the resource of task manager Notes: this pull request contains the #4911 since it depends on it.

[jira] [Commented] (FLINK-3985) A metric with the name * was already registered

2017-11-09 Thread Su Ralph (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246937#comment-16246937 ] Su Ralph commented on FLINK-3985: - Sorry i'm not runnign tests, it's formal deployments. > A metric with

[jira] [Commented] (FLINK-3985) A metric with the name * was already registered

2017-11-09 Thread Su Ralph (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246935#comment-16246935 ] Su Ralph commented on FLINK-3985: - i can still see this in 1.2.0. It's marked as fixed but without fix

[jira] [Updated] (FLINK-8020) Deadlock found in Flink Streaming job

2017-11-09 Thread Weihua Jiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Jiang updated FLINK-8020: Attachment: jstack53009(2).out Attach a new jstack file. After removing our collector.collect()

[jira] [Created] (FLINK-8043) increment job restart metric when fine grained recovery reverted to full job restart

2017-11-09 Thread Steven Zhen Wu (JIRA)
Steven Zhen Wu created FLINK-8043: - Summary: increment job restart metric when fine grained recovery reverted to full job restart Key: FLINK-8043 URL: https://issues.apache.org/jira/browse/FLINK-8043

[jira] [Created] (FLINK-8042) retry individual failover-strategy for some time first before reverting to full job restart

2017-11-09 Thread Steven Zhen Wu (JIRA)
Steven Zhen Wu created FLINK-8042: - Summary: retry individual failover-strategy for some time first before reverting to full job restart Key: FLINK-8042 URL: https://issues.apache.org/jira/browse/FLINK-8042

[jira] [Resolved] (FLINK-8036) Consider using gradle to build Flink

2017-11-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved FLINK-8036. --- Resolution: Later Resolving since there is not enough interest. > Consider using gradle to build Flink >

[jira] [Commented] (FLINK-8036) Consider using gradle to build Flink

2017-11-09 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246715#comment-16246715 ] Chesnay Schepler commented on FLINK-8036: - I can see the benefit, but as it stands I'm against it.

[jira] [Updated] (FLINK-8041) Recommended Improvements for Gelly's Connected Components Algorithm

2017-11-09 Thread Christos Hadjinikolis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Hadjinikolis updated FLINK-8041: - Description: At the moment, the ConnectedComponents algorithm that comes with

[jira] [Created] (FLINK-8041) Recommended Improvements for Gelly's Connected Components Algorithm

2017-11-09 Thread Christos Hadjinikolis (JIRA)
Christos Hadjinikolis created FLINK-8041: Summary: Recommended Improvements for Gelly's Connected Components Algorithm Key: FLINK-8041 URL: https://issues.apache.org/jira/browse/FLINK-8041

[jira] [Commented] (FLINK-7919) Join with Solution Set fails with NPE if Solution Set has no entry

2017-11-09 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246487#comment-16246487 ] Greg Hogan commented on FLINK-7919: --- [~fhueske] would an alternative be to use inner join semantics

[jira] [Commented] (FLINK-8014) Add Kafka010JsonTableSink

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246472#comment-16246472 ] ASF GitHub Bot commented on FLINK-8014: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request #4990: [FLINK-8014] [FLINK-8016] Add Kafka010JsonTableSin...

2017-11-09 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/4990 [FLINK-8014] [FLINK-8016] Add Kafka010JsonTableSink and documentation ## What is the purpose of the change - Adds a TableSink to write JSON-encoded rows to Kafka 0.10 topics - Adds

[jira] [Commented] (FLINK-7977) bump version of compatibility check for Flink 1.4

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246436#comment-16246436 ] ASF GitHub Bot commented on FLINK-7977: --- Github user zentol commented on the issue:

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-09 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4945 @greghogan That's a great point. ---

[jira] [Commented] (FLINK-2973) Add flink-benchmark with compliant licenses again

2017-11-09 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246432#comment-16246432 ] Greg Hogan commented on FLINK-2973: --- [~fhueske] it looks to be GPLv2 (with classpath exception):

[GitHub] flink pull request #4976: [FLINK-8017] Fix High availability cluster-id key ...

2017-11-09 Thread dkelley-accretive
Github user dkelley-accretive closed the pull request at: https://github.com/apache/flink/pull/4976 ---

[jira] [Commented] (FLINK-8017) High availability cluster-id option incorrect in documentation

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246245#comment-16246245 ] ASF GitHub Bot commented on FLINK-8017: --- Github user dkelley-accretive closed the pull request at:

[jira] [Commented] (FLINK-8020) Deadlock found in Flink Streaming job

2017-11-09 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246081#comment-16246081 ] Kostas Kloudas commented on FLINK-8020: --- [~greghogan] I suppose you can close it and [~whjiang] can

[GitHub] flink pull request #4943: [FLINK-6022] [avro] Use Avro to serialize Avro in ...

2017-11-09 Thread StephanEwen
Github user StephanEwen closed the pull request at: https://github.com/apache/flink/pull/4943 ---

[jira] [Commented] (FLINK-6022) Don't serialise Schema when serialising Avro GenericRecord

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246015#comment-16246015 ] ASF GitHub Bot commented on FLINK-6022: --- Github user StephanEwen closed the pull request at:

[jira] [Commented] (FLINK-7419) Shade jackson dependency in flink-avro

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246007#comment-16246007 ] ASF GitHub Bot commented on FLINK-7419: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #4981: [FLINK-7419][build][avro] Relocate jackson in flin...

2017-11-09 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4981#discussion_r150020494 --- Diff: flink-formats/flink-avro/pom.xml --- @@ -185,17 +185,6 @@ under the License.

[jira] [Commented] (FLINK-8011) Set dist flink-python dependency to provided

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245997#comment-16245997 ] ASF GitHub Bot commented on FLINK-8011: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4973: [FLINK-8011][dist] Set flink-python to provided

2017-11-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4973 Yes, that is how it should be. +1 ---

[jira] [Commented] (FLINK-8006) flink-daemon.sh: line 103: binary operator expected

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245993#comment-16245993 ] ASF GitHub Bot commented on FLINK-8006: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4968: [FLINK-8006] [Startup Shell Scripts] Enclosing $pid in qu...

2017-11-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4968 LGTM +1 to merge ---

[jira] [Commented] (FLINK-7886) Enable dependency convergence for flink-core

2017-11-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245925#comment-16245925 ] Aljoscha Krettek commented on FLINK-7886: - Implemented on release-1.4 in

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245879#comment-16245879 ] ASF GitHub Bot commented on FLINK-8005: --- Github user kl0u commented on the issue:

[GitHub] flink issue #4980: [FLINK-8005] [runtime] Set user code class loader before ...

2017-11-09 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4980 I agree! +1 to merge as soon as Travis gives us the green light. ---

[GitHub] flink issue #4980: [FLINK-8005] [runtime] Set user code class loader before ...

2017-11-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4980 thanks, I think this is excellent now. 👌 I'll merge as soon as travis is green. ---

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245867#comment-16245867 ] ASF GitHub Bot commented on FLINK-8005: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4777: [FLINK-7765] Enable dependency convergence

2017-11-09 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4777 Thanks! ---

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245825#comment-16245825 ] ASF GitHub Bot commented on FLINK-8005: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149993559 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -277,8 +287,12 @@ public void invoke() throws

[jira] [Commented] (FLINK-7765) Enable dependency convergence

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245808#comment-16245808 ] ASF GitHub Bot commented on FLINK-7765: --- Github user pnowojski commented on the issue:

[jira] [Commented] (FLINK-7765) Enable dependency convergence

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245810#comment-16245810 ] ASF GitHub Bot commented on FLINK-7765: --- Github user pnowojski closed the pull request at:

[GitHub] flink pull request #4777: [FLINK-7765] Enable dependency convergence

2017-11-09 Thread pnowojski
Github user pnowojski closed the pull request at: https://github.com/apache/flink/pull/4777 ---

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245781#comment-16245781 ] ASF GitHub Bot commented on FLINK-8005: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-4228) YARN artifact upload does not work with S3AFileSystem

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245767#comment-16245767 ] ASF GitHub Bot commented on FLINK-4228: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4939: [FLINK-4228][yarn/s3a] fix yarn resource upload s3...

2017-11-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4939#discussion_r149980302 --- Diff: flink-yarn/pom.xml --- @@ -153,6 +159,63 @@ under the License.

[jira] [Assigned] (FLINK-8040) Test instability ResourceGuard#testCloseBlockIfAcquired

2017-11-09 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8040: --- Assignee: Stefan Richter > Test instability ResourceGuard#testCloseBlockIfAcquired >

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149985097 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -277,8 +287,12 @@ public void invoke() throws

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245776#comment-16245776 ] ASF GitHub Bot commented on FLINK-8005: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149984491 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -277,8 +287,12 @@ public void invoke() throws

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245773#comment-16245773 ] ASF GitHub Bot commented on FLINK-8005: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149983878 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -277,8 +287,12 @@ public void invoke() throws

[jira] [Commented] (FLINK-4228) YARN artifact upload does not work with S3AFileSystem

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245769#comment-16245769 ] ASF GitHub Bot commented on FLINK-4228: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-4228) YARN artifact upload does not work with S3AFileSystem

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245768#comment-16245768 ] ASF GitHub Bot commented on FLINK-4228: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4939: [FLINK-4228][yarn/s3a] fix yarn resource upload s3...

2017-11-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4939#discussion_r149983029 --- Diff: flink-yarn/pom.xml --- @@ -153,6 +159,63 @@ under the License.

[GitHub] flink pull request #4939: [FLINK-4228][yarn/s3a] fix yarn resource upload s3...

2017-11-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4939#discussion_r149983025 --- Diff: flink-yarn/pom.xml --- @@ -153,6 +159,63 @@ under the License.

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245765#comment-16245765 ] ASF GitHub Bot commented on FLINK-8005: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149982812 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -277,8 +287,12 @@ public void invoke() throws

[jira] [Commented] (FLINK-7765) Enable dependency convergence

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245753#comment-16245753 ] ASF GitHub Bot commented on FLINK-7765: --- Github user aljoscha commented on the issue:

[jira] [Closed] (FLINK-7886) Enable dependency convergence for flink-core

2017-11-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-7886. --- Resolution: Fixed Implemented on master in bdbca37b01254aef9ddd6943d34dab1838c2a9f1 > Enable

[GitHub] flink issue #4777: [FLINK-7765] Enable dependency convergence

2017-11-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4777 Thanks! Could you please close if GH doesn't auto-close? ---

[GitHub] flink issue #4989: [Flink 7003] [Table API & SQL] use PEEK_FIELDS_NO_EXPAND ...

2017-11-09 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4989 Thanks for the PR @suez1224. I will merge it. Thanks, Fabian ---

[jira] [Commented] (FLINK-8006) flink-daemon.sh: line 103: binary operator expected

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245714#comment-16245714 ] ASF GitHub Bot commented on FLINK-8006: --- Github user greghogan commented on the issue:

[GitHub] flink issue #4968: [FLINK-8006] [Startup Shell Scripts] Enclosing $pid in qu...

2017-11-09 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4968 +1 ---

[jira] [Commented] (FLINK-7679) Upgrade maven enforcer plugin to 3.0.0-M1

2017-11-09 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245711#comment-16245711 ] Greg Hogan commented on FLINK-7679: --- So it looks like Scala 2.12+ is required for Java 9. > Upgrade

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245681#comment-16245681 ] ASF GitHub Bot commented on FLINK-8005: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4980: [FLINK-8005] [runtime] Set user code class loader before ...

2017-11-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4980 Yes, but I think this is making an assumption about the internal implementation. If someone changes that the test could break/not test the right thing anymore. ---

[jira] [Updated] (FLINK-8040) Test instability ResourceGuard#testCloseBlockIfAcquired

2017-11-09 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8040: Description: Test {{ResourceGuard#testCloseBlockIfAcquired()}} fails sporadically with {noformat}

[jira] [Updated] (FLINK-8040) Test instability ResourceGuard#testCloseBlockIfAcquired

2017-11-09 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8040: Description: Test {{ResourceGuard#testCloseBlockIfAcquired()}} fails sporadically with {noformat}

[jira] [Updated] (FLINK-8040) Test instability ResourceGuard#testCloseBlockIfAcquired

2017-11-09 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8040: Description: Test {{ResourceGuard#testCloseBlockIfAcquired()}} fails sporadically with {noformat}

[jira] [Created] (FLINK-8040) Test instability ResourceGuard#testCloseBlockIfAcquired

2017-11-09 Thread Gary Yao (JIRA)
Gary Yao created FLINK-8040: --- Summary: Test instability ResourceGuard#testCloseBlockIfAcquired Key: FLINK-8040 URL: https://issues.apache.org/jira/browse/FLINK-8040 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-8040) Test instability ResourceGuard#testCloseBlockIfAcquired

2017-11-09 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8040: Description: Test {{ResourceGuard#testCloseBlockIfAcquired()}} fails sporadically with {noformat}

[jira] [Commented] (FLINK-7765) Enable dependency convergence

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245638#comment-16245638 ] ASF GitHub Bot commented on FLINK-7765: --- Github user pnowojski commented on the issue:

[jira] [Commented] (FLINK-6022) Don't serialise Schema when serialising Avro GenericRecord

2017-11-09 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245640#comment-16245640 ] Robert Metzger commented on FLINK-6022: --- This whole JIRA is only about the case when people are

[GitHub] flink issue #4777: [FLINK-7765] Enable dependency convergence

2017-11-09 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4777 https://issues.apache.org/jira/browse/FLINK-7765 - this is a parent issue enclosing fixing other modules. Split between other subtasks is very, very arbitrary, but I guess next milestone would be

[jira] [Commented] (FLINK-7765) Enable dependency convergence

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245631#comment-16245631 ] ASF GitHub Bot commented on FLINK-7765: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245630#comment-16245630 ] ASF GitHub Bot commented on FLINK-8005: --- Github user GJL commented on the issue:

[GitHub] flink issue #4980: [FLINK-8005] [runtime] Set user code class loader before ...

2017-11-09 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4980 There is only one thread dispatching the calls: ``` executor = Executors.newSingleThreadExecutor( new DispatcherThreadFactory(TASK_THREADS_GROUP,

[GitHub] flink issue #4777: [FLINK-7765] Enable dependency convergence

2017-11-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4777 I'll merge, yes, what are the follow-up issues you created? ---

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245623#comment-16245623 ] ASF GitHub Bot commented on FLINK-8005: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4980: [FLINK-8005] [runtime] Set user code class loader before ...

2017-11-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4980 I think waiting on the stop latch might not be enough (in 100 % of cases) because the other two calls are also asynchronous. ---

[jira] [Commented] (FLINK-8017) High availability cluster-id option incorrect in documentation

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245603#comment-16245603 ] ASF GitHub Bot commented on FLINK-8017: --- Github user aljoscha commented on the issue:

[jira] [Closed] (FLINK-8017) High availability cluster-id option incorrect in documentation

2017-11-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-8017. --- Resolution: Fixed Fixed on release-1.4 in 02a19a14fad1ef928038f4971bdcacf4d0642d88 Fixed on

[GitHub] flink issue #4976: [FLINK-8017] Fix High availability cluster-id key in docu...

2017-11-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4976 Could you please close this if it doesn't auto-close? ---

[jira] [Updated] (FLINK-8017) High availability cluster-id option incorrect in documentation

2017-11-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-8017: Fix Version/s: 1.4.0 > High availability cluster-id option incorrect in documentation >

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245600#comment-16245600 ] ASF GitHub Bot commented on FLINK-8005: --- Github user GJL commented on the issue:

[GitHub] flink issue #4980: [FLINK-8005] [runtime] Set user code class loader before ...

2017-11-09 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4980 I addressed the comments. Let's wait for Travis and let me know if something else needs to be changed. @aljoscha @kl0u ---

[jira] [Commented] (FLINK-8017) High availability cluster-id option incorrect in documentation

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245599#comment-16245599 ] ASF GitHub Bot commented on FLINK-8017: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4976: [FLINK-8017] Fix High availability cluster-id key in docu...

2017-11-09 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4976 Thanks for spotting and fixing this! 👍 I'm merging. ---

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245597#comment-16245597 ] ASF GitHub Bot commented on FLINK-8005: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149955008 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -254,12 +300,10 @@ else if (this.error == null) {

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245596#comment-16245596 ] ASF GitHub Bot commented on FLINK-8005: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245592#comment-16245592 ] ASF GitHub Bot commented on FLINK-8005: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8005) Snapshotting FlinkKafkaProducer011 fails due to ClassLoader issues

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245593#comment-16245593 ] ASF GitHub Bot commented on FLINK-8005: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149954849 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -254,12 +300,10 @@ else if (this.error == null) {

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149954606 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/DispatcherThreadFactory.java --- @@ -29,21 +31,41 @@ private final

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149954576 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -58,99 +59,144 @@ import org.junit.Before;

[jira] [Assigned] (FLINK-8021) End-to-end tests may not shutdown cluster on failure

2017-11-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-8021: --- Assignee: Aljoscha Krettek > End-to-end tests may not shutdown cluster on failure >

[jira] [Commented] (FLINK-7765) Enable dependency convergence

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245581#comment-16245581 ] ASF GitHub Bot commented on FLINK-7765: --- Github user pnowojski commented on the issue:

[GitHub] flink issue #4777: [FLINK-7765] Enable dependency convergence

2017-11-09 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4777 All is green, could we merge this? This PR has a quite large silent conflict chance during rebasing :( (whenever someone changes any dependency on master) ---

[jira] [Comment Edited] (FLINK-6022) Don't serialise Schema when serialising Avro GenericRecord

2017-11-09 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245577#comment-16245577 ] Stephan Ewen edited comment on FLINK-6022 at 11/9/17 12:48 PM: --- We are not

[jira] [Commented] (FLINK-6022) Don't serialise Schema when serialising Avro GenericRecord

2017-11-09 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245577#comment-16245577 ] Stephan Ewen commented on FLINK-6022: - We are not serializing the schema in the Avro Serializer. If

  1   2   >