[GitHub] [kafka] PrasanthV454 opened a new pull request, #13922: [MINOR] remove the currentStream.close() statement causing exit code issue

PrasanthV454 opened a new pull request, #13922: URL: https://github.com/apache/kafka/pull/13922 currentStream shouldn't be closed as it is std err or std out. Only tempStream should be closed. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] github-actions[bot] commented on pull request #13376: KAFKA-14091: Leader proactively aborting tasks from lost workers in rebalance in EOS mode

github-actions[bot] commented on PR #13376: URL: https://github.com/apache/kafka/pull/13376#issuecomment-1610635915 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[GitHub] [kafka] github-actions[bot] commented on pull request #13478: KAFKA-14870: Fix KerberosLogin#relogin to invoke super#login when cre…

github-actions[bot] commented on PR #13478: URL: https://github.com/apache/kafka/pull/13478#issuecomment-1610635895 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[GitHub] [kafka] flashmouse commented on pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

flashmouse commented on PR #13920: URL: https://github.com/apache/kafka/pull/13920#issuecomment-1610578143 @kirktrue thank you for reply! In your case, although ``isBalanced`` return false, ``performReassignments`` still won't reassign any partition, because it would only do

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244508147 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -423,6 +456,47 @@ public Map computeSubscriptionMetadata(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244508147 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -423,6 +456,47 @@ public Map computeSubscriptionMetadata(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244507539 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -423,6 +456,47 @@ public Map computeSubscriptionMetadata(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244506236 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -119,6 +131,18 @@ public String toString() { */

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244500812 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244497307 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244497307 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244497307 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244496874 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244495117 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] lihaosky commented on a diff in pull request #13851: KAFKA-15022: [1/N] initial implementation of rack aware assignor

lihaosky commented on code in PR #13851: URL: https://github.com/apache/kafka/pull/13851#discussion_r1244450143 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -409,6 +411,43 @@ private String getBrokerSideConfigValue(final

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244495117 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244492766 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244485648 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -727,6 +800,80 @@ public void replay( + "

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244485648 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -727,6 +800,80 @@ public void replay( + "

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244482511 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -709,14 +780,16 @@ public void replay( String groupId =

[GitHub] [kafka] C0urante commented on a diff in pull request #13446: KAFKA-14837, KAFKA-14842: Ignore groups that do not have offsets for filtered topics in MirrorCheckpointConnector

C0urante commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1244478202 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -150,10 +156,31 @@ private void loadInitialConsumerGroups()

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244477507 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -88,10 +93,12 @@ public class GroupMetadataManager { public

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244475836 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -506,32 +555,54 @@ private CoordinatorResult consumerGr

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1244469064 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -179,26 +209,45 @@ GroupMetadataManager build() { private

[GitHub] [kafka] jolshan commented on pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on PR #13880: URL: https://github.com/apache/kafka/pull/13880#issuecomment-1610300192 Looks pretty good. I think if we want to do this as part the the PR, there's just this left: https://github.com/apache/kafka/pull/13880/files#r1244223827 -- This is an automated

[GitHub] [kafka] jolshan commented on pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on PR #13798: URL: https://github.com/apache/kafka/pull/13798#issuecomment-1610267331 I ran some tests with producer-perf. I didn't see noticeable differences, but the tests were not particularly long. I can run more if needed. The `--transaction-duration` argument tells

[GitHub] [kafka] blacktooth commented on a diff in pull request #13446: KAFKA-14837, KAFKA-14842: Ignore groups that do not have offsets for filtered topics in MirrorCheckpointConnector

blacktooth commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1244382978 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -150,10 +156,31 @@ private void loadInitialConsumerGroups()

[jira] [Updated] (KAFKA-15028) AddPartitionsToTxnManager metrics

[ https://issues.apache.org/jira/browse/KAFKA-15028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15028: - Attachment: latency-cpu.html > AddPartitionsToTxnManager metrics >

[GitHub] [kafka] jolshan commented on pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on PR #13798: URL: https://github.com/apache/kafka/pull/13798#issuecomment-1610196155 Thanks for sharing this flame graph. I see that the histogram takes up the majority of the processCompletedSends, but compared to the total cpu usage, it's about 1%. I still think it is

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1244331034 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -17,25 +17,37 @@ package kafka.server +import

[GitHub] [kafka] xiaocairush commented on a diff in pull request #13884: MINOR: fix typos for client

xiaocairush commented on code in PR #13884: URL: https://github.com/apache/kafka/pull/13884#discussion_r1244247840 ## clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java: ## @@ -854,7 +854,7 @@ public void shouldThrowOnInvalidDateFormatOrNullTimestamp() {

[jira] [Updated] (KAFKA-14945) Add Serializer#serializeToByteBuffer() to reduce memory copying

[ https://issues.apache.org/jira/browse/KAFKA-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14945: - Labels: kip (was: ) > Add Serializer#serializeToByteBuffer() to reduce memory copying >

[jira] [Updated] (KAFKA-14945) Add Serializer#serializeToByteBuffer() to reduce memory copying

[ https://issues.apache.org/jira/browse/KAFKA-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14945: - Fix Version/s: 3.6.0 > Add Serializer#serializeToByteBuffer() to reduce memory copying >

[GitHub] [kafka] divijvaidya commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage

divijvaidya commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1610089621 Hey @Vaibhav-Nazare A KIP needs at least 3 committer votes and I believe we haven't heard from other folks in the community on the KIP. I am waiting for others to chime in.

[GitHub] [kafka] machi1990 commented on pull request #13903: MINOR: Bump requests from 2.24.0 to 2.31.0 in /tests

machi1990 commented on PR #13903: URL: https://github.com/apache/kafka/pull/13903#issuecomment-1610089280 Thank you @divijvaidya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dependabot[bot] commented on pull request #13743: Bump requests from 2.24.0 to 2.31.0 in /tests

dependabot[bot] commented on PR #13743: URL: https://github.com/apache/kafka/pull/13743#issuecomment-1610085437 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [kafka] divijvaidya closed pull request #13743: Bump requests from 2.24.0 to 2.31.0 in /tests

divijvaidya closed pull request #13743: Bump requests from 2.24.0 to 2.31.0 in /tests URL: https://github.com/apache/kafka/pull/13743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] divijvaidya merged pull request #13903: MINOR: Bump requests from 2.24.0 to 2.31.0 in /tests

divijvaidya merged PR #13903: URL: https://github.com/apache/kafka/pull/13903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1244223827 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

vcrfxia commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1239143225 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinTest.java: ## @@ -112,6 +125,74 @@ private void pushNullValueToTable() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1244173231 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] divijvaidya commented on pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

divijvaidya commented on PR #13798: URL: https://github.com/apache/kafka/pull/13798#issuecomment-1609922486 > if this does affect performance too much Maybe we could use some type of recoding level for Yammer metrics too? We already have a configuration at:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

divijvaidya commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1244076297 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[jira] [Commented] (KAFKA-15128) snappy-java-1.1.8.4.jar library vulnerability

[ https://issues.apache.org/jira/browse/KAFKA-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737791#comment-17737791 ] Arushi Rai commented on KAFKA-15128: Hi [~ckamal]  If possible, can you share the expected release

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1244065077 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record.

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1244064321 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record.

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1244063578 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on pull request #13921: MINOR: Reduce (hopefully) flakiness of testRackAwareRangeAssignor

dajac commented on PR #13921: URL: https://github.com/apache/kafka/pull/13921#issuecomment-1609889975 The test still fails. There is likely something else going on... I will keep investigating. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] jolshan commented on pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on PR #13798: URL: https://github.com/apache/kafka/pull/13798#issuecomment-1609874663 > Although one histogram calculation here should be ok, but it would be nice if you get some producer-perf.sh data in as well to ensure that this metric isn't adversely impacting

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1244044199 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -17,25 +17,37 @@ package kafka.server +import

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1244035570 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1244034254 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[jira] [Updated] (KAFKA-15086) The unreasonable segment size setting of the internal topics in MM2 may cause the worker startup time to be too long

[ https://issues.apache.org/jira/browse/KAFKA-15086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi updated KAFKA-15086: --- Labels: kip-943 (was: ) > The unreasonable segment size setting of the internal topics in MM2 may cause >

[GitHub] [kafka] mumrah merged pull request #13910: KAFKA-15109 Ensure the leader epoch bump occurs for older MetadataVersions

mumrah merged PR #13910: URL: https://github.com/apache/kafka/pull/13910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14972) Make KafkaConsumer usable in async runtimes

[ https://issues.apache.org/jira/browse/KAFKA-14972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737711#comment-17737711 ] Erik van Oosten commented on KAFKA-14972: - I will complete the KIP tomorrow. > Make

[jira] [Commented] (KAFKA-7143) Cannot use KafkaConsumer with Kotlin coroutines due to various issues

[ https://issues.apache.org/jira/browse/KAFKA-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737709#comment-17737709 ] Kirk True commented on KAFKA-7143: -- cc [~pnee] [~lianetm]  > Cannot use KafkaConsumer with Kotlin

[jira] [Commented] (KAFKA-14972) Make KafkaConsumer usable in async runtimes

[ https://issues.apache.org/jira/browse/KAFKA-14972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737710#comment-17737710 ] Kirk True commented on KAFKA-14972: --- cc [~pnee] [~lianetm]  > Make KafkaConsumer usable in async

[jira] [Updated] (KAFKA-14972) Make KafkaConsumer usable in async runtimes

[ https://issues.apache.org/jira/browse/KAFKA-14972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14972: -- Labels: needs-kip (was: ) > Make KafkaConsumer usable in async runtimes >

[GitHub] [kafka] jsancio commented on a diff in pull request #13910: KAFKA-15109 Ensure the leader epoch bump occurs for older MetadataVersions

jsancio commented on code in PR #13910: URL: https://github.com/apache/kafka/pull/13910#discussion_r1243870229 ## metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java: ## @@ -207,7 +211,7 @@ public void testTriggerLeaderEpochBumpIfNeeded() {

[GitHub] [kafka] kirktrue commented on pull request #13917: MINOR; Failed move should be logged at WARN

kirktrue commented on PR #13917: URL: https://github.com/apache/kafka/pull/13917#issuecomment-1609649429 @jsancio Another difference is that now the `outer` exception's stack trace will be shown via `WARN` instead of just the exception's message via `DEBUG`. I assume that's intentional,

[GitHub] [kafka] drawxy commented on a diff in pull request #13847: KAFKA-15082: The log retention policy doesn't take effect after altering log dir

drawxy commented on code in PR #13847: URL: https://github.com/apache/kafka/pull/13847#discussion_r1243863992 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1808,7 +1809,10 @@ class ReplicaManager(val config: KafkaConfig, // pause cleaning for

[GitHub] [kafka] kirktrue commented on pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

kirktrue commented on PR #13920: URL: https://github.com/apache/kafka/pull/13920#issuecomment-1609641313 @flashmouse I'm a little slow on the uptake, so I'm trying to come up with a scenario. Let's say the following is true: * Topic `foo` has three partitions * The consumer group

[jira] [Commented] (KAFKA-15105) Flaky test FetchFromFollowerIntegrationTest.testFetchFromLeaderWhilePreferredReadReplicaIsUnavailable

[ https://issues.apache.org/jira/browse/KAFKA-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737696#comment-17737696 ] Josep Prat commented on KAFKA-15105: Hi [~riedelmax], feel free to assign this issue to yourself :)

[GitHub] [kafka] kirktrue commented on pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

kirktrue commented on PR #13920: URL: https://github.com/apache/kafka/pull/13920#issuecomment-1609604468 @ableegoldman you're pretty familiar with this code, IIUC. If so, could you take a look at this PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] kirktrue commented on a diff in pull request #13921: MINOR: Reduce (hopefully) flakiness of testRackAwareRangeAssignor

kirktrue commented on code in PR #13921: URL: https://github.com/apache/kafka/pull/13921#discussion_r1243822717 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -249,6 +249,9 @@ class FetchFromFollowerIntegrationTest extends

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1243806647 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1072,1338 @@ public void replay(

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1243795683 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -609,7 +673,7 @@ public synchronized void

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have

[GitHub] [kafka] clolov closed pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

clolov closed pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests URL: https://github.com/apache/kafka/pull/12607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mumrah closed pull request #12883: Kip 866 part 1

mumrah closed pull request #12883: Kip 866 part 1 URL: https://github.com/apache/kafka/pull/12883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on PR #13880: URL: https://github.com/apache/kafka/pull/13880#issuecomment-1609431175 @jolshan @jeffkbkim Thanks for your review. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] mumrah commented on a diff in pull request #13910: KAFKA-15109 Ensure the leader epoch bump occurs for older MetadataVersions

mumrah commented on code in PR #13910: URL: https://github.com/apache/kafka/pull/13910#discussion_r1243667664 ## metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java: ## @@ -207,7 +211,7 @@ public void testTriggerLeaderEpochBumpIfNeeded() {

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243668510 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerdeTest.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243666829 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerdeTest.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243666154 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerdeTest.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243663487 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record. */

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243662918 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record. */

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243661641 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243660584 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243657611 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243657016 ## core/src/test/scala/unit/kafka/coordinator/group/CoordinatorLoaderImplTest.scala: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243649444 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243647581 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243647232 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1243468362 ## streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java: ## @@ -189,7 +221,22 @@ public Joined withOtherValueSerde(final Serde otherValueSerde) {

[GitHub] [kafka] divijvaidya commented on pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

divijvaidya commented on PR #13798: URL: https://github.com/apache/kafka/pull/13798#issuecomment-1609327501 Another point I want to call out is that Yammer metrics histogram is notorious for consuming CPU (and increase latency). It consumes ~4-5% CPU on the network threads for calculating

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

divijvaidya commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1243570850 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -17,25 +17,37 @@ package kafka.server +import

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

divijvaidya commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1243569174 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] yashmayya commented on a diff in pull request #13915: KAFKA-14930: Document the new PATCH and DELETE offsets REST APIs for Connect

yashmayya commented on code in PR #13915: URL: https://github.com/apache/kafka/pull/13915#discussion_r1243145305 ## docs/connect.html: ## @@ -313,7 +313,13 @@ REST API DELETE /connectors/{name} - delete a connector, halting all tasks and deleting its configuration

[jira] [Commented] (KAFKA-15128) snappy-java-1.1.8.4.jar library vulnerability

[ https://issues.apache.org/jira/browse/KAFKA-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737576#comment-17737576 ] Kamal Chandraprakash commented on KAFKA-15128: -- Snappy jar will be used to compress the

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

divijvaidya commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1243425245 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -90,30 +109,34 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] flashmouse commented on pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

flashmouse commented on PR #13920: URL: https://github.com/apache/kafka/pull/13920#issuecomment-1609178487 @divijvaidya thank you for reply! the unit test ``org.apache.kafka.clients.consumer.internals.AbstractStickyAssignorTest#testLargeAssignmentAndGroupWithNonEqualSubscription``

[GitHub] [kafka] tombentley commented on a diff in pull request #13862: KAFKA-15050: format the prompts in the quickstart

tombentley commented on code in PR #13862: URL: https://github.com/apache/kafka/pull/13862#discussion_r1243442987 ## docs/quickstart.html: ## @@ -154,9 +154,9 @@ By default, each line you enter will result in a separate event being written to the topic.

[jira] [Updated] (KAFKA-15128) snappy-java-1.1.8.4.jar library vulnerability

[ https://issues.apache.org/jira/browse/KAFKA-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] priyatama updated KAFKA-15128: -- Description: Hi Team, we found new vulnerability introduced in snappy-java-1.1.8.4 library, so we

[jira] [Updated] (KAFKA-15128) snappy-java-1.1.8.4.jar library vulnerability

[ https://issues.apache.org/jira/browse/KAFKA-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] priyatama updated KAFKA-15128: -- Priority: Major (was: Minor) > snappy-java-1.1.8.4.jar library vulnerability >

[GitHub] [kafka] divijvaidya commented on pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

divijvaidya commented on PR #13920: URL: https://github.com/apache/kafka/pull/13920#issuecomment-1609110377 Thank you for your first change to Apache Kafka @flashmouse! In the JIRA, you mention that this could be reproduced using a unit test. Can you please add the unit test here which

[jira] [Created] (KAFKA-15128) snappy-java-1.1.8.4.jar library vulnerability

priyatama created KAFKA-15128: - Summary: snappy-java-1.1.8.4.jar library vulnerability Key: KAFKA-15128 URL: https://issues.apache.org/jira/browse/KAFKA-15128 Project: Kafka Issue Type: Bug

[jira] [Assigned] (KAFKA-15127) Allow offsets to be reset at the same time a connector is deleted.

[ https://issues.apache.org/jira/browse/KAFKA-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-15127: - Assignee: Sagar Rao > Allow offsets to be reset at the same time a connector is deleted. >

[jira] [Assigned] (KAFKA-15106) AbstractStickyAssignor may stuck in 3.5

[ https://issues.apache.org/jira/browse/KAFKA-15106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] li xiangyuan reassigned KAFKA-15106: Assignee: li xiangyuan > AbstractStickyAssignor may stuck in 3.5 >

[jira] [Created] (KAFKA-15127) Allow offsets to be reset at the same time a connector is deleted.

Sagar Rao created KAFKA-15127: - Summary: Allow offsets to be reset at the same time a connector is deleted. Key: KAFKA-15127 URL: https://issues.apache.org/jira/browse/KAFKA-15127 Project: Kafka

  1   2   >