On Fri, 24 Feb 2023 06:26:21 GMT, Karthik P K wrote:
> > I think this class may benefit from a few tests that test with a very wide
> > caret, to see if positioning is what you'd expect in those cases as well. I
> > get the impression a lot of the code assumes a narrow caret (1 or 2 pixels)
>
On Thu, 23 Feb 2023 16:29:29 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
>> line 805:
>>
>>> 803: // appear at the left of the centered prompt.
>>> 804: newX = midPoint -
>>>
On Thu, 23 Feb 2023 17:40:05 GMT, Andy Goryachev wrote:
> It might behave differently when the caret is at the rightmost position next
> to the control edge, in which case the behavior is correct. Perhaps there
> ought to be some conditional logic implemented, but the way it behaves now
>
On Thu, 23 Feb 2023 09:20:26 GMT, John Hendrikx wrote:
> I think this class may benefit from a few tests that test with a very wide
> caret, to see if positioning is what you'd expect in those cases as well. I
> get the impression a lot of the code assumes a narrow caret (1 or 2 pixels)
> and
On Thu, 23 Feb 2023 09:11:56 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix text and prompt alignment issue
>
>
On Thu, 23 Feb 2023 16:34:11 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
>> line 818:
>>
>>> 816: } else if (newX < 0 && oldX > 1) {
>>> 817: textTranslateX.set(caretWidth / 2);
>>> 818:
On Thu, 23 Feb 2023 16:29:29 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
>> line 805:
>>
>>> 803: // appear at the left of the centered prompt.
>>> 804: newX = midPoint -
>>>
> When Text width was more than TextField width, the logic to update
> `textTranslateX` in `updateCaretOff` method was causing the issue of
> unexpected behavior for Right and Center alignment.
>
> Made changes to update `textTranslateX` in `updateCaretOff` method only when
> text width is
On Thu, 23 Feb 2023 17:48:39 GMT, Andy Goryachev wrote:
> Noticed a minor behavior issue, on Mac with multiple monitors. The secondary
> monitor (scale=1) is positioned above the primary retina screen (scale=2).
> When showing a popup in the case of 100 elements, the down arrow at the
>
On Thu, 23 Feb 2023 22:50:17 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve exception
>
> modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp line
> 118:
> Simple PR to remove gtk2 library compilation and loading.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Review changes
-
Changes:
- all: https://git.openjdk.org/jfx/pull/999/files
- new:
On Thu, 23 Feb 2023 11:28:56 GMT, Thiago Milczarek Sayao
wrote:
>> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore
>> this scroll event type, deltas are sent to java with the value equal to zero.
>>
>> Here's whats happening:
>>
>> We include all event masks, so when
> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this
> scroll event type, deltas are sent to java with the value equal to zero.
>
> Here's whats happening:
>
> We include all event masks, so when using gtk3 (>= 3.4.0) it includes
> `GDK_SMOOTH_SCROLL_MASK` meaning we
On Sun, 19 Feb 2023 18:29:16 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any
On Tue, 21 Feb 2023 00:29:13 GMT, Thiago Milczarek Sayao
wrote:
>> Simple PR to remove gtk2 library compilation and loading.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Improve exception
The updated fix and
On Thu, 23 Feb 2023 00:41:28 GMT, Thiago Milczarek Sayao
wrote:
>> This PR does:
>>
>> - Remove specific Idea files and let it be imported from gradle;
>> - Adds checkstyle (to use with checkstyle plugin - it will let you know
>> style mistakes);
>> - Configures auto-format to sun style (with
This fix properly supports colour rendering of Emoji on macOS
On other platforms the Emoji will be rendered as ordinary greyscale glyphs - if
there is font
support for the requested code point.
A simple manual test is provided which uses a Text node, Label control
and editable TextField
documentation change
**targeting jfx20 branch**
- fixed all incorrect references in "Also has all properties of ..."
- added a link to Shape where it was missing
- fixed chart -> Chart
-
Commit messages:
- 8303019: cssref.html incorrect internal link in Path
Changes:
On Thu, 23 Feb 2023 05:21:37 GMT, Karthik P K wrote:
>> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
>> offset was carried forward when the list is replaced with small number of
>> items. Hence the scroll up arrow was displayed with empty popup.
>>
>> Changed
On Thu, 23 Feb 2023 08:52:19 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix text and prompt alignment issue
>
>
On Thu, 22 Dec 2022 10:33:15 GMT, Ajit Ghaisas wrote:
>> When Text width was more than TextField width, the logic to update
>> `textTranslateX` in `updateCaretOff` method was causing the issue of
>> unexpected behavior for Right and Center alignment.
>>
>> Made changes to update
On Thu, 23 Feb 2023 07:36:43 GMT, Karthik P K wrote:
>> When Text width was more than TextField width, the logic to update
>> `textTranslateX` in `updateCaretOff` method was causing the issue of
>> unexpected behavior for Right and Center alignment.
>>
>> Made changes to update
On Wed, 22 Feb 2023 07:46:58 GMT, Jay Bhaskar wrote:
> Issue: current update is breaking the rendering of media controls on youtube
> video playback
>For the Webkit Gtk platform, the layout class name is returned as
> AdwaitaLayoutTraits
>which is incompatible with the
On Thu, 23 Feb 2023 11:28:56 GMT, Thiago Milczarek Sayao
wrote:
>> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore
>> this scroll event type, deltas are sent to java with the value equal to zero.
>>
>> Here's whats happening:
>>
>> We include all event masks, so when
> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this
> scroll event type, deltas are sent to java with the value equal to zero.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fix direction
On Thu, 23 Feb 2023 02:35:20 GMT, Thiago Milczarek Sayao
wrote:
>> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore
>> this scroll event type, deltas are sent to java with the value equal to zero.
>
> Thiago Milczarek Sayao has updated the pull request incrementally
On Thu, 23 Feb 2023 09:26:29 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ControlAcceleratorSupport.java
>> line 285:
>>
>>> 283: }
>>> 284:
>>> 285: private static void removeAcceleratorsFromScene(List>> MenuItem> items, Scene scene) {
On Wed, 22 Feb 2023 19:24:16 GMT, Andy Goryachev wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
On Thu, 23 Feb 2023 07:36:43 GMT, Karthik P K wrote:
>> When Text width was more than TextField width, the logic to update
>> `textTranslateX` in `updateCaretOff` method was causing the issue of
>> unexpected behavior for Right and Center alignment.
>>
>> Made changes to update
On Thu, 23 Feb 2023 07:36:43 GMT, Karthik P K wrote:
>> When Text width was more than TextField width, the logic to update
>> `textTranslateX` in `updateCaretOff` method was causing the issue of
>> unexpected behavior for Right and Center alignment.
>>
>> Made changes to update
Hi list,
I've been busy trying to ensure that ChangeListeners received sensible
old/new values at all times. This is important as users may be relying
on these values to be correct when doing calculations or creating nested
bindings (where an old listener is removed based on the old value
31 matches
Mail list logo
