On Sat, Jan 21, 2023 at 12:04:53PM -0800, Andres Freund wrote:
> On 2023-01-21 08:16:42 -0800, Noah Misch wrote:
> > On Fri, Jan 20, 2023 at 06:50:37PM -0800, Andres Freund wrote:
> > > I seems we don't have any tests for creating a subscription that fails
> > > during
> > > connection
Hi,
On 2023-01-21 23:21:22 -0500, Bruce Momjian wrote:
> On Sat, Jan 21, 2023 at 08:08:34PM -0800, Peter Geoghegan wrote:
> > On Sat, Jan 21, 2023 at 2:05 PM Peter Geoghegan wrote:
> > > There is one thing about clang-format that I find mildly infuriating:
> > > it can indent function
On Sun, Jan 22, 2023 at 12:18:34AM -0500, Isaac Morland wrote:
> On Thu, 19 Jan 2023 at 13:02, Isaac Morland wrote:
> > On Thu, 19 Jan 2023 at 11:30, Justin Pryzby wrote:
> >> On Wed, Jan 18, 2023 at 10:27:46AM -0500, Isaac Morland wrote:
> >> >
> >> > I thought I had:
Isaac Morland writes:
> It turns out that my tests wanted the owner to be “vagrant” rather than
> “postgres”. This is apparently because I was running as that user (in a
> Vagrant VM) when running the tests. Then I took that output and just made
> it the expected output. I’ve re-worked my build
On Thu, 19 Jan 2023 at 13:02, Isaac Morland wrote:
> On Thu, 19 Jan 2023 at 11:30, Justin Pryzby wrote:
>
>> On Wed, Jan 18, 2023 at 10:27:46AM -0500, Isaac Morland wrote:
>> >
>> > I thought I had: https://commitfest.postgresql.org/42/4133/
>>
>> This is failing tests:
>>
On Sat, Jan 21, 2023 at 08:08:34PM -0800, Peter Geoghegan wrote:
> On Sat, Jan 21, 2023 at 2:05 PM Peter Geoghegan wrote:
> > There is one thing about clang-format that I find mildly infuriating:
> > it can indent function declarations in the way that I want it to, and
> > it can indent variable
On Sat, Jan 21, 2023 at 2:05 PM Peter Geoghegan wrote:
> There is one thing about clang-format that I find mildly infuriating:
> it can indent function declarations in the way that I want it to, and
> it can indent variable declarations in the way that I want it to. It
> just can't do both at the
On Sat, Jan 21, 2023 at 6:54 PM Andres Freund wrote:
> Is
> https://www.postgresql.org/message-id/CAH2-WzmytCuSpaMEhv8H-jt8x_9whTi0T5bjNbH2gvaR0an2Pw%40mail.gmail.com
> the last / relevant version of the patch to look at?
Yes. I'm mostly just asking about v5-0001-* right now.
--
Peter
On Sat, Jan 21, 2023 at 3:39 PM Jelte Fennema wrote:
> I was unable to get either of them to produce the weird alignment of
> declarations that pgindent outputs. Maybe that's just because I don't
> understand what this alignment is supposed to do. Because to me the
> current alignment seems
On Wed, Jan 18, 2023 at 9:34 PM James Coleman wrote:
>
> On Wed, Jan 18, 2023 at 2:09 PM Tomas Vondra
> wrote:
> >
> > Hi,
> >
> > This patch hasn't been updated since September, and it got broken by
> > 4a29eabd1d91c5484426bc5836e0a7143b064f5a which the incremental sort
> > stuff a little bit.
Hi,
On 2023-01-21 18:37:59 -0800, Peter Geoghegan wrote:
> On Tue, Jan 17, 2023 at 10:02 AM Andres Freund wrote:
> > I think with a bit of polish "Add autovacuum trigger instrumentation." ought
> > to be quickly mergeable.
>
> Any thoughts on v5-0001-*?
>
> It would be nice to get the
On Tue, Jan 17, 2023 at 10:02 AM Andres Freund wrote:
> I think with a bit of polish "Add autovacuum trigger instrumentation." ought
> to be quickly mergeable.
Any thoughts on v5-0001-*?
It would be nice to get the uncontentious part of all this (which is
the instrumentation patch) out of the
The attached patch adds GUCs to control the use of the abbreviated keys
optimization when sorting. Also, I changed the TRUST_STRXFRM from a
#define into a GUC.
One reason for these GUCs is to make it easier to diagnose any issues
that come up with my collation work. Another is that I observed
Attached are a .clang-format file and an uncrustify.cfg file that I
whipped up to match the current style at least somewhat.
I was unable to get either of them to produce the weird alignment of
declarations that pgindent outputs. Maybe that's just because I don't
understand what this alignment is
On Sat, Jan 21, 2023 at 2:43 PM Andres Freund wrote:
> Unless I miss something, I don't think clang-format actually does that level
> of C parsing - you can't pass include paths etc, so it really can't.
It's hard to keep track of, since I also use clangd, which is
influenced by .clang-format for
Hi,
On 2023-01-21 17:20:35 -0500, Tom Lane wrote:
> I don't feel wedded to every last detail of what pgindent does (and
> especially not the bugs). But I think if the new tool is not a pretty
> close match we'll be in for years of back-patching pain. We have made
> changes in pgindent itself in
Hi,
On 2023-01-21 14:05:41 -0800, Peter Geoghegan wrote:
> On Sat, Jan 21, 2023 at 12:59 PM Tom Lane wrote:
> > Hmm, that could be a deal-breaker. It's not going to be acceptable
> > to have to pgindent different parts of the system on different platforms
> > ... at least not unless we can
Peter Geoghegan writes:
> Of course the way that I want to do things is (almost by definition)
> the pgindent way, at least right now -- it's not necessarily about my
> fixed preferences (though it can be hard to tell!). It's really not
> surprising that clang-format cannot quite perfectly
Hi,
On 2023-01-20 11:08:54 -0500, Robert Haas wrote:
> /*
> - * Validate connection info string (just try to parse it)
> + * Validate connection info string, and determine whether it might cause
> + * local filesystem access to be attempted.
> + *
> + * If the connection string can't be parsed,
On Sat, Jan 21, 2023 at 12:59 PM Tom Lane wrote:
> Hmm, that could be a deal-breaker. It's not going to be acceptable
> to have to pgindent different parts of the system on different platforms
> ... at least not unless we can segregate them on the file level, and
> even that would have a large
Hi,
On 2023-01-20 08:25:46 -0500, Robert Haas wrote:
> Worse still, I have always felt that the security vulnerability that
> led to these controls being installed is pretty much fabricated: it's
> an imaginary problem. Today I went back and found the original CVE at
>
Hi,
Due to [1] I thought it'd be a good idea to write an isolation test for
testing postgres_fdw interruptability during connection establishment.
I was able to make that work - but unfortunately doing so requires preventing
a login from completing. The only way I could see to achieve that is to
Hi Mahmoud,
I finally had time to properly read the paper today - the general
approach mostly matches how I imagined the estimation would work for
inequalities, but it's definitely nice to see the algorithm properly
formalized and analyzed.
What seems a bit strange to me is that the patch only
Peter Geoghegan writes:
> In practice this approach tends to run into problems when the relevant
> AST isn't available. For example, if there's code that only builds on
> Windows, maybe it won't work at all (at least on my Linux system).
Hmm, that could be a deal-breaker. It's not going to be
On Sat, Jan 21, 2023 at 9:30 AM Bruce Momjian wrote:
> I don't see uncrustify or clang-format supporting typedef lists so maybe
> they implemented this feedback loop. It would be good to see if we can
> get either of these tools to match our formatting.
I personally use clang-format for
Hi,
On 2023-01-21 08:16:42 -0800, Noah Misch wrote:
> On Fri, Jan 20, 2023 at 06:50:37PM -0800, Andres Freund wrote:
> > On 2023-01-20 17:12:37 -0800, Andres Freund wrote:
> > > We have code like this in libpqrcv_connect():
> > It's bit worse than I earlier thought: We use walrv_connect() during
Hi,
On 2023-01-20 21:31:57 -0800, Andres Freund wrote:
> On 2023-01-20 20:16:13 -0800, Andres Freund wrote:
> > I'm planning to push most of my changes soon, had hoped to get to it a bit
> > sooner, but ...
>
> I pushed the int64-ification commits.
There's an odd compilation failure on AIX.
On Fri, Jan 20, 2023 at 2:43 PM Tom Lane wrote:
> Andres Freund writes:
> > There's a few places in the code that try to format a variable definition
> > like this
>
> > ReorderBufferChange *next_change =
> > dlist_container(ReorderBufferChange, node, next);
>
> > but pgindent turns
Hi Tomas,
On 21.01.2023 00:50, Tomas Vondra wrote:
Hi Egor,
While reviewing a patch improving join estimates for ranges [1] I
realized we don't show stats for ranges in pg_stats, and I recalled we
had this patch.
I rebased the v2, and I decided to took a stab at showing separate
histograms
On Sat, Jan 21, 2023 at 01:17:27PM -0500, Tom Lane wrote:
> Bruce Momjian writes:
> > I just checked if wcswidth() would honor graphene clusters, though
> > wcwidth() does not, but it seems wcswidth() treats characters just like
> > wcwidth():
>
> Well, that's at least potentially fixable within
Bruce Momjian writes:
> I just checked if wcswidth() would honor graphene clusters, though
> wcwidth() does not, but it seems wcswidth() treats characters just like
> wcwidth():
Well, that's at least potentially fixable within libc, while wcwidth
clearly can never do this right.
Probably our
On Sat, Jan 21, 2023 at 12:37:30PM -0500, Bruce Momjian wrote:
> Well, as one of the URLs I quoted said:
>
> This is by design. wcwidth() is utterly broken. Any terminal or
> terminal application that uses it is also utterly broken. Forget
> about emoji wcwidth() doesn't even
On Sat, Jan 21, 2023 at 11:20:39AM -0500, Greg Stark wrote:
> On Fri, 20 Jan 2023 at 00:07, Pavel Stehule wrote:
> >
> > I partially watch an progres in VTE - one of the widely used terminal libs,
> > and I am very sceptical so there will be support in the next two years.
> >
> > Maybe the new
On Fri, Jan 20, 2023 at 10:43:50AM +0100, Jelte Fennema wrote:
> Side-question: What's the reason why pgindent is used instead of some
> more "modern" code formatter that doesn't require keeping
> typedefs.list up to date for good looking output? (e.g. uncrustify or
> clang-format) Because that
Greg Stark writes:
> (If we were really crazy about this we could use terminal escape codes
> to query the current cursor position after emitting multicharacter
> graphemes. But as I said, I don't even think that would be useful,
> even if there weren't other reasons it would be a bad idea)
so 21. 1. 2023 v 17:21 odesílatel Greg Stark napsal:
> On Fri, 20 Jan 2023 at 00:07, Pavel Stehule
> wrote:
> >
> > I partially watch an progres in VTE - one of the widely used terminal
> libs, and I am very sceptical so there will be support in the next two
> years.
> >
> > Maybe the new
... btw, can we get away with making the diff run be "diff -upd"
not just "diff -u"? I find diff output for C files noticeably
more useful with those options, but I'm unsure about their
portability.
regards, tom lane
On Fri, 20 Jan 2023 at 00:07, Pavel Stehule wrote:
>
> I partially watch an progres in VTE - one of the widely used terminal libs,
> and I am very sceptical so there will be support in the next two years.
>
> Maybe the new microsoft terminal will give this area a new dynamic, but
> currently
On Fri, Jan 20, 2023 at 06:50:37PM -0800, Andres Freund wrote:
> On 2023-01-20 17:12:37 -0800, Andres Freund wrote:
> > We have code like this in libpqrcv_connect():
> >
> > conn = palloc0(sizeof(WalReceiverConn));
> > conn->streamConn = PQconnectStartParams(keys, vals,
> >
pá 20. 1. 2023 v 19:46 odesílatel Mikhail Gribkov
napsal:
> Hi Pavel,
>
> On Mon, Jan 16, 2023 at 9:10 AM Pavel Stehule
> wrote:
>
>>
>>
>> ne 15. 1. 2023 v 7:32 odesílatel Pavel Stehule
>> napsal:
>>
>>> Hi
>>>
>>>
On Thu, Jan 12, 2023 at 9:51 AM Pavel Stehule
wrote:
>
Andrew Dunstan writes:
>>> I think we could do better with some automation tooling for committers
>>> here. One low-risk and simple change would be to provide a
>>> non-destructive mode for pgindent that would show you the changes if any
>>> it would make. That could be worked into a git
On 2023-01-21 Sa 10:02, Andrew Dunstan wrote:
> On 2023-01-21 Sa 10:00, Andrew Dunstan wrote:
>> On 2023-01-21 Sa 08:26, Andrew Dunstan wrote:
>>> On 2023-01-20 Fr 13:19, Tom Lane wrote:
Andres Freund writes:
> On 2023-01-20 12:09:05 -0500, Tom Lane wrote:
>> The core problem here
On 2023-01-21 Sa 10:00, Andrew Dunstan wrote:
> On 2023-01-21 Sa 08:26, Andrew Dunstan wrote:
>> On 2023-01-20 Fr 13:19, Tom Lane wrote:
>>> Andres Freund writes:
On 2023-01-20 12:09:05 -0500, Tom Lane wrote:
> The core problem here is that requiring that would translate to
>
On 2023-01-21 Sa 08:26, Andrew Dunstan wrote:
> On 2023-01-20 Fr 13:19, Tom Lane wrote:
>> Andres Freund writes:
>>> On 2023-01-20 12:09:05 -0500, Tom Lane wrote:
The core problem here is that requiring that would translate to
requiring every code contributor to have a working copy of
On Sat, Jan 21, 2023 at 3:05 AM Dean Rasheed
wrote:
> On Tue, 10 Jan 2023 at 14:43, Dean Rasheed
> wrote:
> >
> > Rebased version attached.
> >
>
> Rebased version, following 8eba3e3f02 and 5d29d525ff.
>
> Regards,
> Dean
>
Hi,
In transform_MERGE_to_join :
+ if
Attached are 2 v9 patch versions. I don't think I like them.
I think the v8 versions are better. But I thought it
wouldn't hurt to show them to you.
On Fri, 20 Jan 2023 14:22:25 -0600
"Karl O. Pinc" wrote:
> Attached are 2 alternatives:
> (They touch separate files so the ordering is
On 2023-01-20 Fr 13:19, Tom Lane wrote:
> Andres Freund writes:
>> On 2023-01-20 12:09:05 -0500, Tom Lane wrote:
>>> The core problem here is that requiring that would translate to
>>> requiring every code contributor to have a working copy of pg_bsd_indent.
>> Wouldn't just every committer
Hi Jacob,
> I think the sslcertmode=disable option that I introduced in [1]
solves this issue too;
Well, I see there is indeed a significant overlap between our patches -
but yours has a much more comprehensive approach! If I got it right,
the new slcertmode=disable would indeed cancel the
On Sat, Jan 21, 2023 at 4:03 AM Hayato Kuroda (Fujitsu) <
kuroda.hay...@fujitsu.com> wrote:
> Dear Katsuragi-san,
>
> Thank you for reviewing! PSA new patch set.
>
> > ## v24-0001-Add-PQConncheck-and-PQCanConncheck-to-libpq.patch
> > +
> > +
> > PQCanConncheckPQCan
> > Conncheck
> > +
>
Dear Katsuragi-san,
Thank you for reviewing! PSA new patch set.
> ## v24-0001-Add-PQConncheck-and-PQCanConncheck-to-libpq.patch
> +
> +
> PQCanConncheckPQCan
> Conncheck
> +
> +
> + Returns the status of the socket.
>
> Is this description right? I think this description is
On Tue, 10 Jan 2023 at 14:43, Dean Rasheed wrote:
>
> Rebased version attached.
>
Rebased version, following 8eba3e3f02 and 5d29d525ff.
Regards,
Dean
diff --git a/doc/src/sgml/mvcc.sgml b/doc/src/sgml/mvcc.sgml
new file mode 100644
index b87ad5c..1482ede
--- a/doc/src/sgml/mvcc.sgml
+++
51 matches
Mail list logo
