Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r165994809
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -71,40 +74,64 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r164825718
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -71,40 +74,64 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r163001901
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -71,40 +74,64 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r162997172
--- Diff: docs/running-on-mesos.md ---
@@ -427,15 +437,30 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/20167
Hello @rvesse thanks for this patch! With Mesos having [reference
secrets](https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L2596)
now I think providing this as a file
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r161385124
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -80,10 +80,27 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/20167#discussion_r161385080
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -80,10 +80,27 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r153510604
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -542,7 +496,54 @@ private[spark] class SecurityManager(
* Gets
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153348394
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala
---
@@ -82,6 +82,12 @@ private[mesos] class
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19390
@skonto I checked this again. Works great, thanks for the patch.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19793
@Gschiavon Looking.. thanks for the ping.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19798
@kalvinnchau thanks for catching this mistake. @vanzin can we get a quick
merge?
---
-
To unsubscribe, e-mail: reviews
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19390
Just to reiterate our conversation here.
The `AllocationInfo` tells the scheduler which `role`âs allocation of
resources the `Offer` is coming from, whereas the `ReservationInfo` tells
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19272
@vanzin Thanks for the reviews and mentorship!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r151239494
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosHadoopDelegationTokenManager.scala
---
@@ -0,0 +1,157
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19272
@vanzin PTAL.
I removed the awkward `mode` parameter from the token manager. Now we only
start the renewer thread when using a keytab/principal. The condition is logged
appropriately
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r150942920
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosHadoopDelegationTokenManager.scala
---
@@ -0,0 +1,185
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r150933634
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosHadoopDelegationTokenManager.scala
---
@@ -0,0 +1,185
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r150717225
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosHadoopDelegationTokenManager.scala
---
@@ -0,0 +1,185
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r150711225
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosHadoopDelegationTokenManager.scala
---
@@ -0,0 +1,185
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19272
Hello @maverick2202, hopefully 2.3 (and maybe back ported?) but that's up
to the Committers.
---
-
To unsubscribe, e-mail
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19272
Hello @vanzin thanks for the continued help with this, anything else
needed?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r149797247
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -213,6 +216,14
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19555
Hey @srowen can we get a merge on this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r149564294
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -213,6 +216,14
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r149549953
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -213,6 +216,14
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r149466183
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -542,7 +496,55 @@ private[spark] class SecurityManager(
* Gets
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r149456772
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionClient.scala ---
@@ -398,9 +399,20 @@ private[spark] object RestSubmissionClient
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r149455493
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -542,7 +496,55 @@ private[spark] class SecurityManager(
* Gets
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r149375998
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionClient.scala ---
@@ -398,9 +399,20 @@ private[spark] object RestSubmissionClient
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r149375879
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -365,22 +370,21 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r149375835
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -542,7 +496,55 @@ private[spark] class SecurityManager(
* Gets
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r149361297
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -542,7 +496,55 @@ private[spark] class SecurityManager(
* Gets
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19272
Hello @vanzin thanks for continuing to help with this. Please take another
look at this refactor.
In this change, there is one place to interact with
`hadoopDelegationTokens` from
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r148982457
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -58,8 +62,9
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r148982255
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -686,18 +687,7 @@ class
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r148982165
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -99,11 +96,8 @@ class
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19272
@vanzin Thanks for the continued review. I addressed the comments you left.
PTAL.
It seems simplest and more robust to keep the serialized `Credentials`
within
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r148013037
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -233,10 +249,15 @@ class
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r147866441
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterManager.scala
---
@@ -17,7 +17,7
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/18098
@PerilousApricot what do you mean topology?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147463877
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -427,10 +441,10 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147461660
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -138,7 +138,7 @@ lz4-java-1.4.0.jar
machinist_2.11-0.6.1.jar
macro-compat_2.11-1.1.1.jar
mail
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19510#discussion_r147121858
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -64,6 +64,7
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147069130
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -427,10 +441,10 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147067951
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -349,13 +349,22
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147067641
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -451,15 +465,20 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r147066762
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -175,17 +176,36 @@ trait
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19543
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19543
Just one super-nit.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19543#discussion_r146971307
--- Diff: docs/running-on-mesos.md ---
@@ -458,6 +461,14 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r146855311
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -213,6 +216,24
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19515
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19555
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r146473582
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMCredentialRenewer.scala
---
@@ -59,8 +59,7 @@ private[yarn] class
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r146472162
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -213,6 +216,24
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19515
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19515
Yeah that sounds good. Thanks for this!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19555#discussion_r146244212
--- Diff: docs/running-on-mesos.md ---
@@ -613,6 +621,41 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19555#discussion_r146242613
--- Diff: docs/running-on-mesos.md ---
@@ -196,17 +196,18 @@ configuration variables:
* Executor memory: `spark.executor.memory`
* Executor
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19555#discussion_r146242931
--- Diff: docs/running-on-mesos.md ---
@@ -344,6 +345,13 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19555#discussion_r146242882
--- Diff: docs/running-on-mesos.md ---
@@ -196,17 +196,18 @@ configuration variables:
* Executor memory: `spark.executor.memory`
* Executor
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19543#discussion_r146132173
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
---
@@ -254,6 +254,32 @@ class
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19543#discussion_r146132144
--- Diff: docs/running-on-mesos.md ---
@@ -458,6 +461,13 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19272
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r146094019
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -194,6 +198,27
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r145861062
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -194,6 +198,27
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r145301221
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -194,6 +198,27
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r145300847
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCredentialRenewer.scala
---
@@ -0,0 +1,154
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19272#discussion_r145298313
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCredentialRenewer.scala
---
@@ -0,0 +1,154
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145298003
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145294156
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -173,6 +178,90 @@ private
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145294352
--- Diff: docs/running-on-mesos.md ---
@@ -501,23 +503,74 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145294074
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -17,10 +17,14
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r145294610
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -122,7 +126,8 @@ private
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19515
Hello @pmackles, thanks for this. It would be set to the value of
`SPARK_DRIVER_MEMORY` by default correct? What to you think about introducing a
new envvar (`SPARK_DISPATCHER_MEMORY`) so
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r145292254
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -135,22 +135,24 @@ private
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19374
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145010250
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -469,6 +474,12 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145009696
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/18784
@jiangxb1987 yes. I'll work to review this ASAP.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19272
@vanzin Thanks for the review. I'll address the comments ASAP.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r144682661
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -896,8 +913,8 @@ private
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r144682434
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -373,10 +374,16 @@ class SparkContext(config: SparkConf) extends Logging
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r144682554
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -374,6 +375,15 @@ private
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144682189
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -28,6 +28,8 @@ import
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144682211
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -175,14 +175,22 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144682163
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144682379
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -469,6 +474,12 @@ trait
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144682312
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -17,10 +17,14
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144681733
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +175,119
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144680213
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosFineGrainedSchedulerBackend.scala
---
@@ -159,7 +160,8
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144680478
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +175,119
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144680608
--- Diff: docs/running-on-mesos.md ---
@@ -522,6 +522,43 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144681758
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +175,119
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144680448
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -122,7 +126,8 @@ private
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144680489
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +175,119
Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r144680353
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -122,7 +126,8 @@ private
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19437
@susanxhuynh @skonto The secret-containing protos will be valid in Mesos
1.3 onwards, thus why the scheduler has that requirement. DC/OS with file-based
secrets has Mesos 1.4 thus why we test
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/19272
@kalvinnchau I'm running Hadoop 2.6 on a DC/OS cluster with Mesos 1.4.0
---
-
To unsubscribe, e-mail: reviews-unsubscr
1 - 100 of 146 matches
Mail list logo
