Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21854
ping @cloud-fan @zsxwing Is this ready to merge? Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21952
@dbtsai I was thinking the same thing. I will do the test later after I
come back to my laptop.
---
-
To unsubscribe, e-mail
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21952
@dbtsai I didn't use Spark 2.3 when testing databricks-avro. I also used
current master. But because a recent change of schema verifying
(`FileFormat.supportDataType`) causes incompatibility, I
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20146
ping @jkbradley @dbtsai shall we consider to include this in 2.4?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21954#discussion_r207098029
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -0,0 +1,325 @@
+/*
+ * Licensed
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21952
Maybe due to test environment difference, I ran the benchmark code above
but didn't notice significant regression. See if others can confirm the
regression too
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21909#discussion_r206976717
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FailureSafeParser.scala
---
@@ -56,9 +57,14 @@ class FailureSafeParser
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21939#discussion_r206730119
--- Diff: pom.xml ---
@@ -190,7 +190,7 @@
If you are changing Arrow version specification, please check
./python/pyspark/sql/utils.py
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21854#discussion_r206714766
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1446,3 +1448,17 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21854#discussion_r206711618
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2124,6 +2124,9 @@ class Analyzer(
override def
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21852
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21847#discussion_r206699403
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -165,16 +186,117 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21847#discussion_r206623930
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -165,16 +182,118 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21854
ping @tdas @zsxwing @jose-torres
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21847#discussion_r206369173
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -165,16 +182,118 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21847#discussion_r206369093
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -165,16 +182,118 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21847#discussion_r206368836
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -165,16 +182,118 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21847#discussion_r206368071
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -165,16 +182,118 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21904#discussion_r206318942
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +450,12 @@ object SimplifyConditionals
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21904#discussion_r206319701
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +450,12 @@ object SimplifyConditionals
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16677
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
@cloud-fan Makes sense. Updated change now enables top-level Option of
Product encoder.
---
-
To unsubscribe, e-mail: reviews
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16677
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21826
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r206000924
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,23 @@ object SimplifyConditionals
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r205960624
--- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContextImpl.scala
---
@@ -39,8 +44,51 @@ private[spark] class BarrierTaskContextImpl
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r205960662
--- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContextImpl.scala
---
@@ -39,8 +44,51 @@ private[spark] class BarrierTaskContextImpl
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r205960497
--- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala ---
@@ -27,6 +27,33 @@ trait BarrierTaskContext extends TaskContext {
* Sets
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21904#discussion_r205958402
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,29 @@ object SimplifyConditionals
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21904#discussion_r205958393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,29 @@ object SimplifyConditionals
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21772
LGTM too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21904#discussion_r205925217
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,29 @@ object SimplifyConditionals
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
@cloud-fan We can. Just wondering if you think it is good to have that in
this PR too?
---
-
To unsubscribe, e-mail: reviews
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21837#discussion_r205647732
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala ---
@@ -21,16 +21,18 @@ import org.apache.hadoop.conf.Configuration
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21837#discussion_r205647795
--- Diff:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala ---
@@ -364,7 +364,7 @@ class AvroSuite extends QueryTest
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21837#discussion_r205647805
--- Diff:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala ---
@@ -364,7 +364,7 @@ class AvroSuite extends QueryTest
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21837#discussion_r205620420
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1434,6 +1435,20 @@ object SQLConf {
"This only
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21886
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
ping @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205575498
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1407,6 +1408,87 @@ object ReplaceExceptWithAntiJoin
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205574160
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1475,6 +1475,28 @@ def intersect(self, other):
"""
return
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205573413
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1407,6 +1408,87 @@ object ReplaceExceptWithAntiJoin
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205573922
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1933,6 +1933,22 @@ class Dataset[T] private[sql](
Intersect
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205573522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1407,6 +1408,87 @@ object ReplaceExceptWithAntiJoin
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21886
Typo in the PR description: `IF (vcol1_cnt > vcol1_cnt, vcol2_cnt,
vcol1_cnt)` -> `IF (vcol1_cnt > vcol2_cnt, vcol2_cnt,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205565594
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -532,9 +532,13 @@ abstract class SparkStrategies extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205565280
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1400,13 +1401,71 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205558989
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1400,13 +1401,71 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205561228
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -532,9 +532,13 @@ abstract class SparkStrategies extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205561601
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -293,6 +293,28 @@ def explain(self, extended=False):
else:
print(self
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205560454
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1947,6 +1947,21 @@ class Dataset[T] private[sql](
Except
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21847#discussion_r205549727
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -165,16 +183,100 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21847#discussion_r205550412
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -165,16 +183,100 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21847#discussion_r205550953
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -165,16 +183,100 @@ class AvroSerializer(rootCatalystType
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20861#discussion_r205540393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1994,6 +1996,20 @@ class Analyzer
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r205309619
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,21 @@ object SimplifyConditionals
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r205303174
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala
---
@@ -122,4 +126,25 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21852#discussion_r205303069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -416,6 +416,22 @@ object SimplifyConditionals
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21868#discussion_r205278858
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -401,12 +399,41 @@ case class FileSourceScanExec
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21868#discussion_r205278202
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -381,6 +381,26 @@ object SQLConf {
.booleanConf
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21847#discussion_r205236872
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -41,7 +42,7 @@ class AvroSerializer(rootCatalystType: DataType
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21850
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21850
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21850#discussion_r204946804
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -414,6 +414,9 @@ object SimplifyConditionals extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21850#discussion_r204945881
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -414,6 +414,16 @@ object SimplifyConditionals
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21439#discussion_r204933936
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -544,34 +544,27 @@ case class JsonToStructs
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21439#discussion_r204932903
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -544,34 +544,27 @@ case class JsonToStructs
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21439#discussion_r204931175
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -136,12 +136,11 @@ class JsonFunctionsSuite extends QueryTest
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21439#discussion_r204915146
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -101,6 +102,17 @@ class JacksonParser
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21850#discussion_r204851642
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala
---
@@ -61,7 +61,17 @@ class
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21854
cc @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/16677
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21854
Actually I think `Rand` and `Randn` should also have the same issue. But I
want to hear opinions first before dealing them
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21854#discussion_r204622960
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1392,3 +1394,17 @@ object
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/21854
[SPARK-24896][SQL] Uuid should produce different values for each execution
in streaming query
## What changes were proposed in this pull request?
`Uuid`'s results depend on random seed
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21772
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21772#discussion_r204618927
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
---
@@ -278,6 +278,39 @@ class HashedRelationSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21772#discussion_r204618745
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
---
@@ -278,6 +278,39 @@ class HashedRelationSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21772#discussion_r204618320
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
---
@@ -278,6 +278,39 @@ class HashedRelationSuite extends
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21772
As you actually modify `LongToUnsafeRowMap`, is it better to update the PR
title and description to reflect
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21772#discussion_r204617884
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -772,6 +772,8 @@ private[execution] final class
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21848
Hmm, seems we have limitation on where non deterministic expressions can be
in.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r204580788
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/TakeOrderedAndProjectSuite.scala
---
@@ -22,6 +22,7 @@ import scala.util.Random
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21848
For now, seems we don't have a good way to know if an expression has side
effect. Some expressions like `AssertTrue` should be marked as one with side
effect. Maybe we should create a trait
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21848
This is a good point.
On Mon, Jul 23, 2018, 12:03 PM Dongjoon Hyun
wrote:
> Since this skips the evaluation of if condition, this will cause the
> following diff
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21848
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204507068
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -651,6 +652,7 @@ object
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21772
@liutang123 Thanks for this work. I'm curious that if this is an actual
problem you hit in real application, or you just think it is problematic
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21772#discussion_r204276973
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
---
@@ -278,6 +278,39 @@ class HashedRelationSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21772#discussion_r204276886
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -770,8 +771,10 @@ private[execution] final class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21772#discussion_r204276788
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -726,9 +726,10 @@ private[execution] final class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21802#discussion_r204276502
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -1419,4 +1421,71 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20861#discussion_r204272567
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1994,6 +1996,20 @@ class Analyzer
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20861#discussion_r204266884
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1994,6 +1996,20 @@ class Analyzer
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16677#discussion_r204221009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -204,6 +204,13 @@ object SQLConf {
.intConf
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20861#discussion_r204201930
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1994,6 +1996,20 @@ class Analyzer
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20146
@HyukjinKwon Yeah, looks like re-triggering the AppVeyor build passes.
Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21826#discussion_r204190916
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -442,8 +442,6 @@ case class Or(left: Expression
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20856
@HyukjinKwon @cloud-fan Thanks for pinging me, sorry for replying late.
Yeah I looked at the final fixing at #21815, it looks good for a fixing at this
particular problem.
> It seems to
901 - 1000 of 9955 matches
Mail list logo
