[GitHub] spark issue #17995: [SPARK-20762][ML]Make String Params Case-Insensitive

2017-06-25 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/17995 @yanboliang I update this PR and revert changes on `setSolver` in GLR and LiR. Thanks for your reviewing. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #17995: [SPARK-20762][ML]Make String Params Case-Insensitive

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17995 **[Test build #78607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78607/testReport)** for PR 17995 at commit

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123931580 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -81,7 +83,8 @@ private[classification]

[GitHub] spark pull request #18334: [SPARK-21127] [SQL] Update statistics after data ...

2017-06-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18334#discussion_r123930251 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala --- @@ -0,0 +1,112 @@ +/* +* Licensed to the Apache

[GitHub] spark issue #18419: [SPARK-20213][SQL][follow-up] introduce SQLExecution.ign...

2017-06-25 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18419 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-06-25 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r123930006 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18419: [SPARK-20213][SQL][follow-up] introduce SQLExecut...

2017-06-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18419#discussion_r123929987 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala --- @@ -118,4 +125,19 @@ object SQLExecution {

[GitHub] spark pull request #18334: [SPARK-21127] [SQL] Update statistics after data ...

2017-06-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18334#discussion_r123929887 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala --- @@ -165,6 +167,22 @@ private[sql] trait SQLTestUtils }

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17084 **[Test build #78606 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78606/testReport)** for PR 17084 at commit

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/17084 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/17084 the pip packaging failing seems to be unrelated to the code... let me try this again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #18419: [SPARK-20213][SQL][follow-up] introduce SQLExecut...

2017-06-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18419#discussion_r123928964 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala --- @@ -118,4 +125,19 @@ object SQLExecution {

[GitHub] spark pull request #18334: [SPARK-21127] [SQL] Update statistics after data ...

2017-06-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18334#discussion_r123928827 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala --- @@ -0,0 +1,112 @@ +/* +* Licensed to the Apache

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11994 **[Test build #78605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78605/testReport)** for PR 11994 at commit

[GitHub] spark issue #18368: [SPARK-21102][SQL] Make refresh resource command less ag...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18368 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78596/ Test FAILed. ---

[GitHub] spark issue #18368: [SPARK-21102][SQL] Make refresh resource command less ag...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18368 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18405 **[Test build #78604 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78604/testReport)** for PR 18405 at commit

[GitHub] spark issue #18368: [SPARK-21102][SQL] Make refresh resource command less ag...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18368 **[Test build #78596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78596/testReport)** for PR 18368 at commit

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-06-25 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18405 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17084 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78598/ Test FAILed. ---

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17084 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17084 **[Test build #78598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78598/testReport)** for PR 17084 at commit

[GitHub] spark issue #17758: [SPARK-20460][SPARK-21144][SQL] Make it more consistent ...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17758 **[Test build #78603 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78603/testReport)** for PR 17758 at commit

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17084 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17084 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78597/ Test PASSed. ---

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17084 **[Test build #78597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78597/testReport)** for PR 17084 at commit

[GitHub] spark issue #17758: [SPARK-20460][SPARK-21144][SQL] Make it more consistent ...

2017-06-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17758 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18334: [SPARK-21127] [SQL] Update statistics after data changin...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18334 **[Test build #78602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78602/testReport)** for PR 18334 at commit

[GitHub] spark issue #18419: [SPARK-20213][SQL][follow-up] introduce SQLExecution.ign...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18419 **[Test build #78600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78600/testReport)** for PR 18419 at commit

[GitHub] spark issue #18418: [SPARK-19104][SQL] Lambda variables should work when par...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18418 **[Test build #78601 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78601/testReport)** for PR 18418 at commit

[GitHub] spark issue #18419: [SPARK-20213][SQL][follow-up] introduce SQLExecution.ign...

2017-06-25 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18419 cc @rdblue @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18419: [SPARK-20213][SQL][follow-up] introduce SQLExecut...

2017-06-25 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/18419 [SPARK-20213][SQL][follow-up] introduce SQLExecution.ignoreNestedExecutionId ## What changes were proposed in this pull request? in https://github.com/apache/spark/pull/18064, to work

[GitHub] spark pull request #18366: [SPARK-20889][SparkR] Grouped documentation for S...

2017-06-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18366#discussion_r123925897 --- Diff: R/pkg/R/functions.R --- @@ -635,20 +652,16 @@ setMethod("dayofyear", column(jc) }) -#' decode

[GitHub] spark pull request #18366: [SPARK-20889][SparkR] Grouped documentation for S...

2017-06-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18366#discussion_r123926400 --- Diff: R/pkg/R/functions.R --- @@ -1503,18 +1491,12 @@ setMethod("skewness", column(jc) }) -#' soundex

[GitHub] spark issue #18334: [SPARK-21127] [SQL] Update statistics after data changin...

2017-06-25 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/18334 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18418: [SPARK-19104][SQL] Lambda variables should work when par...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18418 **[Test build #78599 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78599/testReport)** for PR 18418 at commit

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18405 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78593/ Test FAILed. ---

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18405 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18405 **[Test build #78593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78593/testReport)** for PR 18405 at commit

[GitHub] spark pull request #18418: [SPARK-19104][SQL] Lambda variables should work w...

2017-06-25 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/18418 [SPARK-19104][SQL] Lambda variables should work when parent expression splits generated codes ## What changes were proposed in this pull request? When an expression using lambda variables

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17084 **[Test build #78598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78598/testReport)** for PR 17084 at commit

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/17084 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use...

2017-06-25 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/17084#discussion_r123925697 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/binary/BinaryConfusionMatrix.scala --- @@ -22,22 +22,22 @@ package

[GitHub] spark pull request #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use...

2017-06-25 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/17084#discussion_r123925523 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetrics.scala --- @@ -146,11 +160,13 @@ class

[GitHub] spark pull request #17451: [SPARK-19866][ML][PySpark] Add local version of W...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17451#discussion_r123925184 --- Diff: python/pyspark/ml/feature.py --- @@ -2869,6 +2869,18 @@ def findSynonyms(self, word, num): word = _convert_to_vector(word)

[GitHub] spark pull request #17451: [SPARK-19866][ML][PySpark] Add local version of W...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17451#discussion_r123925233 --- Diff: python/pyspark/ml/feature.py --- @@ -2869,6 +2869,18 @@ def findSynonyms(self, word, num): word = _convert_to_vector(word)

[GitHub] spark pull request #17451: [SPARK-19866][ML][PySpark] Add local version of W...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17451#discussion_r123925086 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -274,6 +274,31 @@ class Word2VecModel private[ml] (

[GitHub] spark pull request #17451: [SPARK-19866][ML][PySpark] Add local version of W...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17451#discussion_r123925064 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -274,6 +274,31 @@ class Word2VecModel private[ml] (

[GitHub] spark pull request #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use...

2017-06-25 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/17084#discussion_r123925437 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetrics.scala --- @@ -41,13 +41,27 @@ import

[GitHub] spark pull request #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use...

2017-06-25 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/17084#discussion_r123925177 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala --- @@ -77,12 +87,16 @@ class

[GitHub] spark pull request #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use...

2017-06-25 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/17084#discussion_r123924688 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala --- @@ -36,12 +36,18 @@ import

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17084 **[Test build #78597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78597/testReport)** for PR 17084 at commit

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-25 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r123924134 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java --- @@ -123,6 +126,8 @@ this.inMemSorter = new

[GitHub] spark issue #18334: [SPARK-21127] [SQL] Update statistics after data changin...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18334 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18334: [SPARK-21127] [SQL] Update statistics after data changin...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18334 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78592/ Test FAILed. ---

[GitHub] spark issue #18334: [SPARK-21127] [SQL] Update statistics after data changin...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18334 **[Test build #78592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78592/testReport)** for PR 18334 at commit

[GitHub] spark pull request #18174: [SPARK-20950][CORE]add a new config to diskWriteB...

2017-06-25 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18174#discussion_r123923859 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java --- @@ -82,6 +82,9 @@ /** The buffer size to use when

[GitHub] spark issue #18417: [INFRA] Close stale PRs

2017-06-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18417 Sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18417: [INFRA] Close stale PRs

2017-06-25 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/18417 an you please keep 17084 open? thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17084: [SPARK-18693][ML][MLLIB] ML Evaluators should use weight...

2017-06-25 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/17084 yes, will update the PR, thanks for the ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18368: [SPARK-21102][SQL] Make refresh resource command less ag...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18368 **[Test build #78596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78596/testReport)** for PR 18368 at commit

[GitHub] spark issue #18346: [SPARK-21134][SQL] Don't collapse codegen-only expressio...

2017-06-25 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18346 ping @cloud-fan any more feedback on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11994 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78595/ Test FAILed. ---

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11994 **[Test build #78595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78595/testReport)** for PR 11994 at commit

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11994 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18368: [SPARK-21102][SQL] Make refresh resource command less ag...

2017-06-25 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/18368 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #18235: [SPARK-21012][Submit] Add glob support for resour...

2017-06-25 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18235#discussion_r123922136 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -310,33 +310,28 @@ object SparkSubmit extends CommandLineUtils {

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11994 **[Test build #78595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78595/testReport)** for PR 11994 at commit

[GitHub] spark issue #18305: [SPARK-20988][ML] Logistic regression uses aggregator hi...

2017-06-25 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/18305 @sethah I will take a look in a few days after some backlog, thanks for your patience. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-06-25 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/11994 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #9518: [SPARK-11574][Core] Add metrics StatsD sink

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9518 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #9518: [SPARK-11574][Core] Add metrics StatsD sink

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9518 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78588/ Test PASSed. ---

[GitHub] spark issue #9518: [SPARK-11574][Core] Add metrics StatsD sink

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9518 **[Test build #78588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78588/testReport)** for PR 9518 at commit

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123921193 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -81,7 +83,8 @@ private[classification]

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123920923 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -313,7 +313,11 @@ class

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123919667 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala --- @@ -128,7 +130,8 @@ private[feature] trait ChiSqSelectorParams

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123919494 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala --- @@ -48,10 +50,11 @@ final class RegressionEvaluator

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123888757 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala --- @@ -46,11 +48,10 @@ class

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123920437 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -45,7 +47,7 @@ private[feature] trait ImputerParams extends Params with

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123919458 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala --- @@ -44,12 +46,10 @@ class

[GitHub] spark pull request #17995: [SPARK-20762][ML]Make String Params Case-Insensit...

2017-06-25 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17995#discussion_r123920352 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala --- @@ -70,6 +71,10 @@ class

[GitHub] spark issue #18414: [SPARK-21169] [core] Make sure to update application sta...

2017-06-25 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18414 @srini-daruna I think I already addressed this issue in SPARK-12552, here is the

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11994 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11994 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78594/ Test FAILed. ---

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11994 **[Test build #78594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78594/testReport)** for PR 11994 at commit

[GitHub] spark issue #18416: [SPARK-21204][SQL][WIP] Add support for Scala Set collec...

2017-06-25 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18416 cc @cloud-fan I'd like to hear your opinion about this `Set` support. Can you provide some insights? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #18416: [SPARK-21204][SQL][WIP] Add support for Scala Set...

2017-06-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18416#discussion_r123920728 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -992,6 +1123,128 @@ case class

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-06-25 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r123918251 --- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql --- @@ -92,3 +92,8 @@ select abs(-3.13), abs('-2.19'); -- positive/negative

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-06-25 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r123918240 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-06-25 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r123919502 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-06-25 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r123919350 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18405 **[Test build #78593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78593/testReport)** for PR 18405 at commit

[GitHub] spark pull request #18106: [SPARK-20754][SQL] Support TRUNC (number)

2017-06-25 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/18106#discussion_r123920115 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -132,3 +133,154 @@ case class Uuid() extends

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11994 **[Test build #78594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78594/testReport)** for PR 11994 at commit

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-06-25 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18405 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18106: [SPARK-20754][SQL] Support TRUNC (number)

2017-06-25 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/18106#discussion_r123919660 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -132,3 +133,154 @@ case class Uuid() extends

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18405 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18405 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78590/ Test FAILed. ---

[GitHub] spark issue #18405: [SPARK-21194][SQL] Fail the putNullmethod when containsN...

2017-06-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18405 **[Test build #78590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78590/testReport)** for PR 18405 at commit

[GitHub] spark issue #18416: [SPARK-21204][SQL][WIP] Add support for Scala Set collec...

2017-06-25 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18416 Currently I can't think of possible issues of serializing `Set` as array. But welcome comments to point any possible issues. --- If your project is set up for it, you can reply to this email and

  1   2   3   >