Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20437#discussion_r164973745
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
---
@@ -157,7 +157,7 @@ class FileInputDStream[K, V, F <:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20400#discussion_r164973111
--- Diff: python/pyspark/sql/window.py ---
@@ -212,16 +218,20 @@ def rangeBetween(self, start, end):
values directly.
Github user guoxiaolongzte commented on a diff in the pull request:
https://github.com/apache/spark/pull/20437#discussion_r164973156
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
---
@@ -157,7 +157,7 @@ class FileInputDStream[K, V, F
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20450
**[Test build #86866 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86866/testReport)**
for PR 20450 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20450
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/421/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20450
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20450
cc @hvanhovell @viirya @ueshin @kiszk @gatorsmile @dongjoon-hyun
---
-
To unsubscribe, e-mail:
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20450
[SPARK-23280][SQL] add map type support to ColumnVector
## What changes were proposed in this pull request?
Fill the last missing piece of `ColumnVector`: the map type support.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20400#discussion_r164972094
--- Diff: python/pyspark/sql/window.py ---
@@ -212,16 +218,20 @@ def rangeBetween(self, start, end):
values directly.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20400#discussion_r164971807
--- Diff: python/pyspark/sql/window.py ---
@@ -124,16 +126,20 @@ def rangeBetween(start, end):
values directly.
:param
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164971509
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/MutableColumnarRow.java
---
@@ -146,9 +146,7 @@ public UTF8String
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/420/
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20438
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20400#discussion_r164968965
--- Diff: python/pyspark/sql/functions.py ---
@@ -809,6 +809,45 @@ def ntile(n):
return Column(sc._jvm.functions.ntile(int(n)))
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20438
thanks, merging to master/2.3!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20437#discussion_r164968292
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
---
@@ -157,7 +157,7 @@ class FileInputDStream[K, V, F <:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164966631
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -17,16 +17,57 @@
package
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
Ah, yup. I am okay with including it. Wanted to double check. Seems a small
clean bug fix.
---
-
To unsubscribe, e-mail:
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20400#discussion_r164966938
--- Diff: python/pyspark/sql/window.py ---
@@ -124,16 +126,20 @@ def rangeBetween(start, end):
values directly.
:param
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20442
**[Test build #86864 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86864/testReport)**
for PR 20442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86864/
Test PASSed.
---
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20373
@HyukjinKwon Yes, I meant to port it too. I agree with matching it to
v0.4.2 as same as we can, so I don't think we should include formatting one but
bug fixes.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20448
**[Test build #86865 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86865/testReport)**
for PR 20448 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/419/
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20400#discussion_r164965129
--- Diff: python/pyspark/sql/functions.py ---
@@ -809,6 +809,45 @@ def ntile(n):
return Column(sc._jvm.functions.ntile(int(n)))
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20400#discussion_r164965040
--- Diff: python/pyspark/sql/functions.py ---
@@ -809,6 +809,45 @@ def ntile(n):
return Column(sc._jvm.functions.ntile(int(n)))
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
Hm .. I was thinking we should focus on matching it to v0.4.2 as same as we
can. Few bug links I and @ueshin found looked regressions comparing to our copy
so I suggested to include them here
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20445
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86855/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20445
**[Test build #86855 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86855/testReport)**
for PR 20445 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
@ueshin, is https://github.com/cloudpipe/cloudpickle/pull/140 a regression
comparing to our cloudcpikle copy, or do you suggest to port it too as it's a
simple and clean bug fix? Seems the same
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20449
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20449
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user advancedxy opened a pull request:
https://github.com/apache/spark/pull/20449
[SPARK-23040][CORE]: Returns interruptible iterator for shuffle reader
## What changes were proposed in this pull request?
Before this commit, a non-interruptible iterator is returned
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20404
@felixcheung what is your opinion on this, do we really need to handle this
case?
---
-
To unsubscribe, e-mail:
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/20422
@squito add a test for index file. plz check it again, thanks.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17332
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20373
>Wait .. @BryanCutler, did you port the formatting one here ..? I was
thinking we should match it to v0.4.2 as same as possible to reduce the diff.
Yes I added that here as well because
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20415
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20415
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86860/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20415
**[Test build #86860 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86860/testReport)**
for PR 20415 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20447
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86858/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20447
Merging to master and 2.3. Thanks for the review!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86858 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86858/testReport)**
for PR 20422 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20442
**[Test build #86864 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86864/testReport)**
for PR 20442 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/418/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164958102
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -17,16 +17,57 @@
package
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20447
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20447
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86859/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20447
**[Test build #86859 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86859/testReport)**
for PR 20447 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20373
What about https://github.com/cloudpipe/cloudpickle/pull/140?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20419
Then, we should add a test case to ensure it will not be broken.
---
-
To unsubscribe, e-mail:
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20442#discussion_r164956149
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -167,25 +167,31 @@ final class QuantileDiscretizer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164956171
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -17,16 +17,57 @@
package
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20442#discussion_r164955798
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -167,25 +167,31 @@ final class QuantileDiscretizer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164955518
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -17,16 +17,57 @@
package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164955297
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -17,16 +17,57 @@
package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164954926
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -17,16 +17,57 @@
package
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20279
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20279
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86853/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86863/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20279
**[Test build #86853 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86853/testReport)**
for PR 20279 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20448
**[Test build #86863 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86863/testReport)**
for PR 20448 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164954221
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -17,16 +17,57 @@
package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164953600
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2QueryPlan.scala
---
@@ -19,50 +19,31 @@ package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164954392
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -17,16 +17,57 @@
package
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20448
**[Test build #86863 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86863/testReport)**
for PR 20448 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/417/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20279
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86854/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20279
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20279
**[Test build #86854 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86854/testReport)**
for PR 20279 at commit
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20435#discussion_r164953225
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -20,14 +20,16 @@ package
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20435#discussion_r164953380
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/memoryV2.scala
---
@@ -30,9 +30,8 @@ import
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86862/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20448
**[Test build #86862 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86862/testReport)**
for PR 20448 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86861/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20448
**[Test build #86861 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86861/testReport)**
for PR 20448 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164952844
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2QueryPlan.scala
---
@@ -19,50 +19,31 @@ package
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20448
**[Test build #86862 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86862/testReport)**
for PR 20448 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20448
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/416/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20448
**[Test build #86861 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86861/testReport)**
for PR 20448 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20448
cc @rdblue @tdas @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20448
[SPARK-23203][SQL] make DataSourceV2Relation immutable
## What changes were proposed in this pull request?
This is inspired by https://github.com/apache/spark/pull/20387, but only
focus
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20419
@gatorsmile Not directly. The `CodeAndComment` case class is just a
"container", it doesn't handle what gets into the `body` field. When we force
embed a comment, it'll leave a comment as a
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20419
@rednaxelafx Does the following
[codes](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala#L1286-L1294)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20419#discussion_r164951129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1227,12 +1227,13 @@ class
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20400
LGTM too except the three comments above.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20400#discussion_r164950417
--- Diff: python/pyspark/sql/functions.py ---
@@ -809,6 +809,45 @@ def ntile(n):
return Column(sc._jvm.functions.ntile(int(n)))
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20400#discussion_r164950531
--- Diff: python/pyspark/sql/functions.py ---
@@ -809,6 +809,45 @@ def ntile(n):
return Column(sc._jvm.functions.ntile(int(n)))
1 - 100 of 664 matches
Mail list logo
