Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21754
> For example, in the test of this pr, it sets 3 in ExchangeCoordinator;
How can this happen? Join has 2 children so `ExchangeCoordinator` can at
most have 2 exchanges.
---
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/21942#discussion_r207103066
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StandardScaler.scala ---
@@ -160,15 +160,89 @@ class StandardScalerModel private[ml] (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21927#discussion_r207107889
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -340,6 +340,22 @@ class DAGScheduler(
}
}
+
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207107551
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/21943
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93927/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93927 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93927/testReport)**
for PR 21469 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21960
Please close this and proceed in #20838. I already approved your PR roughly
a week ago.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21754#discussion_r207106829
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ExchangeCoordinatorSuite.scala
---
@@ -278,6 +278,25 @@ class ExchangeCoordinatorSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21961
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21754#discussion_r207106352
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala
---
@@ -52,6 +52,14 @@ case class ReusedExchangeExec(override val
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21951
LGTM. shall we create a JIRA ticket to apply this to other
`DeclarativeAggregate`s?
---
-
To unsubscribe, e-mail:
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207106350
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21961
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21959
I am going to review and merge that one soon. It doesn't need to open
multiple PRs.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21961
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/21951
LGTM as well. Thanks a lot!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user Satyajitv opened a pull request:
https://github.com/apache/spark/pull/21961
Spark 20597
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Default topic first checks if TOPIC_OPTION_KEY is provided,
Github user holdensmagicalunicorn commented on the issue:
https://github.com/apache/spark/pull/21961
@Satyajitv, thanks! I am a bot who has found some folks who might be able
to help with the review:@tdas, @zsxwing and @cloud-fan
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207106000
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17185
overall LGTM, my major concern is how to do O(1) lookup for the 3 part name
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207105608
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -71,19 +71,27 @@ trait NamedExpression
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207105381
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21941
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21960
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21754
**[Test build #93955 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93955/testReport)**
for PR 21754 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21941
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93936/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21754
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21754
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21941
**[Test build #93936 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93936/testReport)**
for PR 21941 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21960
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21960
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21754#discussion_r207105078
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala
---
@@ -52,6 +52,14 @@ case class ReusedExchangeExec(override val
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207105004
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundation
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/21960
[SPARK-23698] Remove unused definitions of long and unicode
__intlike__ and __unicode__ were defined but not used in the existing code.
__basestring()__was removed in Python 3 in favor of
Github user holdensmagicalunicorn commented on the issue:
https://github.com/apache/spark/pull/21960
@cclauss, thanks! I am a bot who has found some folks who might be able to
help with the review:@tdas, @zsxwing and @marmbrus
---
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/21959
As it says in the commit message, these changes are already in #20838 but
that PR has been open for 139 days and has 50+ comments. The only way that I
seem to make progress is by opening separate
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93920/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21935
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21754
**[Test build #93954 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93954/testReport)**
for PR 21754 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21754
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21754
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21935
**[Test build #93920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93920/testReport)**
for PR 21935 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207104518
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -262,17 +262,47 @@ abstract class Star extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207104432
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -262,17 +262,47 @@ abstract class Star extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21754#discussion_r207104309
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala
---
@@ -89,23 +97,42 @@ case class ReuseExchange(conf: SQLConf)
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21951
LGTM.
On Thu, Aug 2, 2018 at 1:14 AM Xiao Li wrote:
> This will simplify the code and improve the readability. We can do the
> same in the other expression.
>
> â
>
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21943
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21943
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r207104014
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -262,17 +262,47 @@ abstract class Star extends
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21959
I think you can push the changes in
https://github.com/apache/spark/pull/20838 and close this one. They look
virtually the same issue.
---
Github user ijuma commented on the issue:
https://github.com/apache/spark/pull/21955
Looks like some test code is using internal Kafka classes that have changed
or have been removed:
> [error]
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20146
ping @jkbradley @dbtsai shall we consider to include this in 2.4?
---
-
To unsubscribe, e-mail:
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21943#discussion_r207103696
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskScheduler.scala ---
@@ -51,7 +51,7 @@ private[spark] trait TaskScheduler {
//
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19449
**[Test build #93953 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93953/testReport)**
for PR 19449 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #93952 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93952/testReport)**
for PR 21889 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21959
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21943
**[Test build #93951 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93951/testReport)**
for PR 21943 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21959
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21959
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19449
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21951
This will simplify the code and improve the readability. We can do the same
in the other expression.
---
-
To unsubscribe,
Github user holdensmagicalunicorn commented on the issue:
https://github.com/apache/spark/pull/21959
@cclauss, thanks! I am a bot who has found some folks who might be able to
help with the review:@pwendell and @HyukjinKwon
---
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/21959
[SPARK-23698] Define xrange() for Python 3 in dumpdata_script.py
__xrange()__ was removed in Python 3 in favor of __range()__. This simple
change removes three Undefined Names was originally
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21754#discussion_r207103198
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala
---
@@ -52,6 +52,14 @@ case class ReusedExchangeExec(override
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21754#discussion_r207102873
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala
---
@@ -52,6 +52,14 @@ case class ReusedExchangeExec(override val
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93948/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21632
**[Test build #93948 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93948/testReport)**
for PR 21632 at commit
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21954#discussion_r207102738
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -0,0 +1,325 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21952#discussion_r207102304
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
@@ -100,13 +100,14 @@ class AvroSerializer(rootCatalystType:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21954
**[Test build #93950 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93950/testReport)**
for PR 21954 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21954
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21954
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21754#discussion_r207101919
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala
---
@@ -52,6 +52,14 @@ case class ReusedExchangeExec(override
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21754#discussion_r207101662
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala
---
@@ -52,6 +52,14 @@ case class ReusedExchangeExec(override val
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21957
shall we normalize the filters before pushing it down? e.g. `Cast(a, Int) >
100` should be `a > 100` because 100 is within the byte range.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21958
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21958
**[Test build #93949 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93949/testReport)**
for PR 21958 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21958
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21958
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21935#discussion_r207100964
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala
---
@@ -86,8 +87,16 @@ class AvroDeserializer(rootAvroType:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21957
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93946/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21957
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21957
**[Test build #93946 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93946/testReport)**
for PR 21957 at commit
Github user holdensmagicalunicorn commented on the issue:
https://github.com/apache/spark/pull/21958
@cloud-fan, thanks! I am a bot who has found some folks who might be able
to help with the review:@ueshin, @rxin and @JoshRosen
---
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/21958
[minor] remove dead code in ExpressionEvalHelper
## What changes were proposed in this pull request?
This addresses https://github.com/apache/spark/pull/21236/files#r207078480
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21958
cc @srowen @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21935
**[Test build #93947 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93947/testReport)**
for PR 21935 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21957
**[Test build #93946 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93946/testReport)**
for PR 21957 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21632
**[Test build #93948 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93948/testReport)**
for PR 21632 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21957
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21935
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user holdensmagicalunicorn commented on the issue:
https://github.com/apache/spark/pull/21957
@10110346, thanks! I am a bot who has found some folks who might be able to
help with the review:@yhuai, @gatorsmile and @cloud-fan
---
GitHub user 10110346 opened a pull request:
https://github.com/apache/spark/pull/21957
[SPARK-24994][SQL] When the data type of the field is converted to other
types, it can also support pushdown to parquet
## What changes were proposed in this pull request?
For this statement:
1 - 100 of 890 matches
Mail list logo
