[GitHub] spark issue #22771: [SPARK-25773][Core]Cancel zombie tasks in a result stage...

2018-10-30 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22771 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22771: [SPARK-25773][Core]Cancel zombie tasks in a resul...

2018-10-25 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/22771#discussion_r228371144 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1364,6 +1385,21 @@ private[spark] class DAGScheduler

[GitHub] spark pull request #22771: [SPARK-25773][Core]Cancel zombie tasks in a resul...

2018-10-25 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/22771#discussion_r228354020 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1364,6 +1385,21 @@ private[spark] class DAGScheduler

[GitHub] spark issue #22144: [SPARK-24935][SQL] : Problem with Executing Hive UDF's f...

2018-10-24 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22144 Thanks @tgravescs for your latest posts -- they've saved me from posting something similar in many respects but more strongly worded. What is bothering me (not just in the discussion

[GitHub] spark issue #22144: [SPARK-24935][SQL] : Problem with Executing Hive UDF's f...

2018-10-23 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22144 Yes, @rxin I know that I was a little unfair to you in order to make my point sharper. Apologies. My concern is real, though

[GitHub] spark issue #22144: [SPARK-24935][SQL] : Problem with Executing Hive UDF's f...

2018-10-23 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22144 @srowen I understand and agree. What bothers me is that the block-no block decision now often seems to be "not a regression; automatic no block" -- and that doesn't seem r

[GitHub] spark issue #22144: [SPARK-24935][SQL] : Problem with Executing Hive UDF's f...

2018-10-23 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22144 > It’s certainly not a blocker since it’s not a new regression I really hate this line of argument. Somehow we seem to have slipped from "if it is a regression, then we mu

[GitHub] spark issue #22771: [SPARK-25773][Core]Cancel zombie tasks in a result stage...

2018-10-23 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22771 > We can at least try to abort the tasks and still honors the interrupt on cancel flag. It seems like best case is things actually get killed and we free up resources, worst case se

[GitHub] spark issue #22771: [SPARK-25773][Core]Cancel zombie tasks in a result stage...

2018-10-22 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22771 There are long-standing questions here that I don't think have yet been adequately answered -- cf. https://issues.apache.org/jira/browse/SPARK-17064

[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-19 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22463 Where is the discussion on these utility methods no longer being Experimental? I'm not saying that they are not stable, but the Kafka 0.10 API in general being considered to be stable doesn't

[GitHub] spark pull request #22112: [SPARK-23243][Core] Fix RDD.repartition() data co...

2018-08-27 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/22112#discussion_r213061324 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1918,3 +1980,19 @@ object RDD { new DoubleRDDFunctions(rdd.map(x

[GitHub] spark pull request #22112: [SPARK-23243][Core] Fix RDD.repartition() data co...

2018-08-23 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/22112#discussion_r212395101 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1876,6 +1920,22 @@ abstract class RDD[T: ClassTag]( */ object RDD

[GitHub] spark issue #22176: [SPARK-25181][CORE] Limit Thread Pool size in BlockManag...

2018-08-22 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22176 Yes, this is better than what we had, but maybe it can be better still. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22176: [SPARK-25181][CORE] Limit Thread Pool size in BlockManag...

2018-08-22 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22176 @zsxwing we really should have considered whether this should be a configuration variable instead of a fixed number of threads in any environment

[GitHub] spark issue #22112: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-08-22 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22112 I'm not a fan of the IDEMPOTENT, RANDOM_ORDER, COMPLETE_RANDOM naming. IDEMPOTENT is fine, but I'd prefer UNORDERED and INDETERMINATE to cover the cases of "same values in potent

[GitHub] spark issue #21698: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-08-13 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21698 > I really disagree with this. I really agree with Tom. At this point, I think the working assumption should be that any 2.4.0 release candidate that doesn't deliver some

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22039 > Yes, "quick hack", but, as opposed to what in these specific cases? Yes, that is the key question. I'll admit, I haven't looked at all deeply to try to figure out whet

[GitHub] spark issue #22039: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exh...

2018-08-08 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22039 Hmmm... sorry to be late to this, but making pattern matches exhaustive by adding a catch-all case that then throws an exception, while easy, should be considered as a less than optimal fix

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21589 Thank you, @HyukjinKwon There are a significant number of Spark users who use the Job Scheduler model with a SparkContext shared across many users and many Jobs. Promoting tools

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21589 I don't accept you assertions of what constitutes the majority and minority of Spark users or use cases or their relative importance. As a long-time maintainer of the Spark scheduler

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21589 It is precisely because the audience that I am concerned with is not limited to just data scientists or notebook users and their particular needs that I am far from convinced that exposing

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21589 @ssimeonov the purpose of a public API is not to offer hack solutions to a subset of problems. What is needed is a high-level, declarative abstraction that can be used to specify requested Job

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21589 No, defaultParallelism isn't more useful in that case, but that just starts getting to my overall assessment of this JIRA and PR: It smells of defining the problem to align with a preconception

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21589 @mridulm scheduler pools could also make the cluster-wide resource numbers not very meaningful. I don't think the maxShare work has been merged yet (kind of a stalled TODO on an open PR, IIRC

[GitHub] spark pull request #21754: [SPARK-24705][SQL] Cannot reuse an exchange opera...

2018-07-18 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/21754#discussion_r203416454 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -85,14 +85,20 @@ case class ReusedExchangeExec

[GitHub] spark issue #21598: [SPARK-24605][SQL] size(null) returns null instead of -1

2018-06-25 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21598 > case by case Yes, but... this by itself makes the decision appear far too discretionary. Instead, in any PR where you are changing the published interface or behavior of p

[GitHub] spark issue #21598: [SPARK-24605][SQL] size(null) returns null instead of -1

2018-06-23 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21598 @HyukjinKwon this is not new policy. It is what Apache Spark has guaranteed in its version numbering and public API since 1.0.0. It is not a matter of "from now on", but rather

[GitHub] spark issue #21598: [SPARK-24605][SQL] size(null) returns null instead of -1

2018-06-21 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21598 > so we can't just change the default value in a feature release Agreed. Once a particular interface and behavior is in our released public API, then we effectively have a contr

[GitHub] spark issue #21527: [SPARK-24519] MapStatus has 2000 hardcoded

2018-06-18 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21527 Sure, as long as we are not telling users that this is something that they can or should use, that's fine

[GitHub] spark issue #21527: [SPARK-24519] MapStatus has 2000 hardcoded

2018-06-12 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21527 > we can definitely update the description with more details. Eventually, some of the motivation and advice/suggestions need to get into the main user docs, as w

[GitHub] spark issue #21527: [SPARK-24519] MapStatus has 2000 hardcoded

2018-06-11 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21527 @tgravescs If there is value in making it configurable, that is all fine and good. My argument is against making it configurable just for the sake of making it configurable. If there is more

[GitHub] spark issue #21527: [SPARK-24519] MapStatus has 2000 hardcoded

2018-06-11 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21527 > We should make it configurable. That's a debatable assertion all by itself -- and quite unfortunately, there is no more justification for this claim in the JIRA ticket. Without pr

[GitHub] spark pull request #21440: [SPARK-24307][CORE] Support reading remote cached...

2018-05-26 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/21440#discussion_r191063339 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -659,6 +659,11 @@ private[spark] class BlockManager( * Get

[GitHub] spark pull request #20930: [SPARK-23811][Core] FetchFailed comes before Succ...

2018-04-26 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/20930#discussion_r184462542 --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala --- @@ -2399,6 +2399,84 @@ class DAGSchedulerSuite extends

[GitHub] spark issue #21096: [SPARK-24011][CORE] cache rdd's immediate parent Shuffle...

2018-04-18 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21096 As is, this PR isn't acceptable on multiple levels. Even if I were convinced (which I am not presently) that the sequence of `getShuffleDependencies` calls covered in this PR is the only one

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-16 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21071 @rxin +1 for each of your sentences. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20881: Add a note about jobs running in FIFO order in th...

2018-04-03 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/20881#discussion_r178928945 --- Diff: docs/job-scheduling.md --- @@ -215,6 +215,9 @@ pool), but inside each pool, jobs run in FIFO order. For example, if you create means

[GitHub] spark pull request #20881: Add a note about jobs running in FIFO order in th...

2018-04-03 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/20881#discussion_r178886364 --- Diff: docs/job-scheduling.md --- @@ -215,6 +215,9 @@ pool), but inside each pool, jobs run in FIFO order. For example, if you create means

[GitHub] spark issue #20770: [SPARK-23626][CORE] DAGScheduler blocked due to JobSubmi...

2018-03-08 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/20770 @squito is the master of DAGSchedulerSuite, and can provide you the best advice on changing or adding to the existing DAGSchedulerSuite. I'll be back from skiing next week and try to find some

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157790330 --- Diff: examples/src/main/scala/org/apache/spark/examples/BroadcastTest.scala --- @@ -42,7 +42,7 @@ object BroadcastTest { val arr1 = (0

[GitHub] spark pull request #19468: [SPARK-18278] [Scheduler] Spark on Kubernetes - B...

2017-11-15 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/19468#discussion_r151259662 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala --- @@ -0,0

[GitHub] spark pull request #19468: [SPARK-18278] [Scheduler] Spark on Kubernetes - B...

2017-10-20 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/19468#discussion_r146072523 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala --- @@ -0,0

[GitHub] spark issue #19468: [SPARK-18278] [Scheduler] Spark on Kubernetes - Basic Sc...

2017-10-11 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/19468 > iron out the kinks A large chunk of the difficulty in identifying and ironing out kinks in such a project is the difficulty of writing adequate tests of the scheduler code.

[GitHub] spark pull request #19287: [SPARK-22074][Core] Task killed by other attempt ...

2017-09-25 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/19287#discussion_r140788231 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala --- @@ -93,6 +104,8 @@ class TaskInfo( def running: Boolean

[GitHub] spark pull request #19194: [SPARK-20589] Allow limiting task concurrency per...

2017-09-21 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/19194#discussion_r140340018 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -619,6 +625,47 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark pull request #19287: [SPARK-22074][Core] Task killed by other attempt ...

2017-09-20 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/19287#discussion_r140047573 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala --- @@ -66,6 +66,12 @@ class TaskInfo( */ var finishTime: Long

[GitHub] spark issue #19115: [SPARK-21882][CORE] OutputMetrics doesn't count written ...

2017-09-04 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/19115 And now I see that the title was changed to something more useful. Pardon any offense, the end result of the title changes look good

[GitHub] spark issue #19115: [SPARK-21882][CORE] OutputMetrics doesn't count written ...

2017-09-04 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/19115 I realize this PR is now closed, but to follow-up on Saisai's request concerning PR titles, I'll also note that the title of this PR isn't very useful even after the JIRA id and component tag

[GitHub] spark issue #18805: [SPARK-19112][CORE] Support for ZStandard codec

2017-08-21 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/18805 In addition to LICENSE, there is also COPYING in the v1.3.1 release: https://github.com/facebook/zstd/blob/v1.3.1/LICENSE https://github.com/facebook/zstd/blob/v1.3.1/COPYING

[GitHub] spark pull request #18950: [SPARK-20589][Core][Scheduler] Allow limiting tas...

2017-08-15 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/18950#discussion_r133344532 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -602,6 +604,21 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark issue #18807: [SPARK-21601][BUILD] Modify the pom.xml file, increase t...

2017-08-02 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/18807 Yes, it doesn't really hurt anything except to be confusing cruft that has a tendency to accumulate in POMs. If we're going to put those lines back, I suggest that they be accompanied

[GitHub] spark issue #18807: [SPARK-21601][BUILD] Modify the pom.xml file, increase t...

2017-08-02 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/18807 Maven is the build of reference, true; but maven itself doesn't need the JDK version to be specified both in the scala plugin configuration and in the compiler plugin configuration. While I

[GitHub] spark issue #18807: [SPARK-21601][BUILD] Modify the pom.xml file, increase t...

2017-08-02 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/18807 Hmmm... that's arguably broken behavior on the part of IntelliJ or something to be worked around in IntelliJ configuration, not by hacking our POM. Without the POM hack, though

[GitHub] spark issue #18807: [SPARK-21601][BUILD] Modify the pom.xml file, increase t...

2017-08-01 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/18807 These are maven-compiler-plugin configurations. We don't use maven-compiler-plugin to compile Java code: https://github.com/apache/spark/commit/74cda94c5e496e29f42f1044aab90cab7dbe9d38

[GitHub] spark pull request #18093: [WIP][SPARK-20774][SQL] Cancel all jobs when Quer...

2017-07-25 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/18093#discussion_r129382985 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala --- @@ -89,8 +91,22 @@ class QueryExecution(val sparkSession

[GitHub] spark issue #17955: [SPARK-20715] Store MapStatuses only in MapOutputTracker...

2017-05-15 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17955 @JoshRosen Yes, I agree that it is orthogonal -- at least for now. I'm mostly just offering a heads up that if we get around to addressing `interruptThread`, then there may also need to be some

[GitHub] spark issue #17955: [SPARK-20715] Store MapStatuses only in MapOutputTracker...

2017-05-15 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17955 I've looked at only the DAGScheduler changes so far. They LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #17955: [SPARK-20715] Store MapStatuses only in MapOutputTracker...

2017-05-15 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17955 @JoshRosen The hard coding of interruptThread = true within TaskSetManager's handleSuccessfulTask to effect the killing of duplicate, speculative attempts of a task is potentially an issue

[GitHub] spark issue #16165: [SPARK-8617] [WEBUI] HistoryServer: Include in-progress ...

2017-04-05 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16165 @merlintang Marcelo's point remains the same for 2.1.1. We don't typically backport changes to maintenance branches unless they are fixes for regression errors or severe bugs. --- If your

[GitHub] spark pull request #17522: [SPARK-18278] [Scheduler] Documentation to point ...

2017-04-03 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17522#discussion_r109523328 --- Diff: docs/cluster-overview.md --- @@ -52,7 +52,11 @@ The system currently supports three cluster managers: * [Apache Mesos](running

[GitHub] spark pull request #17485: [SPARK-20163] Kill all running tasks in a stage i...

2017-03-31 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17485#discussion_r109174578 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -768,6 +767,19 @@ private[spark] class TaskSetManager

[GitHub] spark pull request #17485: [SPARK-20163] Kill all running tasks in a stage i...

2017-03-30 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17485#discussion_r109038854 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -768,6 +767,19 @@ private[spark] class TaskSetManager

[GitHub] spark issue #17297: [SPARK-14649][CORE] DagScheduler should not run duplicat...

2017-03-28 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17297 Agreed. Let's establish what we want to do before trying to discuss the details of how we are going to do it. On Tue, Mar 28, 2017 at 8:17 AM, Imran Rashid <notificati...@github.

[GitHub] spark issue #17447: [SPARK-20117][Scheduler]TaskSetManager checkSpeculatable...

2017-03-27 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17447 I wouldn't bother with the string interpolation change (there is a good argument to be made that string interpolation doesn't gain you anything in patterns like those in this PR where a single

[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

2017-03-21 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17088#discussion_r107286200 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1365,19 +1375,43 @@ class DAGScheduler( */ private

[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

2017-03-21 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17088#discussion_r107284202 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1683,11 +1716,12 @@ private[scheduler] class

[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

2017-03-21 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17088#discussion_r107284085 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1389,8 +1423,7 @@ class DAGScheduler( clearCacheLocs

[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

2017-03-21 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17088#discussion_r107283229 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1331,7 +1328,20 @@ class DAGScheduler( // TODO

[GitHub] spark issue #17357: [SPARK-20025][CORE] Ignore SPARK_LOCAL* env, while deplo...

2017-03-20 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17357 It's a lot better. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #17297: [SPARK-14649][CORE] DagScheduler should not run d...

2017-03-20 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17297#discussion_r107044660 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -929,12 +946,22 @@ class DAGScheduler

[GitHub] spark pull request #17297: [SPARK-14649][CORE] DagScheduler should not run d...

2017-03-20 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17297#discussion_r107044272 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -803,6 +810,16 @@ class DAGScheduler( stageIdToStage.get

[GitHub] spark pull request #17297: [SPARK-14649][CORE] DagScheduler should not run d...

2017-03-20 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17297#discussion_r107040190 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -418,6 +424,15 @@ private[spark] class MapOutputTrackerMaster(conf

[GitHub] spark pull request #17297: [SPARK-14649][CORE] DagScheduler should not run d...

2017-03-20 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17297#discussion_r107018874 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -378,15 +382,17 @@ private[spark] class MapOutputTrackerMaster(conf

[GitHub] spark pull request #17297: [SPARK-14649][CORE] DagScheduler should not run d...

2017-03-20 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17297#discussion_r107018555 --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala --- @@ -378,15 +382,17 @@ private[spark] class MapOutputTrackerMaster(conf

[GitHub] spark pull request #17297: [SPARK-14649][CORE] DagScheduler should not run d...

2017-03-20 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/17297#discussion_r107017201 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1265,64 +1280,11 @@ class DAGScheduler( val

[GitHub] spark issue #17357: [SPARK-20025][CORE] Fix spark's driver failover mechanis...

2017-03-20 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17357 Please change the title of this PR. "Fixed foo" is nearly useless when scanning the commit log in the future since it doesn't tell us anything about either the nature of t

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-03-06 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17113 @squito Correct, we really only try to kill running tasks currently on job failure (and if the config setting allows it); but there is the long-standing "TODO: Cancel running tasks in the

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-03-06 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17113 @tgravescs At the config level, it is spark.job.interruptOnCancel or SparkContext.SPARK_JOB_INTERRUPT_ON_CANCEL, which then gets passed around as a boolean -- e.g. shouldInterruptThread

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-03-06 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17113 @mridulm Correct, turning task interruption on by default is not so much a matter of Spark itself handling it well as it is a possible (though not completely known) issue with lower layer

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-03-06 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17113 > Spark does immediately abort the stage but it doesn't kill the running tasks Whether running tasks are interrupted on stage abort or not depends on the state of a config bool

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-03-01 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17113 "Current Spark's blacklist mechanism": please be more precise. The most recent released version of Spark, 2.1.0, does not include a lot of recent changes to blacklisting (mos

[GitHub] spark issue #17088: [SPARK-19753][CORE] All shuffle files on a host should b...

2017-02-27 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17088 Even if I completely agreed that removing all of the shuffle files on a host was the correct design choice, I'd still be hesitant to merge this right now. That is simply because we have

[GitHub] spark issue #17045: [SPARK-19373][MESOS] Base spark.scheduler.minRegisteredR...

2017-02-23 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17045 thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #17045: [SPARK-19373][MESOS] fix spark.scheduler.minRegisteredRe...

2017-02-23 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/17045 Please avoid using "fix" as the description in a PR -- it doesn't tell us anything substantive about the nature of the problem or its resolution, so any future reviewing of commi

[GitHub] spark issue #16905: [SPARK-19567][CORE][SCHEDULER] Support some Schedulable ...

2017-02-21 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16905 Thanks, Shane & Kay! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark issue #16905: [SPARK-19567][CORE][SCHEDULER] Support some Schedulable ...

2017-02-21 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16905 If Jenkins is listening to me, that should have allowed you to trigger test for this PR. test this please --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #16905: [SPARK-19567][CORE][SCHEDULER] Support some Schedulable ...

2017-02-21 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16905 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-16 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16620 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #12524: [SPARK-12524][Core]DagScheduler may submit a task set fo...

2017-02-16 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/12524 @JoshRosen I haven't tried to walk through the logs in your JIRA comment, but it wouldn't surprise me at all if this is the same issue that we've been working through in https://github.com

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-13 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100950587 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -719,7 +719,23 @@ object SparkSubmit extends CommandLineUtils

[GitHub] spark pull request #16905: [SPARK-19567][CORE][SCHEDULER] Support some Sched...

2017-02-13 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/16905#discussion_r100836419 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -130,15 +130,17 @@ private[spark] class TaskSchedulerImpl

[GitHub] spark pull request #16905: [SPARK-19567][CORE][SCHEDULER] Support some Sched...

2017-02-13 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/16905#discussion_r100834970 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala --- @@ -37,25 +37,22 @@ private[spark] class Pool( val schedulableQueue

[GitHub] spark issue #16905: [SPARK-19567][CORE][SCHEDULER] Support some Schedulable ...

2017-02-13 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16905 @srowen These refactorings of unnecessary vars to vals is something that we've noted in the discussions of a few other PRs as something that could and probably should be done in a separate PR

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-11 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16620 Thanks for all the investigation and the write up, @kayousterhout This makes good sense to me, and should take us a long way toward both fixing the immediate bug and improving the code. We

[GitHub] spark issue #16876: [SPARK-19537] Move pendingPartitions to ShuffleMapStage.

2017-02-09 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16876 You're welcome -- but do be aware that I'm going to be extremely busy with non-Spark stuff for at least the next week, so for awhile my Spark code reviews are likely to be more cursory than

[GitHub] spark issue #16876: [SPARK-19537] Move pendingPartitions to ShuffleMapStage.

2017-02-09 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16876 Makes good sense to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-07 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16620 @kayousterhout yes, I also looked at duplicating `stage.pendingPartitions -= task.partitionId`. I could live with that. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request #16813: [SPARK-19466][CORE][SCHEDULER] Improve Fair Sched...

2017-02-07 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/16813#discussion_r99964246 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala --- @@ -69,60 +72,81 @@ private[spark] class FairSchedulableBuilder

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-07 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16620 @kayousterhout don't overestimate my enthusiasm for my own suggestion. I'm really just thinking aloud in search of a solution, and I agree with you that the TaskSetManager and DAGScheduler

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-07 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/16620 The way that I am thinking about this right now is that @kayousterhout is on the right track with the early return at https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache

  1   2   3   4   5   6   7   >