https://codereview.chromium.org/469743002/diff/40001/src/compiler/arm/instruction-selector-arm.cc
File src/compiler/arm/instruction-selector-arm.cc (right):
https://codereview.chromium.org/469743002/diff/40001/src/compiler/arm/instruction-selector-arm.cc#newcode151
Committed patchset #4 manually as 23111 (presubmit successful).
https://codereview.chromium.org/469743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 23111
Author: bmeu...@chromium.org
Date: Thu Aug 14 06:33:50 2014 UTC
Log: [turbofan] Refactor the InstructionSelector tests.
Also fix some issues and improve test coverage.
TEST=compiler-unittests
BUG=v8:3489
LOG=y
R=ja...@chromium.org
Review URL:
Comment #4 on issue 3489 by bugdro...@chromium.org: Support use of
Google/Chrome testing infrastructure in V8
http://code.google.com/p/v8/issues/detail?id=3489#c4
The following revision refers to this bug:
Revision: 23112
Author: yang...@chromium.org
Date: Thu Aug 14 06:57:48 2014 UTC
Log: Ignore default reject handler when looking for reject handlers.
LOG=N
BUG=v8:3093
R=aand...@chromium.org
Review URL: https://codereview.chromium.org/461023002
Committed patchset #1 manually as 23112 (presubmit successful).
https://codereview.chromium.org/461023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Comment #57 on issue 3093 by bugdro...@chromium.org: Debugging promises
http://code.google.com/p/v8/issues/detail?id=3093#c57
The following revision refers to this bug:
https://chromium.googlesource.com/external/v8.git/+/0ae0b81cdbadf5ad0448a1871df0737e38eabf02
commit
On 2014/08/13 12:14:06, Vyacheslav Egorov (Google wrote:
Please take a look.
This is a usability improvement for --trace-deopt.
lgtm.
https://codereview.chromium.org/467183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: jochen (slow - soon OOO),
Description:
Fix test expectations.
R=joc...@chromium.org
Please review this at https://codereview.chromium.org/461233003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+-1, -167 lines):
A +
Committed patchset #1 manually as 23113.
https://codereview.chromium.org/461233003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 23113
Author: yang...@chromium.org
Date: Thu Aug 14 07:11:44 2014 UTC
Log: Fix test expectations.
TBR=joc...@chromium.org
Review URL: https://codereview.chromium.org/461233003
http://code.google.com/p/v8/source/detail?r=23113
Added:
On 2014/08/13 19:52:52, Hannes Payer wrote:
Awesome, thanks for fixing. The patch looks good, but could you also add a
regression test?
I have added a test (and checked it failed before the fix). Does it make
sense?
https://codereview.chromium.org/475463003/
--
--
v8-dev mailing list
lgtm, with one comment nit
https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc#newcode4501
test/cctest/test-heap.cc:4501: // the map.
Can you just add
lgtm, with one comment nit
https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc#newcode4501
test/cctest/test-heap.cc:4501: // the map.
Can you just add
Dear Customer,
This is Mr.David Lange With regards to your Company i am sending this
email Regards to order some ( Arm Barriers 900mm x 1800mm x 500 or PF
6000 LUX ) and i will be more happy if you can email me with the size
and Prices that you have for sale as well...Please let me know if
On 2014/08/13 16:34:16, aandrey wrote:
LGTM, but please land this after the 3.29 branch.
https://codereview.chromium.org/464413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/475463003/diff/20001/test/cctest/test-heap.cc#newcode4501
test/cctest/test-heap.cc:4501: // the map.
On 2014/08/14 07:27:32, Hannes Payer wrote:
Revision: 23114
Author: ja...@chromium.org
Date: Thu Aug 14 07:41:33 2014 UTC
Log: Fix pointer iteration for maps.
BUG=
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/475463003
http://code.google.com/p/v8/source/detail?r=23114
Modified:
Committed patchset #3 manually as 23114 (presubmit successful).
https://codereview.chromium.org/475463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
As discussed in depth with Andreas,
The overall plan is to move to Type* when it is ready, but unfortunately the
representation distinction in that type system is not yet complete, and we
are
sloppy everywhere w.r.t to representations.
As in the original CL description, we are actually
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h
File src/compiler/machine-type.h (right):
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h#newcode8
src/compiler/machine-type.h:8: #include src/ostreams.h
Please avoid including
Updates:
Cc: a...@chromium.org
Comment #8 on issue by math...@qiwi.be: Drop the escaped reserved
words as identifiers compatibility measure
http://code.google.com/p/v8/issues/detail?id=
(No comment was entered for this change.)
--
You received this message because this
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h
File src/compiler/machine-type.h (right):
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h#newcode8
src/compiler/machine-type.h:8: #include src/ostreams.h
On 2014/08/14 07:57:02,
LGTM if the src/v8.h issue is addressed.
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h
File src/compiler/machine-type.h (right):
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h#newcode9
src/compiler/machine-type.h:9: #include
Revision: 23115
Author: joc...@chromium.org
Date: Thu Aug 14 08:40:11 2014 UTC
Log: Revert 23058 - Allow externalizing cons and sliced string.
Reason for revert: broke inspector
| Fulfill overdue TODO.
|
| R=mstarzin...@chromium.org
|
| Review URL:
Reviewers: Michael Starzinger, Yang,
Description:
Revert 23058 - Allow externalizing cons and sliced string.
Reason for revert: broke inspector
| Fulfill overdue TODO.
|
| R=mstarzin...@chromium.org
|
| Review URL: https://codereview.chromium.org/460643002
Committed patchset #1 manually as 23115 (presubmit successful).
https://codereview.chromium.org/470913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: jarin,
Message:
PTAL
Description:
[turbofan] Introduce WordRor machine operator.
Move recognition of rotate-right operations to the
MachineOperatorReducer, so we don't need to repeat that in the
InstructionSelector for every backend.
TEST=base-unittests,compiler-unittests,cctests
Revision: 23116
Author: joc...@chromium.org
Date: Thu Aug 14 08:46:03 2014 UTC
Log: Reset trunk to 3.28.71.1
http://code.google.com/p/v8/source/detail?r=23116
Deleted:
/trunk/src/compiler/change-lowering.cc
/trunk/src/compiler/change-lowering.h
Reviewers: Yang,
Description:
Version 3.28.71.2 (merged r23115)
Revert 23058 - Allow externalizing cons and sliced string.
TBR=yang...@chromium.org
Please review this at https://codereview.chromium.org/473823002/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected files (+6, -1 lines):
Committed patchset #1 manually as 23117 (tree was closed).
https://codereview.chromium.org/473823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 23117
Author: joc...@chromium.org
Date: Thu Aug 14 08:49:13 2014 UTC
Log: Version 3.28.71.2 (merged r23115)
Revert 23058 - Allow externalizing cons and sliced string.
TBR=yang...@chromium.org
Review URL: https://codereview.chromium.org/473823002
On 2014/08/14 08:49:21, jochen (slow - soon OOO) wrote:
Committed patchset #1 manually as 23117 (tree was closed).
lgtm.
https://codereview.chromium.org/473823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Revision: 23118
Author: joc...@chromium.org
Date: Thu Aug 14 08:49:28 2014 UTC
Log: Tagging version 3.28.71.2
http://code.google.com/p/v8/source/detail?r=23118
Added:
/tags/3.28.71.2
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Revision: 23119
Author: joc...@chromium.org
Date: Thu Aug 14 09:00:30 2014 UTC
Log: Create V8 3.28 branch for Chrome 38
http://code.google.com/p/v8/source/detail?r=23119
Added:
/branches/3.28
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Reviewers: Jakob,
Description:
Fast-forward version number on bleeding_edge to 3.29.0
BUG=none
LOG=n
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/470083002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M
lgtm
https://codereview.chromium.org/470083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 23120
Author: joc...@chromium.org
Date: Thu Aug 14 09:05:28 2014 UTC
Log: Fast-forward version number on bleeding_edge to 3.29.0
BUG=none
LOG=n
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/470083002
http://code.google.com/p/v8/source/detail?r=23120
Committed patchset #1 manually as 23120 (tree was closed).
https://codereview.chromium.org/470083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm with one comment - please update the .gn file.
https://codereview.chromium.org/469213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
Done.
https://codereview.chromium.org/469213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 23121
Author: bmeu...@chromium.org
Date: Thu Aug 14 09:07:58 2014 UTC
Log: [turbofan] Introduce WordRor machine operator.
Move recognition of rotate-right operations to the
MachineOperatorReducer, so we don't need to repeat that in the
InstructionSelector for every backend.
Committed patchset #2 manually as 23121 (tree was closed).
https://codereview.chromium.org/469213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Turbofan isn't ready for prime-time yet anyway, so you definitely don't
need to
implement the entire backend right away. The changes required for being
able to
compile and run tests (with TF disabled) should be fairly small; you can
look at
the mips/mips64/x87 ports for examples.
Looking
Committed patchset #8 manually as 23122 (tree was closed).
https://codereview.chromium.org/470593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: ,
Message:
Committed patchset #1 manually as 23123 (tree was closed).
Description:
Fix MSVC build.
And while we are at it, use the stupid MSVC compiler intrinsics.
TEST=base-unittests/BitTest
TBR=ja...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=23123
Revision: 23123
Author: bmeu...@chromium.org
Date: Thu Aug 14 09:24:40 2014 UTC
Log: Fix MSVC build.
And while we are at it, use the stupid MSVC compiler intrinsics.
TEST=base-unittests/BitTest
TBR=ja...@chromium.org
Review URL: https://codereview.chromium.org/473773003
Reviewers: jarin,
Message:
Committed patchset #1 manually as 23124 (tree was closed).
Description:
Really fix windows now.
TBR=ja...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=23124
Please review this at https://codereview.chromium.org/472783002/
SVN Base:
Revision: 23124
Author: bmeu...@chromium.org
Date: Thu Aug 14 09:31:52 2014 UTC
Log: Really fix windows now.
TBR=ja...@chromium.org
Review URL: https://codereview.chromium.org/472783002
http://code.google.com/p/v8/source/detail?r=23124
Modified:
lgtm
https://codereview.chromium.org/467293003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: marja,
Description:
Purge unused internalized string accessors.
R=ma...@chromium.org
Please review this at https://codereview.chromium.org/471923002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+37, -58 lines):
M include/v8.h
M src/api.cc
M
lgtm - nice!
https://codereview.chromium.org/471923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Revision: 23125
Author: tit...@chromium.org
Date: Thu Aug 14 09:52:21 2014 UTC
Log: Enable more tests for simplified lowering after assuming signed
for word32.
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/461933002
Committed patchset #1 manually as 23125 (tree was closed).
https://codereview.chromium.org/461933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
PTAL
https://codereview.chromium.org/453833003/diff/20001/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/453833003/diff/20001/src/compiler/js-inlining.cc#newcode75
src/compiler/js-inlining.cc:75: /// Ensure that only a single return
Reviewers: Toon Verwaest,
Description:
Enable access check tests that no longer fail with TF.
R=verwa...@chromium.org
Please review this at https://codereview.chromium.org/473873002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -15 lines):
M
Revision: 23126
Author: dslo...@chromium.org
Date: Thu Aug 14 10:24:19 2014 UTC
Log: Fix OrderedHashTabelIterator accessors.
They might be undefined for uninitialized iterators.
The rest of the code is ready for this eventuality.
R=a...@chromium.org, ad...@chromium.org
BUG=403292
https://codereview.chromium.org/453833003/diff/40001/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/453833003/diff/40001/src/compiler/js-inlining.cc#newcode27
src/compiler/js-inlining.cc:27: static void
ReplaceEffectfulWithValue(Node* node,
Committed patchset #2 manually as 23126 (tree was closed).
https://codereview.chromium.org/468813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
LGTM with one final round of comments to address.
https://codereview.chromium.org/453833003/diff/40001/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/453833003/diff/40001/src/compiler/js-inlining.cc#newcode48
Thanks!
I will sit on this until Chrome is branched, as the tree is throttled right
now.
https://codereview.chromium.org/467183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
lgtm
https://codereview.chromium.org/471953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer, Benedikt Meurer,
Message:
Removing the test because it sometimes produces invalid instance type
(which is
checked during GC).
Description:
Remove the flaky store buffer test for maps.
BUG=
Please review this at https://codereview.chromium.org/471953002/
SVN Base:
Reviewers: jochen (OOO until Sept),
Message:
Thanks for comments (mostly done expect one counter-argument).
https://codereview.chromium.org/366153002/diff/61/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/366153002/diff/61/include/v8.h#newcode968
Committed patchset #1 manually as 23127 (tree was closed).
https://codereview.chromium.org/471953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 23127
Author: ja...@chromium.org
Date: Thu Aug 14 11:31:42 2014 UTC
Log: Remove the flaky store buffer test for maps.
BUG=
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/471953002
http://code.google.com/p/v8/source/detail?r=23127
Modified:
Reviewers: aandrey,
Description:
Fix PromiseHasRejectHandler.
The odd-numbered items in the queue are deferred objects, not promises.
R=aand...@chromium.org
Please review this at https://codereview.chromium.org/473803003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Reviewers: Benedikt Meurer,
Description:
Deprecte LoweringBuilder in favor of Reducer.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/476733002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+38, -138 lines):
M BUILD.gn
M
lgtm
https://codereview.chromium.org/476733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Message:
Yang, could you please take a look, thanks.
Description:
Add serializer support for builtins pointed by InnerPointer for out-of-line
constant pool.
This is required for test-serialize tests which fail at the DCHECK on L1874
of
serialize.cc otherwise.
Please review
Reviewers: paul.l..., balazs.kilvady, akos.palfi.imgtec, gergely.kis.imgtec,
Description:
MIPS: Fix deoptimization entry table when branch cannot reach.
This fixes failures when table has more than 8192 entries, and preserves
optimization to have 2 instructions per entry.
Committed patchset #1 manually as 23128 (tree was closed).
https://codereview.chromium.org/476733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 23128
Author: mstarzin...@chromium.org
Date: Thu Aug 14 12:24:37 2014 UTC
Log: Deprecate LoweringBuilder in favor of Reducer.
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/476733002
http://code.google.com/p/v8/source/detail?r=23128
Deleted:
Reviewers: Benedikt Meurer,
Message:
Benedikt could you please take a look, thanks.
Description:
[turbofan]: Fix TurboFan for out-of-line constant pool on Arm.
Use LeaveFrame so that the constant pool pointer register is correctly
restored
when using the out-of-line constant pool. Also
Comment #58 on issue 3093 by dome...@domenicdenicola.com: Debugging promises
http://code.google.com/p/v8/issues/detail?id=3093
Ignore default reject handler when looking for reject handlers.
I don't know exactly what implementation strategy you guys are pursuing, so
I could be wrong, but I
Committed patchset #1 manually as 23129 (tree was closed).
https://codereview.chromium.org/467293003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 23129
Author: verwa...@chromium.org
Date: Thu Aug 14 13:02:49 2014 UTC
Log: Rewrite GetAccessor using the LookupIterator
BUG=
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/467293003
http://code.google.com/p/v8/source/detail?r=23129
Modified:
Comment #59 on issue 3093 by yang...@chromium.org: Debugging promises
http://code.google.com/p/v8/issues/detail?id=3093
@#58:
Default reject handlers should count as toward being handled, I agree. But,
consider this:
var p = new Promise() {
throw new Error();
}
var q = p.then(function()
lgtm
https://codereview.chromium.org/473873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/469283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Comment #60 on issue 3093 by dome...@domenicdenicola.com: Debugging promises
http://code.google.com/p/v8/issues/detail?id=3093
@#59:
OK, I guess I was focused too much on the displaying-unhandled-rejections
feature, and not on the when-to-break feature. Sounds like you have things
well in
Committed patchset #1 manually as 23130 (tree was closed).
https://codereview.chromium.org/473873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 23130
Author: mstarzin...@chromium.org
Date: Thu Aug 14 13:24:57 2014 UTC
Log: Enable access check tests that no longer fail with TF.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/473873002
http://code.google.com/p/v8/source/detail?r=23130
Modified:
LGTM.
https://codereview.chromium.org/474963002/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):
https://codereview.chromium.org/474963002/diff/1/src/compiler/scheduler.cc#newcode625
src/compiler/scheduler.cc:625: Zone zone(zone_-isolate());
As experimented offline: We
Reviewers: vsevik, yurys, aandrey,
Description:
Expose function CheckDebugBreak in the debugger api
It is needed by blink change:
https://codereview.chromium.org/473923002
BUG=
Please review this at https://codereview.chromium.org/473913002/
SVN Base:
lgtm
https://codereview.chromium.org/473913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
+yangguo, Please take a look
https://codereview.chromium.org/473913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
LGTM.
https://codereview.chromium.org/477623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
PTAL.
Description:
Correctly handle holes when concat()ing double arrays
BUG=chromium:403409
LOG=y
Please review this at https://codereview.chromium.org/468863003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+36, -9
Revision: 23131
Author: dusan.milosavlje...@imgtec.com
Date: Thu Aug 14 15:23:01 2014 UTC
Log: MIPS: Fix deoptimization entry table when branch cannot reach.
This fixes failures when table has more than 8192 entries, and preserves
optimization to have 2 instructions per entry.
Committed patchset #1 manually as 23131 (tree was closed).
https://codereview.chromium.org/477623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Toon Verwaest,
Description:
Reorder native javascript files.
R=verwa...@chromium.org
BUG=403717
LOG=N
Please review this at https://codereview.chromium.org/470083003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+16, -243 lines):
M BUILD.gn
A
Reviewers: Michael Achenbach (OOO),
Description:
[Auto-roll] Bump up version to 3.29.1.0
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/473943002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M
Committed patchset #1 manually as 23132 (tree was closed).
https://codereview.chromium.org/473943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 23132
Author: machenb...@chromium.org
Date: Thu Aug 14 15:34:12 2014 UTC
Log: [Auto-roll] Bump up version to 3.29.1.0
TBR=machenb...@chromium.org
Review URL: https://codereview.chromium.org/473943002
http://code.google.com/p/v8/source/detail?r=23132
Modified:
Reviewers: Benedikt Meurer, ulan,
Description:
ARM64: Refactor instruction selection unit tests.
BUG=
Please review this at https://codereview.chromium.org/475823002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+107, -72 lines):
M
lgtm
https://chromiumcodereview.appspot.com/473913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Reviewers: titzer,
Description:
Load global object and builtins from activation.
BUG=
R=tit...@chromium.org
Please review this at https://codereview.chromium.org/474633003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+107, -19 lines):
M
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
File
test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
(right):
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
File
test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
(right):
1 - 100 of 112 matches
Mail list logo
