http://bugzilla.kernel.org/show_bug.cgi?id=14668


Rafael J. Wysocki <r...@sisk.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24318|0                           |1
        is obsolete|                            |




--- Comment #17 from Rafael J. Wysocki <r...@sisk.pl>  2010-01-30 20:19:32 ---
Created an attachment (id=24808)
 --> (http://bugzilla.kernel.org/attachment.cgi?id=24808)
ACPI / EC: Do not carry out EC transactions while suspended

I wonder if this patch makes any difference.

It is a modified version of the Alex's patch from comment #9, but (1) it closes
the race between acpi_ec_transaction() and acpi_ec_suspend/resume() (so the
suspend routine will actually wait for transactions in progress to complete
before setting the flag and disabling the GPE) and (2) it prevents transactions
from being carried out while suspended regardless of the global lock (so
there's no difference in behavior between the systems with and without the
global lock).

It should work for you if the theory is correct and if no one else acquires the
global lock independently.

_However_, it may introduce regressions, because disabling the EC transactions
at this point may be too early (_PTS is still going to be called after that). 
So, it may be necessary to move the disabling of EC transactions to the
platform prepare callback, right after _PTS has been executed.

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to