http://bugzilla.kernel.org/show_bug.cgi?id=14668





--- Comment #20 from Rafael J. Wysocki <r...@sisk.pl>  2010-01-30 21:35:04 ---
(In reply to comment #18)
> >I'm not sure the patch does exactly what you wanted.  I thought it would just
> >release the global lock instead of merely preventing it from being acquired.
> >
> >Also, shouldn't we actually make sure that the global lock is released before
> >suspend to RAM?  As well as in the hibernate .pre_snapshot() phase?  Alex?
> 
> Why?
> 
> My patch (which doesn't work sadly), takes the lock, and then sets global
> variable (lock_suspended), then it releases it (and does release the 
> _hardware_
> lock.

I don't see that happen in the patch (perhaps I'm misreading it).  How is the
hardware lock released?  You should have called acpi_ev_release_global_lock()
(directly or indirectly) for that to happen, but I don't see that in your
patch.  You only seem to set acpi_gbl_global_lock_suspended, which doesn't have
any effect if the hardware lock is already being held at this point (which we
assume is the case, BTW).

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to