On 18 November 2010 00:17, Kerim Aydin <ke...@u.washington.edu> wrote:
> Hmm, it's, you know, pseudocode.  I mean, I usually do that in roughing
> out before deciding final data structures.
>
> But you're right.  It should have been:
> #define DISFAVORED 4
> *(CFJlist + N)->Jstatus[Plookup("G.")] = DISFAVORED
>
> Much better, right?

Well, it's just that your code implied that every CFJ had a slot for
every single player of the game, which is just *confusing* --
dynamically created slots? What about naming conflicts with the
identifiers? I would have expected something like:

cfj->wishes[Player->named("G")] = DISFAVORED;

or even

Player->named("G")->wishes[cfj] = DISFAVORED;

:-)

(#defined DISFAVORED 4? Ever heard of an enum? :P)

Reply via email to