To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=53572





------- Additional comments from [EMAIL PROTECTED] Fri Dec  2 01:57:33 -0800 
2005 -------
dbo made me aware of another strange thing in your patches.  There are a number
of places where you obviously work around problems with how sal_Unicode is
defined on your platform (e.g., cppu/inc/com/sun/star/uno/Type.hxx,
sw/source/filter/ww8/ww8scan.cxx).  I think the real solution for that problem
(with whatever error messages it actually manifested itself on your platform)
would be in how sal_Unicode is defined in sal/inc/sal/types.h:
  #if defined(SAL_W32)
  typedef wchar_t sal_Unicode;
  #else
  typedef sal_uInt16 sal_Unicode;
  #endif
What that code shall achieve is that sal_Unicode is a typedef for an unsigned
integral 16 bit type on all platforms (the way we use the MS compiler on
Windows, wchar_t is a typedef for unsigned short there, btw.)
I assume the following about your platform:
- SAL_W32 is defined
- wchar_t is a type of its own, not a typedef
- in addition, wchar_t might be 32 bit wide, instead of 16 bit wide, but I am
not sure about it (I would have to see the actual error messages you fix with
your patches to speculate more about this)
The correct solution would probably be to make sal_Unicode a typedef for
sal_uInt16 for your platform.  (See also the thread "SAL_W32 sal_Unicode" I just
started on dev@openoffice.org; maybe we can simplify the above code to "typedef
sal_uInt16 sal_Unicode;" for all platforms, removing the need for #ifdefs.)

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to