On 23/11/17 02:00 PM, Nathan Stratton Treadway wrote: > On Wed, Nov 22, 2017 at 11:58:12 -0500, Jean-Louis Martineau wrote: > > On 22/11/17 12:56 AM, Nathan Stratton Treadway wrote: > > > On Mon, Nov 20, 2017 at 11:45:07 -0500, Jean-Louis Martineau wrote: > > > > Nathan, > > > > > > > > I was too fast to write the first patch, and you are completely > right. > > > > > > > > I committed the attached patch,now amflush use the --no-dump > argument > > > > and driver merge both 'nodump' and '--no-dump'. > > > > > > Yeah, looks good. > > > > > > I applied this patch and ran the test again, and "amdump --no-dump > > > --no-flush" worked just as well as with the previous patch, but showed > > > no "dumper lines" in the log.*.0 file. > > > > > > (Of course the email report did still have the unexpected RESULTS > > > MISSING line for each DLE.) > > I already committed a fix for that, use SVN or GIT. > > My next step will be to rebuild the latest version from git and use that > for further tests, but while I'm working on that: > > The code used in the above test did include the Report-3.5.diff patch > from Nov 17, which eliminated the RESULTS MISSING lines in the report > when amdump is run with a BADHOST argument. > > Did you also push a fix that eliminates the RESULTS MISSING lines which > were being generated when amdump is run with "--no-dump" instead of > BADHOST? (This was the case I was referring to above, following up from > my original discussion in an email from Sat, 18 Nov 2017 00:43:32 > -0500.) > > I looked through the git log (for the 3_5 branch) but didn't notice any > changes that seemed to apply to that problem (either on the > Report.pm/human.pm > <http://Report.pm/human.pm> > side, or on the planner.c side). If you did fix that > case, could you point me to the commit date or commit id?
I forgot to commit it. It is now committed. Jean-Louis > > Thanks. > > Nathan > > ---------------------------------------------------------------------------- > Nathan Stratton Treadway - natha...@ontko.com - Mid-Atlantic region > Ray Ontko & Co. - Software consulting services - http://www.ontko.com/ > <http://www.ontko.com/> > GPG Key: http://www.ontko.com/~nathanst/gpg_key.txt > <http://www.ontko.com/~nathanst/gpg_key.txt> > ID: 1023D/ECFB6239 > Key fingerprint = 6AD8 485E 20B9 5C71 231C 0C32 15F3 ADCD ECFB 6239 This message is the property of CARBONITE, INC. and may contain confidential or privileged information. If this message has been delivered to you by mistake, then do not copy or deliver this message to anyone. Instead, destroy it and notify me by reply e-mail
