I've now started to review the version -17. I would say it's not ready yet to leave the WG.
Here some initial questions:

In Section 7.1, the last 3 elements fall outside of the structure "voucher".  Why is this the case? Can we correct/unify this or is there a reason (in which case we'd need to explain). For me personally, the less unneeded hierarchy the better; but the prime goal should be consistency - i.e. leafs at the same level in the hierarchy - where possible.

In Section 8.1, similar question.

In Section 8.3, "expires-on" is present twice. This is not the case in 8.1, so it looks like 8.1/8.3 are not in sync?

We use RFC 6125 as reference, though it's not very important I think. This RFC has been obsoleted. I think we should remove or change this reference. Not sure which reference is good?

I'm preparing a few editorial fixes in a single PR. One thing I found is that "Voucher Artifact" and "Voucher" and "Artifact" are all equal by the definitions in the Terminology section. It all refers to the Voucher Data plus the signature applied to it. Is that correct? (If so I'll add a cross-reference in the terms so it's easier for a reader to understand this.)

Esko

--
*IoTconsultancy.nl* | Email/Teams: [email protected] | +31 6 2385 8339
_______________________________________________
Anima mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to