Supun Kamburugamuva wrote:
Hi all,
+1 for refactoring the HTTP transport sections and +1 for having a
good set of test cases.
Since we are agreeing to doing this, I suggest we should have a good
design before going on. I think we have enough knowledge and
experience to get this right at this point. So I'm looking forward to
see a very good discussion in the mailing lists for making this right
at this time.
But testing and test suite has to be priority even beyond design
discussion. That is one of the key areas that we lag. So I would like
for us to discuss testing first. Then to discuss design.
So how best can we test the transport code that we have?
Thanks,
Samisa...
Regards,
Supun..
On Fri, Jun 27, 2008 at 9:04 AM, Samisa Abeysinghe <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
Manjula Peiris wrote:
Hi devs,
Most of the code in Axis2/C transport is not organized
properly. This
makes it very difficult to do some changes or adding new
functionality
to the code. One main reason for this is REST handling and
SOAP handling
are mixed in the cod,e in a very ugly manner. Axis2/JAVA has a
separate
section called MessageBuilder which happened before the
Transport stuff
in order to separate out REST Invocations, SOAP invocations
and other
different messaging mechanisms. I propose we do something like
that or
at least separate out REST handling inside HTTP transport.(I
mean at
least separate REST code to different functions or .c files. )
This can
be a post 1.5 fix.
I am always +1 for refactoring and improvements. Mind you, one of
the key pre-requisites of refactoring is testing, to guarantee pre
and post refactoring code bases have the same behavior.
Do we have a good enough test for this, if not, IMHO, we should
build a good set of tests before we endeavor on this re-factoring
mission. Else would we have tough time fixing post-refactoring bugs.
Thanks,
Samisa...
Thanks,
-Manjula.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>
------------------------------------------------------------------------
No virus found in this incoming message.
Checked by AVG. Version: 8.0.101 / Virus Database:
270.4.1/1519 - Release Date: 6/25/2008 4:13 PM
--
Samisa Abeysinghe Director, Engineering; WSO2 Inc.
http://www.wso2.com/ - "The Open Source SOA Company"
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>
------------------------------------------------------------------------
No virus found in this incoming message.
Checked by AVG.
Version: 8.0.101 / Virus Database: 270.4.1/1521 - Release Date: 6/26/2008 11:20 AM
--
Samisa Abeysinghe
Director, Engineering; WSO2 Inc.
http://www.wso2.com/ - "The Open Source SOA Company"
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]