Ronan Waide <[EMAIL PROTECTED]> writes: > On August 8, [EMAIL PROTECTED] said:
>> stuff. IMHO, none of this stuff should be executed in a mode hook, >> but on load of the mode file. > > What you have to bear in mind is that much of this code predates > things like advice (and possibly eval-on-load) First, my apologies: it's eval-after-load, not eval-on-load. I just checked---more or less current semantics appears to have been there since 19.29 for eval-after-load. File advice.el seems to indicate that there was even a version that worked in Emacs 18, but some other comments say in current form it would not work. > [...] not > significantly changed since it was written for emacs 18. In > particular, bbdb-vm and bbdb-gnus tend to be the most up-to-date > sections as they're what I and one of the other main contributors use > on a daily basis. [...] > contribute needs to work on both Emacs and XEmacs. BBDB is allegedly > baselined against Emacs 19, but I don't entirely believe that's true > any more, and there's a lot of v18 cruft in there that really needs to > go, but the bottom line is that I can't accept code that doesn't at > least work in current (released, not CVS) versions of both emacs > flavours. I wonder what is the right policy concerning compatibility---would not claim to know the Right Answer(TM). I have seen people take two opposite attitudes: Only the current (stable) version is the one one should support and one should support all the version possible that does not require rewriting Emacs :). It would be nice if an official policy regarding BBDB was stated someplace. I am also (personally) not thrilled with the attitude of refusing to support CVS Emacs. I understand the reasoning behind it---trying to catch up with a moving target plus lack of resources. If I ever make any contribution, I would not be much use for verifying Xemacs compatibility---do not use it and do not have a recent copy of it. Perhaps we could put together a list of people willing to try things for different mailer/emacs version combinations (and gnus, of course, and whatever else is relevant). Finally, getting back to the original question: I will send in a possible patch that's not likely to mess anything up too much. I am just trying to see how far to go in my (proposed) solution. Cheers, --Boris ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/