Steve Bertrand wrote:
> If anyone has the time to review and report, I would much appreciate
it.
> http://ipv6canada.com/extra_billing.txt
1. I don't see a header comment block.
2. I don't see comment section boundaries.
3. I don't see author information.
4. I don't see a copyright notice.
5. I don't see any POD.
6. I don't see command line options/ processing.
7. I don't see a usage message.
8. I prefer 4 column indentation.
9. I prefer limiting my code to 72 columns.
10. I don't see a version control system tag; I use CVS and put $Id$
near the top of all my files. Version control is a key differentiator
between hacked code and professional systems software product. If your
company is using this script to bill people, your company and customers
expect the latter.
11. Use h2xs to create a module and move your code into it. (Another
key differentiator.)
12. Do you have automated regression tests? (Another key
differentiator.)
13. You're using a lot of 'my' variables to fetch fields from data
structures. I do this and/or suffer through with the full syntax, but
have always wanted a cleaner solution. Perhaps a full set of accessors?
AUTOLOAD? Alias?
Here's a fairly current example of my coding style which demonstrates
all of the above points:
http://www.holgerdanske.com/node/460
HTH,
David
--
To unsubscribe, e-mail: beginners-unsubscr...@perl.org
For additional commands, e-mail: beginners-h...@perl.org
http://learn.perl.org/
