Jonathan Harris wrote:
On Thu, Dec 29, 2011 at 6:39 PM, John W. Krahn<jwkr...@shaw.ca>  wrote:

Igor made a lot of good points.  Here are my two cents worth.  You are
using the File::Find module to traverse the file system and add new files
along the way.  This _may_ cause problems on some file systems. It would
probably be better to get a list of applicable files first and then use
that list to create your new files.  And you should have some way to handle
the situation where a file exists that already has an '.md5' file or an
'.md5' file exists with no corresponding plain file.


Hi John

Thanks for your 2 cents

I hadn't considered that the module wouldn't be portable

That is not what I was implying. I was saying that when you add new files to a directory that you are traversing you _may_ get irregular results. It depends on how your operating system updates directory entries.


If that is the case, then maybe it would be best to
ditch File::Find altogether?
Have you had experience with the module causing issues on certain systems?

It would be a shame, as I've just got it working! - Thanks to Igor, I no
longer use the unnecessary dir handles!

I agree that it may be worth examining the directory for existing .md5
files and skipping them
I'll look in to adding that in to the code



John
--
Any intelligent fool can make things bigger and
more complex... It takes a touch of genius -
and a lot of courage to move in the opposite
direction.                   -- Albert Einstein

--
To unsubscribe, e-mail: beginners-unsubscr...@perl.org
For additional commands, e-mail: beginners-h...@perl.org
http://learn.perl.org/


Reply via email to