LGTM2 under Yoav's stated conditions, plus adding the mode Noah suggested and the additional documentation. I recommend a web.dev article about the why of this change and with the ways developers can plan for it.
On Mon, Jan 24, 2022 at 6:48 AM 'Daniel Vogelheim' via blink-dev < blink-dev@chromium.org> wrote: > On Sun, Jan 23, 2022 at 7:47 PM Daniel Bratell <bratel...@gmail.com> > wrote: > >> Maybe it's wrong to call it "removal" too, since it will still be >> available for those sites that use site-keyed clusters. It's just making >> site-keyed clusters opt-in instead of opt-out. It's not going away, but it >> will require an extra step to use. >> > > This is true, but I'm not sure where to go with this. Since we're > effectively asking (affected) site owners to change something, it's > arguably closer to a deprecation than to a "normal" feature which would add > functionality. To that end, calling it "deprecation" does get the right > people's attention. I suspect that people would have missed it if we had > called it "origin cluster opt-in" or something. But of course, technically > it indeed isn't a deprecation, because the functionality itself remains > available. Should I change the title? > > I think a more comprehensive document that spells out the > options/consequences more clearly solves most of this problem. :) > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALG6KPNueOvzs%2BYKy7qrN5J7jiY2sctYnuxtX-Thvnb0m5SVtQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALG6KPNueOvzs%2BYKy7qrN5J7jiY2sctYnuxtX-Thvnb0m5SVtQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw88wJ%2BUG89E0%2BcNUS4xe1F%2BDFd9Y%2BD%3DNgRzcRuweFFfoQ%40mail.gmail.com.
