I echo Dana's concern about removing per-file owners and would like to see that policy rethought. Agree with Peter's observations as well.
-Ken On Wed, Jul 27, 2022 at 9:12 AM Peter Boström <p...@chromium.org> wrote: > I'm worried that this process excludes/penalizes folks who may be OOO for > extended leave (incl long stretches of parental leave, bereavement) and > have that in their Gerrit status. This should not be a source of review > latency, if it is Gerrit should better surface that they are OOO. > > Are any of the inactive owners, who did opt out last time, a source of > review latency? I.e. are reviews assigned to them but they don't review > them within some SLO window? Otherwise I strongly suggest we let folks > decline the OWNERS removal (at other OWNERS' discretion who should probably > review removal CLs). > > On Wed, Jul 27, 2022 at 8:08 AM <dan...@chromium.org> wrote: > >> This list includes per-file owners, did the script look for 100 CLs in *those >> files* named by the rule when deciding to remove the person? >> >> On Tue, Jul 26, 2022 at 9:16 PM Kentaro Hara <hara...@chromium.org> >> wrote: >> >>> Hi >>> >>> As of 2022 July, Chromium has 4531 OWNERS files containing 6850 names. >>> These include inactive owners, which are one of the sources of slow code >>> review latency. One year ago, we cleaned up inactive owners >>> <https://groups.google.com/a/chromium.org/g/chromium-dev/c/MpOgk56qKS0/m/HHy7G19oAwAJ> >>> and removed ~500 inactive owners. I propose running the clean-up process >>> again to keep the OWNERS files updated. >>> >>> Specifically, a person is identified as an "inactive" owner iff: >>> >>> - >>> >>> The person didn't commit or review any CLs in the directory they own >>> while there were 100+ CLs that touched the directory in the past 6 months >>> (as of July 6, 2022). >>> >>> Last year, I gave the inactive owners an option to flip the decision >>> manually to stay as an owner, but for this cycle, I'm planning to remove >>> the inactive owners unconditionally. The rationale is 1) if the person made >>> no contribution on a very active directory for 6 months, it will be >>> reasonable to say that the person is inactive, and 2) if there is any >>> special reason for it and the person needs to stay as an owner, the person >>> can show evidence that they are meeting the owners expectations >>> <https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#expectations-of-owners> >>> and be readded through the standard OWNERS nomination process. >>> >>> Specifically, people listed in this spreadsheet >>> <https://docs.google.com/spreadsheets/d/1gJbXzTaoITvCDmQaqMmGCvfOngrcFtMPmMsGhHgEV_4/edit#gid=0> >>> are identified as inactive owners and will be removed. >>> >>> I understand this is a tricky proposal. Having your name on OWNERS is an >>> award for your previous amazing contributions, and I understand your >>> feeling about your name being removed. However, I think it's important to >>> keep the OWNERS files updated so that Chromium developers can find active >>> owners and improve the code review latency. >>> >>> If you have any questions / concerns, please let me know. Thanks! >>> -- >>> Kentaro Hara, Tokyo >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABg10jyArLjDp0ixPu%2BCSZ9NVrn0M1GwNFiJqiPGRE1f0mrbfQ%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABg10jyArLjDp0ixPu%2BCSZ9NVrn0M1GwNFiJqiPGRE1f0mrbfQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> -- >> Chromium Developers mailing list: chromium-...@chromium.org >> View archives, change email options, or unsubscribe: >> http://groups.google.com/a/chromium.org/group/chromium-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "Chromium-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to chromium-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHtyhaTNC4tgQbqbUq%2BQdFfcORr3aFobjgbeE%2BTaVf7eDgU2Bg%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHtyhaTNC4tgQbqbUq%2BQdFfcORr3aFobjgbeE%2BTaVf7eDgU2Bg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > -- > Chromium Developers mailing list: chromium-...@chromium.org > View archives, change email options, or unsubscribe: > http://groups.google.com/a/chromium.org/group/chromium-dev > --- > You received this message because you are subscribed to the Google Groups > "Chromium-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to chromium-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAGFX3sFB9G8R2MyHT6rjVtEFRAKMeyCTH6Yu0DYqUOfLPCxCBw%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAGFX3sFB9G8R2MyHT6rjVtEFRAKMeyCTH6Yu0DYqUOfLPCxCBw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMYvS2fj3oTeEoQBxJeXxuajYv-Wnv1RPyC6Z%2BYj8BGh_KJRTg%40mail.gmail.com.
