On Thu, 13 Oct 2022 07:56:09 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Ludovic Henry has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Remove unrelated change >> - Merge branch 'master' of github.com:openjdk/jdk into >> dev/ludovic/upstream-hsdis-cross-compile >> - 8295262: Build binutils out of source tree >> >> Currently, when passing --with-binutils-src, binutils is built in the >> source tree. That leads to conflicting targets when compiling for different >> architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target) >> from the same jdk source tree. >> >> The simplest solution is to build binutils out-of-tree and into the >> build/<target>/binutils folder. These out-of-tree builds are already >> supported by binutils and only require some changes in the way we invoke the >> binutils/configure command. > > src/utils/hsdis/binutils/hsdis-binutils.c line 571: > >> 569: dinfo->disassembler_options = >> 570: disassembler_options != NULL && disassembler_options[0] != '\0' ? >> 571: disassembler_options : NULL; > > This hunk looks irrelevant to the issue? I needed it to successfully run hsdis. I'll remove it, check if it's still necessary, and potentially submit it in another PR. ------------- PR: https://git.openjdk.org/jdk/pull/10689
