On Thu, 13 Oct 2022 08:41:35 GMT, Ludovic Henry <[email protected]> wrote:
>> Currently, when passing --with-binutils-src, binutils is built in the source
>> tree. That leads to conflicting targets when compiling for different
>> architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target)
>> from the same jdk source tree.
>>
>> The simplest solution is to build binutils out-of-tree and into the
>> build/<target>/binutils folder. These out-of-tree builds are already
>> supported by binutils and only require some changes in the way we invoke the
>> binutils/configure command.
>
> Ludovic Henry has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains three additional
> commits since the last revision:
>
> - Remove unrelated change
> - Merge branch 'master' of github.com:openjdk/jdk into
> dev/ludovic/upstream-hsdis-cross-compile
> - 8295262: Build binutils out of source tree
>
> Currently, when passing --with-binutils-src, binutils is built in the
> source tree. That leads to conflicting targets when compiling for different
> architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target)
> from the same jdk source tree.
>
> The simplest solution is to build binutils out-of-tree and into the
> build/<target>/binutils folder. These out-of-tree builds are already
> supported by binutils and only require some changes in the way we invoke the
> binutils/configure command.
Other than that, it looks good.
make/autoconf/lib-hsdis.m4 line 137:
> 135: UTIL_FIXUP_PATH(BINUTILS_SRC)
> 136:
> 137: BINUTILS_DIR="${OUTPUTDIR}/binutils"
Suggestion:
BINUTILS_DIR="$CONFIGURESUPPORT_OUTPUTDIR/binutils"
Rationale: "configure-support" includes things that are created by the
configure script. We try to avoid cluttering the top level build directory.
-------------
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10689
