On Thu, 13 Oct 2022 08:41:35 GMT, Ludovic Henry <luhe...@openjdk.org> wrote:
>> Currently, when passing --with-binutils-src, binutils is built in the source >> tree. That leads to conflicting targets when compiling for different >> architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target) >> from the same jdk source tree. >> >> The simplest solution is to build binutils out-of-tree and into the >> build/<target>/binutils folder. These out-of-tree builds are already >> supported by binutils and only require some changes in the way we invoke the >> binutils/configure command. > > Ludovic Henry has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Remove unrelated change > - Merge branch 'master' of github.com:openjdk/jdk into > dev/ludovic/upstream-hsdis-cross-compile > - 8295262: Build binutils out of source tree > > Currently, when passing --with-binutils-src, binutils is built in the > source tree. That leads to conflicting targets when compiling for different > architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target) > from the same jdk source tree. > > The simplest solution is to build binutils out-of-tree and into the > build/<target>/binutils folder. These out-of-tree builds are already > supported by binutils and only require some changes in the way we invoke the > binutils/configure command. This looks good to me. I tested hsdis builds on these platforms and they pass: server-release-aarch64-linux-gnu server-release-arm-linux-gnueabihf server-release-i686-linux-gnu server-release-powerpc64le-linux-gnu server-release-powerpc64-linux-gnu- server-release-riscv64-linux-gnu server-release-s390x-linux-gnu server-release-x86_64-linux-gnu zero-release-alpha-linux-gnu zero-release-arm-linux-gnueabi zero-release-arm-linux-gnueabihf zero-release-m68k-linux-gnu zero-release-mips64el-linux-gnuabi64 zero-release-mipsel-linux-gnu zero-release-powerpc-linux-gnu zero-release-sh4-linux-gnu zero-release-sparc64-linux-gnu ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.org/jdk/pull/10689
