On Tue, 17 Jan 2023 16:15:33 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:

>> Archie L. Cobbs has updated the pull request incrementally with three 
>> additional commits since the last revision:
>> 
>>  - Remove unused type variable on method visitScoped().
>>  - Remove expression type filtering; it doesn't seem to be needed.
>>  - Clean up unused import.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
>  line 908:
> 
>> 906:     public void visitAssert(JCAssert tree) {
>> 907:         scan(tree.cond);
>> 908:         refs.discardExprs(depth);
> 
> Should also handle `tree.detail`? (Obscure of course, but could be `assert 
> true : foo(this);`.)

Thanks - will fix.

-------------

PR: https://git.openjdk.org/jdk/pull/11874

Reply via email to